Pcieutil to load the platform api first instead of using common api #1672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you please update the description to state why this change is necessary? |
4 tasks
pcieutil/main.py
Outdated
| except ImportError as e: | ||
| log.log_error("Failed to load default PcieUtil module. Error : {}".format(str(e)), True) | ||
| raise e | ||
| self.log_error("Failed to load platform Pcie module. Error : {}".format(str(e)), True) |
There was a problem hiding this comment.
Please change self to log
Suggested change
| self.log_error("Failed to load platform Pcie module. Error : {}".format(str(e)), True) | |
| log.log_error("Failed to load platform Pcie module. Error : {}".format(str(e)), True) |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@jleveque @ArunSaravananBalachandran do you have any other comments? |
jleveque
approved these changes
Jun 25, 2021
qiluo-msft
pushed a commit
that referenced
this pull request
Jun 28, 2021
…1672) What I did Pcieutil to load the platform api first instead of using common api Some platform device with different BIOS version needs more than one pcie configuration to check the pcie devices properly. Please refer to the platform api support : sonic-net/sonic-platform-common#195 How I did it Load the platform pcie api first prior to use the common api
sujinmkang
pushed a commit
to sonic-net/sonic-buildimage
that referenced
this pull request
Jun 29, 2021
Why I did it To determine the revision of the pcie.yaml to be used based on BIOS version in DellEMC S6100 platform. Depends on: sonic-net/sonic-platform-common#195 How I did it Added two revisions of pcie.yaml pcie_1.yaml and pcie_2.yaml Included a platform-specific Pcie class to provide the revision of the pcie.yaml to be used by pcieutil/pcied. How to verify it Execute pcieutil check (sonic-net/sonic-utilities#1672) command and verify the list of PCIe devices displayed. Logs: UT_logs.txt
5 tasks
qiluo-msft
pushed a commit
to sonic-net/sonic-buildimage
that referenced
this pull request
Jul 14, 2021
Why I did it To determine the revision of the pcie.yaml to be used based on BIOS version in DellEMC S6100 platform. Depends on: sonic-net/sonic-platform-common#195 How I did it Added two revisions of pcie.yaml pcie_1.yaml and pcie_2.yaml Included a platform-specific Pcie class to provide the revision of the pcie.yaml to be used by pcieutil/pcied. How to verify it Execute pcieutil check (sonic-net/sonic-utilities#1672) command and verify the list of PCIe devices displayed. Logs: UT_logs.txt
carl-nokia
pushed a commit
to carl-nokia/sonic-buildimage
that referenced
this pull request
Aug 7, 2021
…net#7875) Why I did it To determine the revision of the pcie.yaml to be used based on BIOS version in DellEMC S6100 platform. Depends on: sonic-net/sonic-platform-common#195 How I did it Added two revisions of pcie.yaml pcie_1.yaml and pcie_2.yaml Included a platform-specific Pcie class to provide the revision of the pcie.yaml to be used by pcieutil/pcied. How to verify it Execute pcieutil check (sonic-net/sonic-utilities#1672) command and verify the list of PCIe devices displayed. Logs: UT_logs.txt
raphaelt-nvidia
pushed a commit
to raphaelt-nvidia/sonic-utilities
that referenced
this pull request
Aug 10, 2021
…onic-net#1672) What I did Pcieutil to load the platform api first instead of using common api Some platform device with different BIOS version needs more than one pcie configuration to check the pcie devices properly. Please refer to the platform api support : sonic-net/sonic-platform-common#195 How I did it Load the platform pcie api first prior to use the common api
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Pcieutil to load the platform api first instead of using common api
Some platform device with different BIOS version needs more than one pcie configuration to check the pcie devices properly.
Please refer to the platform api support : sonic-net/sonic-platform-common#195
How I did it
Load the platform pcie api first prior to use the common api
How to verify it
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)