-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[sonic-yang] Backlinks are none when there is 0 backlinks #8187
Merged
+7
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@praveen-li Could you help review |
qiluo-msft
previously approved these changes
Jul 15, 2021
qiluo-msft
approved these changes
Jul 15, 2021
praveen-li
approved these changes
Jul 15, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, fix the alignment if wrong, before merge. Thx.
qiluo-msft
pushed a commit
to qiluo-msft/sonic-buildimage
that referenced
this pull request
Jul 16, 2021
Update FRR to 7.5.1. The following is a list of new commits. ``` df7ab485b FRRouting Release 7.5.1 f4ed841b8 Merge pull request sonic-net#8187 from opensourcerouting/rpmfixes-75 86d5a20e3 Merge pull request sonic-net#8193 from mjstapp/fix_signals_7_5 b339cc149 lib: avoid signal-handling race with event loop poll call 0f7b432c3 lib: add debug output for signal mask c0290c86d lib: add sigevent_check api 7a5348665 doc: Fix CentOS 7 Documentation 2a8e69f48 Merge pull request sonic-net#8064 from donaldsharp/foo cf4d1a744 redhat: Fix changelog incorrect date format b78dcb209 Merge pull request sonic-net#8181 from idryzhov/7.5-zebra-blackhole 2032e7e72 zebra: don't use kernel nexthops for blackhole routes e52003567 bgpd: When deleting a neighbor from a peer-group the PGNAME is optional aa86a6a6f Merge pull request sonic-net#8161 from mjstapp/fix_sa_7_5_backports 13a8efb4b Merge pull request sonic-net#8156 from idryzhov/7.5-backports-2021-02-26 58911c6ed lib: Free memory leak in error path in clippy 556dfd211 lib: use right type for wconv() return val bd9caa8f1 lib: fix some misc SA warnings 683b3fe3f lib: register dependency between control plane protocol and vrf nb nodes b45248fb6 lib: add definitions for vrf xpaths 7b9f10d04 lib: add ability to register dependencies between northbound nodes 9c240815c bgpd: Bgp peer group issue d1b43634b bgpd: upon bgp deletion, do not systematically ask to remove main bgp f5d1dc55e bgpd: Fix crash when we don't have a nexthop c2e463478 frr-reload: rpki context exiting uses exit and not end f11db1698 bgpd: Blackhole nexthops are not reachable c628e94ff staticd: fix vrf enabling 49b079ef1 staticd: fix nexthop creation and installation 0077038e9 staticd: fix nexthop validation be3dfbbc7 zebra: use AF_INET for protocol family ```
lolyu
pushed a commit
to lolyu/sonic-buildimage
that referenced
this pull request
Jul 26, 2021
Update FRR to 7.5.1. The following is a list of new commits. ``` df7ab485b FRRouting Release 7.5.1 f4ed841b8 Merge pull request sonic-net#8187 from opensourcerouting/rpmfixes-75 86d5a20e3 Merge pull request sonic-net#8193 from mjstapp/fix_signals_7_5 b339cc149 lib: avoid signal-handling race with event loop poll call 0f7b432c3 lib: add debug output for signal mask c0290c86d lib: add sigevent_check api 7a5348665 doc: Fix CentOS 7 Documentation 2a8e69f48 Merge pull request sonic-net#8064 from donaldsharp/foo cf4d1a744 redhat: Fix changelog incorrect date format b78dcb209 Merge pull request sonic-net#8181 from idryzhov/7.5-zebra-blackhole 2032e7e72 zebra: don't use kernel nexthops for blackhole routes e52003567 bgpd: When deleting a neighbor from a peer-group the PGNAME is optional aa86a6a6f Merge pull request sonic-net#8161 from mjstapp/fix_sa_7_5_backports 13a8efb4b Merge pull request sonic-net#8156 from idryzhov/7.5-backports-2021-02-26 58911c6ed lib: Free memory leak in error path in clippy 556dfd211 lib: use right type for wconv() return val bd9caa8f1 lib: fix some misc SA warnings 683b3fe3f lib: register dependency between control plane protocol and vrf nb nodes b45248fb6 lib: add definitions for vrf xpaths 7b9f10d04 lib: add ability to register dependencies between northbound nodes 9c240815c bgpd: Bgp peer group issue d1b43634b bgpd: upon bgp deletion, do not systematically ask to remove main bgp f5d1dc55e bgpd: Fix crash when we don't have a nexthop c2e463478 frr-reload: rpki context exiting uses exit and not end f11db1698 bgpd: Blackhole nexthops are not reachable c628e94ff staticd: fix vrf enabling 49b079ef1 staticd: fix nexthop creation and installation 0077038e9 staticd: fix nexthop validation be3dfbbc7 zebra: use AF_INET for protocol family ```
carl-nokia
pushed a commit
to carl-nokia/sonic-buildimage
that referenced
this pull request
Aug 7, 2021
Update FRR to 7.5.1. The following is a list of new commits. ``` df7ab485b FRRouting Release 7.5.1 f4ed841b8 Merge pull request sonic-net#8187 from opensourcerouting/rpmfixes-75 86d5a20e3 Merge pull request sonic-net#8193 from mjstapp/fix_signals_7_5 b339cc149 lib: avoid signal-handling race with event loop poll call 0f7b432c3 lib: add debug output for signal mask c0290c86d lib: add sigevent_check api 7a5348665 doc: Fix CentOS 7 Documentation 2a8e69f48 Merge pull request sonic-net#8064 from donaldsharp/foo cf4d1a744 redhat: Fix changelog incorrect date format b78dcb209 Merge pull request sonic-net#8181 from idryzhov/7.5-zebra-blackhole 2032e7e72 zebra: don't use kernel nexthops for blackhole routes e52003567 bgpd: When deleting a neighbor from a peer-group the PGNAME is optional aa86a6a6f Merge pull request sonic-net#8161 from mjstapp/fix_sa_7_5_backports 13a8efb4b Merge pull request sonic-net#8156 from idryzhov/7.5-backports-2021-02-26 58911c6ed lib: Free memory leak in error path in clippy 556dfd211 lib: use right type for wconv() return val bd9caa8f1 lib: fix some misc SA warnings 683b3fe3f lib: register dependency between control plane protocol and vrf nb nodes b45248fb6 lib: add definitions for vrf xpaths 7b9f10d04 lib: add ability to register dependencies between northbound nodes 9c240815c bgpd: Bgp peer group issue d1b43634b bgpd: upon bgp deletion, do not systematically ask to remove main bgp f5d1dc55e bgpd: Fix crash when we don't have a nexthop c2e463478 frr-reload: rpki context exiting uses exit and not end f11db1698 bgpd: Blackhole nexthops are not reachable c628e94ff staticd: fix vrf enabling 49b079ef1 staticd: fix nexthop creation and installation 0077038e9 staticd: fix nexthop validation be3dfbbc7 zebra: use AF_INET for protocol family ```
carl-nokia
pushed a commit
to carl-nokia/sonic-buildimage
that referenced
this pull request
Aug 7, 2021
…8187) Backlinks are none when there is 0 backlinks. without this change backlinks.number() throws an exception when backlinks==None.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Backlinks are none when there is 0 backlinks. without this change
backlinks.number()
throws an exception when backlinks==None.How I did it
Allow backlinks to be None, so we get an empty list as a return from find_data_dependencies
How to verify it
(added UT for the same idea)
Which release branch to backport (provide reason below if selected)