Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Netberg Aurora 715 support #8604

Merged
merged 3 commits into from
Oct 26, 2021

Conversation

andrewsapronov
Copy link
Contributor

@andrewsapronov andrewsapronov commented Aug 26, 2021

Why I did it

Suport Innovium based platform Netberg Aurora 715
ASIC: Innovium Teralynx IVM 55300
Pors: 32x 100G

How I did it

Added specification x86_64-netberg_aurora_715-r0 device/netberg directory
Added platform/innovium/sonic-platform-modules-netberg contains kernel modules, scripts and sonic_platform package.
Modified the platform/innovium/one-image.mk and platform/innovium/rule.mk to include Aurora 715 related ID and files.

How to verify it

Build sonic
Install the image on the device and verify the related components are installed and shown correctly.

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106

Description for the changelog

Initial support for Netberg Aurora 715

A picture of a cute animal (not mandatory but encouraged)

KostiantynYarovyiBf and others added 3 commits August 22, 2021 10:59
Why I did it
Pcied running by python 2.

How I did it
dropped python2 support and add python3 support for pcied in file docker-pmon.supervisord.conf.j2

How to verify it
docker exec pmon supervisorctl status
Signed-off-by: Andrew Sapronov <andrew.sapronov@gmail.com>
@ghost
Copy link

ghost commented Aug 26, 2021

CLA assistant check
All CLA requirements met.

@lgtm-com
Copy link

lgtm-com bot commented Aug 26, 2021

This pull request introduces 7 alerts when merging ea2844a into 48da159 - view on LGTM.com

new alerts:

  • 7 for Wrong number of arguments in a class instantiation

@andrewsapronov
Copy link
Contributor Author

@lguohan could you please review this PR. Did we miss something?

@andrewsapronov
Copy link
Contributor Author

@sujinmkang @prgeor - Can you review and approve the changes ?

@sujinmkang
Copy link
Collaborator

@andrewsapronov Can you please share the show platform commands output?

@andrewsapronov
Copy link
Contributor Author

@andrewsapronov Can you please share the show platform commands output?

@sujinmkang please find logs attached. They are from an older version of master. Building today's master failed as well as the commit time master (failed on sonic_config_engine test units).
nba715-showplatform+sensors.txt

@sujinmkang
Copy link
Collaborator

@andrewsapronov LGTM but I want you to check this two questions below.

  1. PSU2_FAN1 is this your device issue or could it be an api issue?
 root@sonic:/home/admin# show platform fan
  Drawer    LED        FAN    Speed    Direction    Presence    Status          Timestamp
--------  -----  ---------  -------  -----------  ----------  --------  -----------------
     N/A    N/A  PSU1_FAN1      77%          N/A     Present        OK  20210612 02:53:58
     N/A    N/A  PSU2_FAN1       0%          N/A     Present    Not OK  20210612 02:53:58
  1. Health and Temperature is not reported with this cli. Can you check why?
admin@sonic:~$ show platform ssdhealth 
Device Model : KINGSTON RBUSNS4180S3128GJ
Health       : N/A
Temperature  : N/A

@andrewsapronov
Copy link
Contributor Author

LGTM
@sujinmkang LGTM's errors are false positives with other platforms ( like in #8717 - the wrong name/number of the argument alerts are due to different platform definitions)

1. PSU2_FAN1  is this your device issue or could it be an api issue?

It was just one cable plugged. Sorry for this. Please check the attached file with plug/unplug the power.

2. Health and Temperature is not reported with this cli. Can you check why?

As I understand, according to sonic_ssd there are not so many ssd vendors supported:

        self.vendor_ssd_utility = {
            "Generic"  : { "utility" : SMARTCTL, "parser" : self.parse_generic_ssd_info },
            "InnoDisk" : { "utility" : INNODISK, "parser" : self.parse_innodisk_info },
            "M.2"      : { "utility" : INNODISK, "parser" : self.parse_innodisk_info },
            "StorFly"  : { "utility" : VIRTIUM,  "parser" : self.parse_virtium_info },
            "Virtium"  : { "utility" : VIRTIUM,  "parser" : self.parse_virtium_info }
        }

With Kingston we are going through the generic approach with just model detection. There is neither fw nor endurance in generic SSD type.
nba715-psustatus.txt
nba715-smartctl.txt

@andrewsapronov
Copy link
Contributor Author

@sujinmkang Any more questions? We have more HW pending for PR.

@andrewsapronov
Copy link
Contributor Author

Hi,
@sujinmkang @lguohan does the PR need anything else?

@sujinmkang
Copy link
Collaborator

lgtm for now. Let's see if we can have a health check for generic approach or if we can add a health check for Kingstone.

@sujinmkang sujinmkang merged commit 8eab0e0 into sonic-net:master Oct 26, 2021
@andrewsapronov andrewsapronov deleted the master-nba715-support branch November 18, 2021 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants