Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DellEMC: Initial commit for S5224F platform support #8717

Merged
merged 5 commits into from
Sep 26, 2021

Conversation

arunlk-dell
Copy link
Contributor

Why I did it

Added support for the device S5224F

How I did it

Implemented the support for the platform S5224F

Switch Vendor: DellEMC

  • Switch SKU: S5224F-ON
  • ASIC Vendor: Broadcom
  • SONiC Image: sonic-broadcom.bin

How to verify it

Verified the show platform/interface commands

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106

Description for the changelog

A picture of a cute animal (not mandatory but encouraged)

s5212_logs.txt

@lgtm-com
Copy link

lgtm-com bot commented Sep 9, 2021

This pull request introduces 27 alerts when merging 28ca0d7 into 7e02f7b - view on LGTM.com

new alerts:

  • 8 for Wrong number of arguments in a class instantiation
  • 6 for Unused import
  • 5 for Variable defined multiple times
  • 4 for Unused local variable
  • 1 for Module imports itself
  • 1 for 'import *' may pollute namespace
  • 1 for Wrong name for an argument in a class instantiation
  • 1 for Result of integer division may be truncated

@lgtm-com
Copy link

lgtm-com bot commented Sep 9, 2021

This pull request introduces 20 alerts when merging 0524903 into 7e02f7b - view on LGTM.com

new alerts:

  • 8 for Wrong number of arguments in a class instantiation
  • 3 for Unused import
  • 3 for Variable defined multiple times
  • 2 for Unused local variable
  • 1 for Module imports itself
  • 1 for 'import *' may pollute namespace
  • 1 for Wrong name for an argument in a class instantiation
  • 1 for Result of integer division may be truncated

@yozhao101
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@lgtm-com
Copy link

lgtm-com bot commented Sep 9, 2021

This pull request introduces 20 alerts when merging dccccc6 into 8171bfe - view on LGTM.com

new alerts:

  • 8 for Wrong number of arguments in a class instantiation
  • 3 for Unused import
  • 3 for Variable defined multiple times
  • 2 for Unused local variable
  • 1 for Module imports itself
  • 1 for 'import *' may pollute namespace
  • 1 for Wrong name for an argument in a class instantiation
  • 1 for Result of integer division may be truncated

@arunlk-dell
Copy link
Contributor Author

@sujinmkang @prgeor - Can you review and approve the changes ?

sujinmkang
sujinmkang previously approved these changes Sep 14, 2021
@sujinmkang sujinmkang self-requested a review September 16, 2021 23:00
@sujinmkang
Copy link
Collaborator

@arunlk-dell Can you please check those LGTM alerts?

@lgtm-com
Copy link

lgtm-com bot commented Sep 21, 2021

This pull request introduces 11 alerts when merging fc0704d into 4049067 - view on LGTM.com

new alerts:

  • 8 for Wrong number of arguments in a class instantiation
  • 1 for Module imports itself
  • 1 for 'import *' may pollute namespace
  • 1 for Wrong name for an argument in a class instantiation

@arunlk-dell
Copy link
Contributor Author

@sujinmkang.....Have addressed the LGTM alerts, the wrong name/number of the argument alerts are due to different platform definitions.

sujinmkang
sujinmkang previously approved these changes Sep 24, 2021
@lgtm-com
Copy link

lgtm-com bot commented Sep 26, 2021

This pull request introduces 11 alerts when merging 15f2c25 into b0b0ba8 - view on LGTM.com

new alerts:

  • 8 for Wrong number of arguments in a class instantiation
  • 1 for Module imports itself
  • 1 for 'import *' may pollute namespace
  • 1 for Wrong name for an argument in a class instantiation

@sujinmkang sujinmkang merged commit c668f2a into sonic-net:master Sep 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants