[y_cable] Support for initialization of new daemon ycable to support ycables #9125
Conversation
ycables Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
There was a problem hiding this comment.
@vdahiya12 can we rename the daemon to 'ycabled' just to have uniformity with other processes running in PMON? Also added other comments.
| @@ -108,6 +108,25 @@ dependent_startup=true | |||
| dependent_startup_wait_for=rsyslogd:running | |||
| {% endif %} | |||
|
|
|||
| {% if 'subtype' in DEVICE_METADATA['localhost'] and DEVICE_METADATA['localhost']['subtype'] == 'DualToR' %} | |||
| {% if not skip_xcvrd %} | |||
There was a problem hiding this comment.
why this check 'skip_xcvrd'? how is this new daemon dependent on xcvrd?
There was a problem hiding this comment.
I think we should have a separate flag for skip_ycabled, to keep homogeneous with other daemons
| {% if 'subtype' in DEVICE_METADATA['localhost'] and DEVICE_METADATA['localhost']['subtype'] == 'DualToR' %} | ||
| {% if not skip_xcvrd %} | ||
| [program:ycable] | ||
| {% if delay_xcvrd %} |
There was a problem hiding this comment.
why delay start of ycable daemon based upon 'delay_xcvrd'?
There was a problem hiding this comment.
I think we should have a separate flag for delay_ycabled
| {% else %} | ||
| command=nice -n -20 {% if API_VERSION == 3 and 'ycable' not in python2_daemons %}python3 {% else %} python2 {% endif %}/usr/local/bin/ycable | ||
| {% endif %} | ||
| priority=6 |
There was a problem hiding this comment.
you seem to be reusing the 'priority' level of xcvrd. is this intentional?
There was a problem hiding this comment.
I am thinking about it, all daemons have a priority from 1-10. Maybe need to have this as 7 ?
rules/sonic-ycable.mk
Outdated
|
|
||
| SONIC_YCABLE_PY2 = sonic_ycable-1.0-py2-none-any.whl | ||
| $(SONIC_YCABLE_PY2)_SRC_PATH = $(SRC_PATH)/sonic-platform-daemons/sonic-ycable | ||
| $(SONIC_YCABLE_PY2)_DEPENDS = $(SONIC_PY_COMMON_PY2) $(SONIC_PLATFORM_COMMON_PY2) | ||
| $(SONIC_YCABLE_PY2)_DEBS_DEPENDS = $(LIBSWSSCOMMON) $(PYTHON_SWSSCOMMON) | ||
| $(SONIC_YCABLE_PY2)_PYTHON_VERSION = 2 | ||
| SONIC_PYTHON_WHEELS += $(SONIC_YCABLE_PY2) |
There was a problem hiding this comment.
We are moving to PY3 only, then why PY2 support?
dockers/docker-platform-monitor/docker-pmon.supervisord.conf.j2
Outdated
Show resolved
Hide resolved
Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
|
Dependent on this sonic-net/sonic-platform-daemons#219 and module update |
dockers/docker-platform-monitor/docker-pmon.supervisord.conf.j2
Outdated
Show resolved
Hide resolved
Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
we add this commit in sonic-platform-daemons 94fa239 [y_cable] refactor y_cable to a seperate logic and new daemon from xcvrd (sonic-net#219) Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
…to support-ycable
| {% if not skip_ycabled %} | ||
| [program:ycabled] | ||
| {% if delay_ycabled %} | ||
| command=bash -c "sleep 30 nice -n -20 python3 /usr/local/bin/ycabled" |
There was a problem hiding this comment.
'&&' missing between sleep and nice ?
There was a problem hiding this comment.
Thank You for the catch, yes fixed now
Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
Signed-off-by: vaibhav-dahiya vdahiya@microsoft.com
This PR also adds the commit in sonic-platform-daemons
94fa239 [y_cable] refactor y_cable to a seperate logic and new daemon from xcvrd (#219)
Why I did it
This PR separates the logic of Y-Cable from xcvrd. Before this change we were utilizing xcvrd daemon to control all aspects of Y-Cable right from initialization to processing requests from other entities like orch,linkmgr.
Now we would have another daemon ycabled which will serve this purpose.
Logically everything still remains the same from the perspective of other daemons.
it also take care aspects like init/delete daemon from Y-Cable perspective.
How I did it
To serve the purpose we build a new wheel sonic_ycabled-1.0-py3-none-any.whl and install it inside pmon.
We also initalize the daemon ycabled which serves our purpose for refactor inside pmon
How to verify it
Ran the changes with an image for dualtor tests on a 7050cx3 platform
Which release branch to backport (provide reason below if selected)
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)