[y_cable] refactor y_cable to a seperate logic and new daemon from xcvrd #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
|
This pull request introduces 2 alerts when merging 6f2c778 into 1565a23 - view on LGTM.com new alerts:
|
Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
|
This pull request introduces 8 alerts and fixes 1 when merging 7422365 into ddb22b9 - view on LGTM.com new alerts:
fixed alerts:
|
|
@vdahiya12 can yo fix LGTM warnings? |
Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
|
This pull request introduces 12 alerts and fixes 1 when merging f4d160c into 1fd3d16 - view on LGTM.com new alerts:
fixed alerts:
|
Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
|
This pull request introduces 12 alerts and fixes 1 when merging c2e15fb into 7b95211 - view on LGTM.com new alerts:
fixed alerts:
|
Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
|
This pull request introduces 5 alerts and fixes 1 when merging abfc6f0 into 7b95211 - view on LGTM.com new alerts:
fixed alerts:
|
|
This pull request introduces 1 alert and fixes 1 when merging e082871 into 7b95211 - view on LGTM.com new alerts:
fixed alerts:
|
|
This pull request fixes 1 alert when merging 37e1a50 into 7b95211 - view on LGTM.com fixed alerts:
|
Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
|
This pull request introduces 5 alerts and fixes 1 when merging a2ee7b8 into 07542cb - view on LGTM.com new alerts:
fixed alerts:
|
Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
|
This pull request introduces 1 alert and fixes 1 when merging c73c508 into c4127c2 - view on LGTM.com new alerts:
fixed alerts:
|
Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
|
This pull request introduces 1 alert and fixes 1 when merging 9ee55b2 into c4127c2 - view on LGTM.com new alerts:
fixed alerts:
|
|
This pull request fixes 1 alert when merging c34bea7 into c4127c2 - view on LGTM.com fixed alerts:
|
Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
|
This pull request fixes 1 alert when merging fd6e520 into c4127c2 - view on LGTM.com fixed alerts:
|
Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
|
This pull request fixes 1 alert when merging 519307d into c4127c2 - view on LGTM.com fixed alerts:
|
prgeor
previously approved these changes
Jan 19, 2022
sonic-xcvrd/tests/test_xcvrd.py
Outdated
Comment on lines
33
to
35
| from xcvrd.xcvrd import * | ||
| from xcvrd.xcvrd_utilities.sfp_status_helper import * | ||
| from xcvrd.xcvrd_utilities.port_mapping import * |
There was a problem hiding this comment.
these imports are already there at line 1 to 3
There was a problem hiding this comment.
fixed, can you please approve again
Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
|
This pull request fixes 1 alert when merging 73a82bc into c4127c2 - view on LGTM.com fixed alerts:
|
|
This pull request fixes 1 alert when merging 067c589 into c4127c2 - view on LGTM.com fixed alerts:
|
prgeor
approved these changes
Jan 20, 2022
|
This commit could not be cleanly cherry-picked to 202012. Please submit another PR. |
vdahiya12
pushed a commit
to vdahiya12/sonic-platform-daemons
that referenced
this pull request
Jan 28, 2022
…vrd (sonic-net#219) * [xcvrd] suuport for integrating y cable within xcvrd This PR separates the logic of Y-Cable from xcvrd. Before this change we were utilizing xcvrd daemon to control all aspects of Y-Cable right from initialization to processing requests from other entities like orch,linkmgr. Now we would have another daemon ycabled which will serve this purpose. Logically everything still remains the same from the perspective of other daemons. it also take care aspects like init/delete daemon from Y-Cable perspective. dependent-startup EXITED Jan 18 05:40 AM xcvrd RUNNING pid 33, uptime 20:02:58 ycabled RUNNING pid 218, uptime 0:22:12 Motivation and Context Required for separating the logic of Y-Cable from xcvrd. This is to ensure that the daemon always works and responds to linkmgr to address its requests How Has This Been Tested? Built an image with the changes and ran dualtor specific tests on the change on a 7050cx3 testbed. Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
vdahiya12
added a commit
that referenced
this pull request
Jan 31, 2022
…vrd (#237) * [y_cable] refactor y_cable to a seperate logic and new daemon from xcvrd (#219) * [xcvrd] suuport for integrating y cable within xcvrd This PR separates the logic of Y-Cable from xcvrd. Before this change we were utilizing xcvrd daemon to control all aspects of Y-Cable right from initialization to processing requests from other entities like orch,linkmgr. Now we would have another daemon ycabled which will serve this purpose. Logically everything still remains the same from the perspective of other daemons. it also take care aspects like init/delete daemon from Y-Cable perspective. dependent-startup EXITED Jan 18 05:40 AM xcvrd RUNNING pid 33, uptime 20:02:58 ycabled RUNNING pid 218, uptime 0:22:12 Motivation and Context Required for separating the logic of Y-Cable from xcvrd. This is to ensure that the daemon always works and responds to linkmgr to address its requests How Has This Been Tested? Built an image with the changes and ran dualtor specific tests on the change on a 7050cx3 testbed. Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
vdahiya12
added a commit
to sonic-net/sonic-utilities
that referenced
this pull request
Mar 21, 2022
Creating this PR because there was a conflict in #1961 and cherry-pick did not work Signed-off-by: vaibhav-dahiya vdahiya@microsoft.com What I did This PR supports for muxcable status command to support HWSTATUS as well. the HWSTATUS could be either of these values consistent/inconsistent/absent/Not-Y-Cable-Port/unknown How I did it Made the changes in both sonic-platform-daemons as well as sonic-utilities. This PR is dependent on sonic-net/sonic-platform-daemons#219 How to verify it Ran the changes on Arista7260cx3 platform as well as unit-tests Previous command output (if the output of a command-line utility has changed) PORT STATUS HEALTH HWSTATUS LAST_SWITCHOVER_TIME ----------- -------- --------- ---------- --------------------------- Ethernet0 active unhealthy consistent 2022-Mar-14 19:40:06.851394 Ethernet4 active unhealthy consistent 2022-Mar-14 19:40:06.863977 Ethernet8 active unhealthy consistent 2022-Mar-14 19:40:06.867504 Ethernet12 active unhealthy consistent 2022-Mar-14 19:40:07.149011 Ethernet16 active unhealthy consistent 2022-Mar-14 19:40:07.179085 Ethernet20 active unhealthy consistent 2022-Mar-14 19:40:07.174677 Ethernet40 active healthy consistent 2022-Mar-14 19:40:07.264452 Ethernet44 active healthy consistent 2022-Mar-14 19:40:07.452626 Ethernet48 active unhealthy consistent 2022-Mar-14 19:40:07.511005 Ethernet52 active unhealthy consistent 2022-Mar-14 19:40:07.644608 Ethernet56 active unhealthy consistent 2022-Mar-14 19:40:07.630628 Ethernet60 active unhealthy consistent 2022-Mar-14 19:40:07.739968 Ethernet64 active unhealthy consistent 2022-Mar-14 19:40:07.784666 Ethernet68 active healthy consistent 2022-Mar-14 19:40:07.728138 Ethernet72 active healthy consistent 2022-Mar-14 19:40:07.901363 Ethernet76 active healthy consistent 2022-Mar-14 19:40:07.957279 Ethernet80 active healthy consistent 2022-Mar-14 19:40:08.011392 Ethernet84 active healthy consistent 2022-Mar-14 19:40:08.149346 Ethernet104 active healthy consistent 2022-Mar-14 19:40:09.312243 Ethernet108 active healthy consistent 2022-Mar-14 19:40:09.312293 Ethernet112 active healthy consistent 2022-Mar-14 19:40:09.313652 Ethernet116 active healthy consistent 2022-Mar-14 19:40:09.313820 Ethernet120 active healthy consistent 2022-Mar-14 19:40:09.318580 Ethernet124 standby unhealthy consistent 2022-Mar-14 19:43:57.893061 Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
vdahiya12
pushed a commit
to vdahiya12/sonic-platform-daemons
that referenced
this pull request
Apr 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: vaibhav-dahiya vdahiya@microsoft.com
Description
This PR separates the logic of Y-Cable from xcvrd. Before this change we were utilizing xcvrd daemon to control all aspects of Y-Cable right from initialization to processing requests from other entities like orch,linkmgr.
Now we would have another daemon ycabled which will serve this purpose.
Logically everything still remains the same from the perspective of other daemons.
it also take care aspects like init/delete daemon from Y-Cable perspective.
Motivation and Context
Required for separating the logic of Y-Cable from xcvrd. This is to ensure that the daemon always works and responds to linkmgr to address its requests
How Has This Been Tested?
Built an image with the changes and ran dualtor specific tests on the change on a 7050cx3 testbed.
Additional Information (Optional)
Additionally this PR also fixes vs platform ycable initialization.
is_vs variable represents kvm based testbed support for ycabled daemon