Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[show] add support for hwstatus in show muxcable status (#1961) #2105

Merged
merged 1 commit into from
Mar 21, 2022

Conversation

vdahiya12
Copy link
Contributor

@vdahiya12 vdahiya12 commented Mar 16, 2022

Creating this PR because there was a conflict in #1961 and cherry-pick did not work

Signed-off-by: vaibhav-dahiya vdahiya@microsoft.com

What I did

This PR supports for muxcable status command to support HWSTATUS as well.
the HWSTATUS could be either of these values
consistent/inconsistent/absent/Not-Y-Cable-Port/unknown

How I did it

Made the changes in both sonic-platform-daemons as well as sonic-utilities.
This PR is dependent on sonic-net/sonic-platform-daemons#219

How to verify it

Ran the changes on Arista7260cx3 platform as well as unit-tests

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

admin@sonic:~$ show mux status
PORT         STATUS    HEALTH     HWSTATUS    LAST_SWITCHOVER_TIME
-----------  --------  ---------  ----------  ---------------------------
Ethernet0    active    unhealthy  consistent  2022-Mar-14 19:40:06.851394
Ethernet4    active    unhealthy  consistent  2022-Mar-14 19:40:06.863977
Ethernet8    active    unhealthy  consistent  2022-Mar-14 19:40:06.867504
Ethernet12   active    unhealthy  consistent  2022-Mar-14 19:40:07.149011
Ethernet16   active    unhealthy  consistent  2022-Mar-14 19:40:07.179085
Ethernet20   active    unhealthy  consistent  2022-Mar-14 19:40:07.174677
Ethernet40   active    healthy    consistent  2022-Mar-14 19:40:07.264452
Ethernet44   active    healthy    consistent  2022-Mar-14 19:40:07.452626
Ethernet48   active    unhealthy  consistent  2022-Mar-14 19:40:07.511005
Ethernet52   active    unhealthy  consistent  2022-Mar-14 19:40:07.644608
Ethernet56   active    unhealthy  consistent  2022-Mar-14 19:40:07.630628
Ethernet60   active    unhealthy  consistent  2022-Mar-14 19:40:07.739968
Ethernet64   active    unhealthy  consistent  2022-Mar-14 19:40:07.784666
Ethernet68   active    healthy    consistent  2022-Mar-14 19:40:07.728138
Ethernet72   active    healthy    consistent  2022-Mar-14 19:40:07.901363
Ethernet76   active    healthy    consistent  2022-Mar-14 19:40:07.957279
Ethernet80   active    healthy    consistent  2022-Mar-14 19:40:08.011392
Ethernet84   active    healthy    consistent  2022-Mar-14 19:40:08.149346
Ethernet104  active    healthy    consistent  2022-Mar-14 19:40:09.312243
Ethernet108  active    healthy    consistent  2022-Mar-14 19:40:09.312293
Ethernet112  active    healthy    consistent  2022-Mar-14 19:40:09.313652
Ethernet116  active    healthy    consistent  2022-Mar-14 19:40:09.313820
Ethernet120  active    healthy    consistent  2022-Mar-14 19:40:09.318580
Ethernet124  standby   unhealthy  consistent  2022-Mar-14 19:43:57.893061

PORT         STATUS    HEALTH     HWSTATUS    LAST_SWITCHOVER_TIME
-----------  --------  ---------  ----------  ---------------------------
Ethernet0    active    unhealthy  consistent  2022-Mar-14 19:40:06.851394
Ethernet4    active    unhealthy  consistent  2022-Mar-14 19:40:06.863977
Ethernet8    active    unhealthy  consistent  2022-Mar-14 19:40:06.867504
Ethernet12   active    unhealthy  consistent  2022-Mar-14 19:40:07.149011
Ethernet16   active    unhealthy  consistent  2022-Mar-14 19:40:07.179085
Ethernet20   active    unhealthy  consistent  2022-Mar-14 19:40:07.174677
Ethernet40   active    healthy    consistent  2022-Mar-14 19:40:07.264452
Ethernet44   active    healthy    consistent  2022-Mar-14 19:40:07.452626
Ethernet48   active    unhealthy  consistent  2022-Mar-14 19:40:07.511005
Ethernet52   active    unhealthy  consistent  2022-Mar-14 19:40:07.644608
Ethernet56   active    unhealthy  consistent  2022-Mar-14 19:40:07.630628
Ethernet60   active    unhealthy  consistent  2022-Mar-14 19:40:07.739968
Ethernet64   active    unhealthy  consistent  2022-Mar-14 19:40:07.784666
Ethernet68   active    healthy    consistent  2022-Mar-14 19:40:07.728138
Ethernet72   active    healthy    consistent  2022-Mar-14 19:40:07.901363
Ethernet76   active    healthy    consistent  2022-Mar-14 19:40:07.957279
Ethernet80   active    healthy    consistent  2022-Mar-14 19:40:08.011392
Ethernet84   active    healthy    consistent  2022-Mar-14 19:40:08.149346
Ethernet104  active    healthy    consistent  2022-Mar-14 19:40:09.312243
Ethernet108  active    healthy    consistent  2022-Mar-14 19:40:09.312293
Ethernet112  active    healthy    consistent  2022-Mar-14 19:40:09.313652
Ethernet116  active    healthy    consistent  2022-Mar-14 19:40:09.313820
Ethernet120  active    healthy    consistent  2022-Mar-14 19:40:09.318580
Ethernet124  standby   unhealthy  consistent  2022-Mar-14 19:43:57.893061

Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@vdahiya12
Copy link
Contributor Author

vdahiya12 commented Mar 17, 2022

/azp run Azure.sonic-utilities

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@vdahiya12 vdahiya12 requested a review from zjswhhh March 18, 2022 01:21
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@vdahiya12 vdahiya12 merged commit 582d740 into sonic-net:202012 Mar 21, 2022
stepanblyschak pushed a commit to stepanblyschak/sonic-utilities that referenced this pull request Apr 18, 2022
This PR updates the following commits in sonic-utilities

582d740 (HEAD -> 202012, origin/202012) [show] add support for hwstatus in show muxcable status (sonic-net#1961) (sonic-net#2105)


Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants