[202012] Use Vlan MAC as src MAC for link prober by default #93 #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
What is the motivation for this PR? In active-standby, scenario ICMP request is replied by server host and duplicated by smart cable. In active-active scenario, ICMP is replied by FPGA, and it will simply reverse src MAC and dest MAC. If we continue to use device MAC address as src MAC in active-active scenarios, heartbeats won't be duplicated to both sides. How did you do it? Get Vlan MAC address when initializing, and use it for link prober by default. Add handlers to support switching between using Vlan MAC and ToR MAC. To use ToR MAC, set src_mac field in MUX_LINKMGR|LINK_PROBER table in CONFIG DB to value ToRMac. How did you verify/test it? Tested on dualToR testbeds, captured the ICMP requests and replies: Able to see src MAC as Vlan MAC by default Able to see src MAC switch to Device MAC after updating CONFIG DB entry Able to see replies flood back to both sides. sign-off: Jing Zhang zhangjing@microsfot.com
yxieca
approved these changes
Jun 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
TASK 18434754
Summary:
Fixes # (issue)
Cherry picking #93 into 202012 branch.
sign-off: Jing Zhang zhangjing@microsoft.com
Type of change
Approach
What is the motivation for this PR?
How did you do it?
How did you verify/test it?
Any platform specific information?
Documentation