Use Vlan MAC as src MAC for link prober by default #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will add unit tests for better code coverage later, submitting for review now. |
yxieca
reviewed
Jun 28, 2022
yxieca
reviewed
Jun 28, 2022
yxieca
reviewed
Jun 28, 2022
yxieca
reviewed
Jun 28, 2022
yxieca
reviewed
Jun 28, 2022
zjswhhh
force-pushed
the
use_vlan_mac_master
branch
from
9831bd8
to
1c4a4ce
Compare
yxieca
approved these changes
Jun 28, 2022
yxieca
pushed a commit
that referenced
this pull request
Jun 28, 2022
What is the motivation for this PR? In active-standby, scenario ICMP request is replied by server host and duplicated by smart cable. In active-active scenario, ICMP is replied by FPGA, and it will simply reverse src MAC and dest MAC. If we continue to use device MAC address as src MAC in active-active scenarios, heartbeats won't be duplicated to both sides. How did you do it? Get Vlan MAC address when initializing, and use it for link prober by default. Add handlers to support switching between using Vlan MAC and ToR MAC. To use ToR MAC, set src_mac field in MUX_LINKMGR|LINK_PROBER table in CONFIG DB to value ToRMac. How did you verify/test it? Tested on dualToR testbeds, captured the ICMP requests and replies: Able to see src MAC as Vlan MAC by default Able to see src MAC switch to Device MAC after updating CONFIG DB entry Able to see replies flood back to both sides. sign-off: Jing Zhang zhangjing@microsfot.com
7 tasks
zjswhhh
added a commit
to sonic-net/sonic-buildimage
that referenced
this pull request
Jul 12, 2022
[master][sonic-linkmgrd] submodule update 58d8aae Longxiang Lyu Sat Jul 2 10:14:50 2022 +0800 Enforce switch after config mux to active (sonic-net/sonic-linkmgrd#95) 600df46 Longxiang Lyu Thu Jun 30 15:09:10 2022 +0800 Add unittest to verify mux toggle active (sonic-net/sonic-linkmgrd#94) 400b1b8 gregshpit Wed Jun 29 21:32:45 2022 +0300 For Sonic cross-compilation build. CC variable is used as gcc compiler. CXX variable is used as g++ compiler. (sonic-net/sonic-linkmgrd#91) a516668 Jing Zhang Tue Jun 28 11:07:23 2022 -0700 Use Vlan MAC as src MAC for link prober by default (sonic-net/sonic-linkmgrd#93) 6b5d739 Longxiang Lyu Tue Jun 28 22:46:12 2022 +0800 Fix inconsistent mux state (sonic-net/sonic-linkmgrd#92) 9265497 Jing Zhang Fri Jun 24 09:10:12 2022 -0700 Remove exception throwing when initializing missing loopback interface (sonic-net/sonic-linkmgrd#90) sign-off: Jing Zhang zhangjing@microsoft.com
zjswhhh
added a commit
to zjswhhh/sonic-linkmgrd
that referenced
this pull request
May 22, 2023
What is the motivation for this PR? In active-standby, scenario ICMP request is replied by server host and duplicated by smart cable. In active-active scenario, ICMP is replied by FPGA, and it will simply reverse src MAC and dest MAC. If we continue to use device MAC address as src MAC in active-active scenarios, heartbeats won't be duplicated to both sides. How did you do it? Get Vlan MAC address when initializing, and use it for link prober by default. Add handlers to support switching between using Vlan MAC and ToR MAC. To use ToR MAC, set src_mac field in MUX_LINKMGR|LINK_PROBER table in CONFIG DB to value ToRMac. How did you verify/test it? Tested on dualToR testbeds, captured the ICMP requests and replies: Able to see src MAC as Vlan MAC by default Able to see src MAC switch to Device MAC after updating CONFIG DB entry Able to see replies flood back to both sides. sign-off: Jing Zhang zhangjing@microsfot.com
4 tasks
|
ADO for this PR is missing in description, please update PR description. |
liuh-80
added
the
Created PR to 202012 Branch
|
This commit could not be cleanly cherry-picked to 202012. Please submit another PR. |
zjswhhh
added a commit
that referenced
this pull request
Jun 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TASK 18434754
Description of PR
Summary:
Fixes # (issue)
This PR is to use VLAN MAC address as link prober heartbeat's src MAC address. Also user should be able to switch back and use ToR MAC by updating config DB entry.
sign-off: Jing Zhang zhangjing@microsfot.com
Type of change
Approach
What is the motivation for this PR?
In active-standby, scenario ICMP request is replied by server host and duplicated by smart cable. In active-active scenario, ICMP is replied by FPGA, and it will simply reverse src MAC and dest MAC. If we continue to use device MAC address as src MAC in active-active scenarios, heartbeats won't be duplicated to both sides.
How did you do it?
To use ToR MAC, set
src_macfield inMUX_LINKMGR|LINK_PROBERtable in CONFIG DB to valueToRMac.How did you verify/test it?
Tested on dualToR testbeds, captured the ICMP requests and replies:
Any platform specific information?
Documentation