Fix os crash caused by optoe when class switch #413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you please add the description to the commit message ( |
philo-micas
added a commit
to philo-micas/sonic-linux-kernel
that referenced
this pull request
Jul 3, 2024
When the device is initially set to optoe2, there is an option->client[1]. If echo 3>dev_class is manually set at this time, as for optoe3, option->client[1] is meaningless but the content is still the address data of optoe2, accessing an illegal address will occur, causing the device to crash. Set option ->client[1] to NULL when unregistering device Signed-off-by: philo <philo@micasnetworks.com>
philo-micas
force-pushed
the
master-for-optoe
branch
2 times, most recently
from
9031ab7
to
ff0c049
Compare
@paulmenzel @lguohan @prgeor Ok,thanks, has updated. Help arrange review for this PR, thanks! |
|
As mentioned in issue:sonic-net/sonic-buildimage#19525 |
This was
linked to
issues
Jul 12, 2024
saiarcot895
reviewed
Jul 12, 2024
philo-micas
force-pushed
the
master-for-optoe
branch
from
ff0c049
to
57f092b
Compare
When the device is initially set to optoe2, there is an option->client[1]. If echo 3>dev_class is manually set at this time, as for optoe3, option->client[1] is meaningless but the content is still the address data of optoe2, accessing an illegal address will occur, causing the device to crash. Therefore, set option->client[1] to NULL when unregistering device Signed-off-by: philo <philo@micasnetworks.com>
philo-micas
force-pushed
the
master-for-optoe
branch
from
57f092b
to
5f77d1a
Compare
saiarcot895
approved these changes
Jul 15, 2024
11 tasks
philo-micas
added a commit
to philo-micas/sonic-linux-kernel
that referenced
this pull request
Jul 17, 2024
Why: When the device is initially set to optoe2, there is an option ->client [1]. If echo 3>dev_class is manually set at this time, as for optoe3, option ->client [1] is meaningless but the content is still the address data of optoe2, accessing an illegal address will occur, causing the device to crash. How: Set option->client[1] to NULL when unregistering device Closes: sonic-net#412 Signed-off-by: philo <philo@micasnetworks.com> Co-authored-by: Saikrishna Arcot <sarcot@microsoft.com>
philo-micas
added a commit
to philo-micas/sonic-linux-kernel
that referenced
this pull request
Jul 18, 2024
Why: When the device is initially set to optoe2, there is an option ->client [1]. If echo 3>dev_class is manually set at this time, as for optoe3, option ->client [1] is meaningless but the content is still the address data of optoe2, accessing an illegal address will occur, causing the device to crash. How: Set option->client[1] to NULL when unregistering device Closes: sonic-net#412 Signed-off-by: philo <philo@micasnetworks.com> Co-authored-by: Saikrishna Arcot <sarcot@microsoft.com>
qiluo-msft
pushed a commit
to sonic-net/sonic-buildimage
that referenced
this pull request
Sep 21, 2024
### Why I did it ### How I did it We try to use Linux kernel drivers to replace our drivers, except for some drivers that we have implemented ourselves. For this purpose, we have submitted the following PR to the sonic-linux-kernel repository: sonic-net/sonic-linux-kernel#411 sonic-net/sonic-linux-kernel#413 sonic-net/sonic-linux-kernel#417
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why：
When the device is initially set to optoe2, there is an option ->client [1]. If echo 3>dev_class is manually set at this time, as for optoe3, option ->client [1] is meaningless but the content is still the address data of optoe2, accessing an illegal address will occur, causing the device to crash.
How:
Set option->client[1] to NULL when unregistering device
Closes：#412