Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[action] [PR:10491] Use xunit1 as default junit family version #10492

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

mssonicbld
Copy link
Collaborator

Description of PR

Summary:
Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 201911
  • 202012
  • 202205
  • 202305

Approach

What is the motivation for this PR?

When we use python3 env to run tests, it would use latest pytest by default, with junit_family=xunit2, which would not generate "file" and "line" field in test result xml file

How did you do it?

Use junit_family=xunit1 by default in pytest.ini file

How did you verify/test it?

Run test in python2 and python3 env, difference is only "file" and "line" fields in xml file

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

What is the motivation for this PR?
When we use python3 env to run tests, it would use latest pytest by default, with junit_family=xunit2, which would not generate "file" and "line" field in test result xml file

How did you do it?
Use junit_family=xunit1 by default in pytest.ini file

How did you verify/test it?
Run test in python2 and python3 env, difference is only "file" and "line" fields in xml file
@mssonicbld
Copy link
Collaborator Author

Original PR: #10491

@mssonicbld mssonicbld merged commit fd42376 into sonic-net:202012 Oct 26, 2023
7 checks passed
@mssonicbld mssonicbld deleted the cherry/202012/10491 branch February 4, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants