[action] [PR:10944] Update the pfcwd warm reboot test for "create_only_config_db_buffers" #11074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sonic-net#10944) Summary: The test_pfcwd_warm_reboot.py no_storm and async_storm test cases sometimes fails on MSFT SKU setups due to the change in PR: [buffers] Add handler for the 'create_only_config_db_buffers' configuration knob sonic-swss#2883 [buffers] Add 'create_only_config_db_buffers.json' file for the Mellanox devices (not MSFT SKU) sonic-buildimage#16233. With this change, all buffer counters (which are read from SAI) will be created after warm reboot as soon as possible, regardless of the CONFIG_DB buffers configuration. It will take much longer time to complete the counter creation And the pfcwd is only available after all the counters are created, when the test sends pfc storm after warm-reboot, the counters could have not been completely created, so no storm is detected by the pfcwd. This causes the test to fail on the platforms with MSFT SKUs. We need to add some delay after warm-reboot if "create_only_config_db_buffers" is not enabled.
7 tasks
|
Original PR: #10944 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
The test_pfcwd_warm_reboot.py no_storm and async_storm test cases sometimes fails on MSFT SKU setups due to the change in PR:
[buffers] Add handler for the 'create_only_config_db_buffers' configuration knob sonic-swss#2883
[buffers] Add 'create_only_config_db_buffers.json' file for the Mellanox devices (not MSFT SKU) sonic-buildimage#16233.
With this change, all buffer counters (which are read from SAI) will be created after warm reboot as soon as possible, regardless of the CONFIG_DB buffers configuration. It will take much longer time to complete the counter creation
And the pfcwd is only available after all the counters are created, when the test sends pfc storm after warm-reboot, the counters could have not been completely created, so no storm is detected by the pfcwd. This causes the test to fail on the platforms with MSFT SKUs.
We need to add some delay after warm-reboot if "create_only_config_db_buffers" is not enabled.
Type of change
Back port request
Approach
What is the motivation for this PR?
Update the pfcwd warm reboot test for "create_only_config_db_buffers"
How did you do it?
How did you verify/test it?
Run the test in regression on all platforms.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation