[buffers] Add handler for the 'create_only_config_db_buffers' configuration knob #2883

vadymhlushko-mlnx · 2023-08-22T16:52:51Z

What I did
Add support in the orchagent for the configuration knob:

{
    "DEVICE_METADATA": {
        "localhost": {
            "create_only_config_db_buffers": "true"
            ...
        }
    }
}

Why I did it
If the "create_only_config_db_buffers" is equal to "true" - buffers will be created according to the config_db configuration (for example BUFFER_QUEUE|* table).
If the "create_only_config_db_buffers" is equal to "false" or does not exist - the maximum available buffers (which are read from SAI) will be created, regardless of the config_db buffer config.

How I verified it
Add UT.

Manual verification:

Install the image with this PR included on the not MSFT SKU switch
Check the show queue counters output and verify that only configured in CONFIG_DB buffers are created

root@sonic:/home/admin# show queue counters
     Port    TxQ    Counter/pkts    Counter/bytes    Drop/pkts    Drop/bytes
---------  -----  --------------  ---------------  -----------  ------------
Ethernet0    UC0               0                0            0           N/A
Ethernet0    UC1               0                0            0           N/A
Ethernet0    UC2               0                0            0           N/A
Ethernet0    UC3               0                0            0           N/A
Ethernet0    UC4               0                0            0           N/A
Ethernet0    UC5               0                0            0           N/A
Ethernet0    UC6               0                0            0           N/A

Open the /usr/share/sonic/device/$DEVICE/$SKU/create_only_config_db_buffers.json and change it to:

"create_only_config_db_buffers": "false"

Do config reload
Check the show queue counters output and verify that all available buffers are created

root@sonic:/home/admin# show queue counters
     Port    TxQ    Counter/pkts    Counter/bytes    Drop/pkts    Drop/bytes
---------  -----  --------------  ---------------  -----------  ------------
Ethernet0    UC0               0                0            0           N/A
Ethernet0    UC1               0                0            0           N/A
Ethernet0    UC2               0                0            0           N/A
Ethernet0    UC3               0                0            0           N/A
Ethernet0    UC4               0                0            0           N/A
Ethernet0    UC5               0                0            0           N/A
Ethernet0    UC6               0                0            0           N/A
Ethernet0    UC7              60            15346            0           N/A
Ethernet0    MC8             N/A              N/A          N/A           N/A
Ethernet0    MC9             N/A              N/A          N/A           N/A
Ethernet0   MC10             N/A              N/A          N/A           N/A
Ethernet0   MC11             N/A              N/A          N/A           N/A
Ethernet0   MC12             N/A              N/A          N/A           N/A
Ethernet0   MC13             N/A              N/A          N/A           N/A
Ethernet0   MC14             N/A              N/A          N/A           N/A
Ethernet0   MC15             N/A              N/A          N/A           N/A

Details if related

vadymhlushko-mlnx · 2023-08-22T16:59:25Z

Cherry-picks:

[202205][buffers] Add handler for the 'create_all_available_buffers' configuration knob
[202211][buffers] Add handler for the 'create_all_available_buffers' configuration knob

vadymhlushko-mlnx · 2023-08-31T12:51:22Z

/azpw run Azure.sonic-swss

mssonicbld · 2023-08-31T12:51:24Z

/AzurePipelines run Azure.sonic-swss

azure-pipelines · 2023-08-31T12:51:33Z

Azure Pipelines successfully started running 1 pipeline(s).

vadymhlushko-mlnx · 2023-08-31T14:55:24Z

/azpw run Azure.sonic-swss

mssonicbld · 2023-08-31T14:55:26Z

/AzurePipelines run Azure.sonic-swss

azure-pipelines · 2023-08-31T14:55:34Z

Azure Pipelines successfully started running 1 pipeline(s).

prsunny · 2023-09-06T02:16:15Z

@vadymhlushko-mlnx , can you check why the test is failing?

…on knob Signed-off-by: vadymhlushko-mlnx <vadymh@nvidia.com>

Signed-off-by: vadymhlushko-mlnx <vadymh@nvidia.com>

vadymhlushko-mlnx · 2023-09-26T08:33:22Z

@abdosi @prsunny could you please approve and merge?

prsunny

lgtm, minor comment. @abdosi , @prabhataravind , please review/sign-off.

@neethajohn for viz

prsunny · 2023-09-29T19:06:59Z

orchagent/flexcounterorch.cpp

+    }
+    catch(const std::system_error& e)
+    {
+        SWSS_LOG_ERROR("System error: %s", e.what());


can you change this to WARNING? for non existent config_db, we don't want an ERR log printed

The error statement in the catch block will be printed only if the deviceMetadataConfigTable.hget() throws an exception.
If the create_only_config_db_buffers do not exist in the config_db the deviceMetadataConfigTable.hget() returns false.

prabhataravind

lgtm

vadymhlushko-mlnx · 2023-10-10T13:39:19Z

@prsunny could we include this PR in the 202305 branch?
I've already checked - it is a clean cherry-pick

StormLiangMS · 2023-10-17T12:23:18Z

@vadymhlushko-mlnx have you tested 202305 image with this PR?

@prsunny could we have ADO to track if support cherry pick to 202305?

Blueve · 2023-10-18T11:41:41Z

@StormLiangMS Please use this ADO: 25518393

…ration knob (#2883) * [buffers] Add handler for "create_only_config_db_buffers" configuration knob If the "create_only_config_db_buffers" is equal to "true" - buffers will be created according to the config_db configuration (for example BUFFER_QUEUE|* table). If the "create_only_config_db_buffers" is equal to "false" or does not exist - the maximum available buffers (which are read from SAI) will be created, regardless of the config_db buffer config.

vadymhlushko-mlnx mentioned this pull request Aug 22, 2023

[buffers] Add 'create_only_config_db_buffers.json' file for the Mellanox devices (not MSFT SKU) sonic-net/sonic-buildimage#16233

Merged

11 tasks

vadymhlushko-mlnx changed the title ~~[buffers] Add handler for the 'create_all_available_buffers' configuration knob~~ [buffers] Add handler for the 'create_only_config_db_buffers' configuration knob Aug 23, 2023

vadymhlushko-mlnx force-pushed the master-create-all-buffers branch 3 times, most recently from b0f6e07 to 34ca6e4 Compare August 29, 2023 13:04

vadymhlushko-mlnx force-pushed the master-create-all-buffers branch from 34ca6e4 to 41a9f1e Compare August 30, 2023 18:02

vadymhlushko-mlnx marked this pull request as ready for review August 30, 2023 18:04

vadymhlushko-mlnx requested a review from prsunny as a code owner August 30, 2023 18:04

vadymhlushko-mlnx force-pushed the master-create-all-buffers branch from 41a9f1e to 2c4fade Compare August 30, 2023 18:05

vadymhlushko-mlnx force-pushed the master-create-all-buffers branch from 2c4fade to 7aba9d1 Compare September 1, 2023 11:35

prsunny requested review from abdosi and prabhataravind September 6, 2023 02:15

vadymhlushko-mlnx force-pushed the master-create-all-buffers branch 4 times, most recently from e98dcbd to aa23409 Compare September 12, 2023 08:40

vadymhlushko-mlnx added 3 commits September 25, 2023 16:22

[buffers] Add handler for "create_only_config_db_buffers" configurati…

ffdd3ba

…on knob Signed-off-by: vadymhlushko-mlnx <vadymh@nvidia.com>

[buffers] Add UT

1e889f8

Signed-off-by: vadymhlushko-mlnx <vadymh@nvidia.com>

[buffers] Add fix for VOQ systems

976649e

Signed-off-by: vadymhlushko-mlnx <vadymh@nvidia.com>

vadymhlushko-mlnx force-pushed the master-create-all-buffers branch from be42e2f to 976649e Compare September 25, 2023 13:22

Merge branch 'master' into master-create-all-buffers

af23f7c

prsunny reviewed Sep 29, 2023

View reviewed changes

Merge branch 'master' into master-create-all-buffers

cab2919

prabhataravind approved these changes Oct 2, 2023

View reviewed changes

prsunny approved these changes Oct 3, 2023

View reviewed changes

Merge branch 'master' into master-create-all-buffers

5f1fe05

prsunny merged commit 91e7a27 into sonic-net:master Oct 4, 2023
16 checks passed

vadymhlushko-mlnx added the Request for 202305 Branch label Oct 10, 2023

rajkumar38 mentioned this pull request Oct 17, 2023

Orchagent crashed with SEGV when Flexcounter enabled for queue watermark, pg-drop #2935

Open

Blueve added Request for 202012 Branch and removed Request for 202012 Branch labels Oct 18, 2023

StormLiangMS added the Included in 202305 Branch label Nov 2, 2023

congh-nvidia mentioned this pull request Dec 5, 2023

Update the pfcwd warm reboot test for "create_only_config_db_buffers" sonic-net/sonic-mgmt#10944

Merged

7 tasks

This was referenced Dec 18, 2023

[action] [PR:10944] Update the pfcwd warm reboot test for "create_only_config_db_buffers" sonic-net/sonic-mgmt#11073

Merged

[action] [PR:10944] Update the pfcwd warm reboot test for "create_only_config_db_buffers" sonic-net/sonic-mgmt#11074

Merged

prabhataravind mentioned this pull request Nov 7, 2024

Create counter for the queue to which the host CPU traffic is sent when create_only_config_db_buffers is enabled #3334

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[buffers] Add handler for the 'create_only_config_db_buffers' configuration knob #2883

[buffers] Add handler for the 'create_only_config_db_buffers' configuration knob #2883

vadymhlushko-mlnx commented Aug 22, 2023 •

edited

Loading

vadymhlushko-mlnx commented Aug 22, 2023

vadymhlushko-mlnx commented Aug 31, 2023

mssonicbld commented Aug 31, 2023

azure-pipelines bot commented Aug 31, 2023

vadymhlushko-mlnx commented Aug 31, 2023

mssonicbld commented Aug 31, 2023

azure-pipelines bot commented Aug 31, 2023

prsunny commented Sep 6, 2023

vadymhlushko-mlnx commented Sep 26, 2023

prsunny left a comment

prsunny Sep 29, 2023

vadymhlushko-mlnx Oct 2, 2023

prabhataravind left a comment

vadymhlushko-mlnx commented Oct 10, 2023

StormLiangMS commented Oct 17, 2023

Blueve commented Oct 18, 2023

[buffers] Add handler for the 'create_only_config_db_buffers' configuration knob #2883

[buffers] Add handler for the 'create_only_config_db_buffers' configuration knob #2883

Conversation

vadymhlushko-mlnx commented Aug 22, 2023 • edited Loading

vadymhlushko-mlnx commented Aug 22, 2023

vadymhlushko-mlnx commented Aug 31, 2023

mssonicbld commented Aug 31, 2023

azure-pipelines bot commented Aug 31, 2023

vadymhlushko-mlnx commented Aug 31, 2023

mssonicbld commented Aug 31, 2023

azure-pipelines bot commented Aug 31, 2023

prsunny commented Sep 6, 2023

vadymhlushko-mlnx commented Sep 26, 2023

prsunny left a comment

Choose a reason for hiding this comment

prsunny Sep 29, 2023

Choose a reason for hiding this comment

vadymhlushko-mlnx Oct 2, 2023

Choose a reason for hiding this comment

prabhataravind left a comment

Choose a reason for hiding this comment

vadymhlushko-mlnx commented Oct 10, 2023

StormLiangMS commented Oct 17, 2023

Blueve commented Oct 18, 2023

vadymhlushko-mlnx commented Aug 22, 2023 •

edited

Loading