[test plan] Add test plan for subnet decap #12990
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lolyu
reviewed
May 25, 2024
| #### IPV4 positive scenario | ||
| 1. Craft `IPinIP` packet with signature as below. | ||
|
|
||
| - Outer DIP: Any IP in `192.168.0.1/21` |
| #### Test steps | ||
| #### IPV4 scenario | ||
| 1. Verify `STATE_DB` entries are created as expected. | ||
| 2. Craft packet with below signature |
There was a problem hiding this comment.
better to validate by sending IPinIP packets with source IP not in the range 20.20.20.0/24
There was a problem hiding this comment.
Why? For VIP decap we are also checking the src_ip.
| ### Test case 3 - Verify IPinIP packet targeting at vnet route is decapsulated (T1 only) | ||
| #### Test steps | ||
| #### IPV4 scenario | ||
| 1. Configure IPv4 vnet routes with RESTAPI on DUT. |
There was a problem hiding this comment.
Better to be more specific on the steps:
- add vxlan tunnel
- add vnet
- add vxlan tunnel route
| #### Test steps | ||
| #### IPV4 scenario | ||
| 1. Configure IPv4 vnet routes with RESTAPI on DUT. | ||
| 2. Verify `STATE_DB` entries are created as expected. |
There was a problem hiding this comment.
STATE_DB decap term entries for the vxlan tunnel route prefix are created
There was a problem hiding this comment.
there is no testcase to cover the decap term creation/removal due to the endpoint BFD session state changes.
There was a problem hiding this comment.
I think the bfd part is out of the scope of this test plan. We are monitoring the VNET_ROUTE table, but we didn't monitor BFD session.
There was a problem hiding this comment.
Discussed offline, the code is monitoring the state of route state. The change of status of BFD session will trigger the route state change. https://github.com/sonic-net/sonic-swss/blob/98012ed411d4e83ac01dabbb6d03e4f122ad1545/orchagent/vnetorch.cpp#L2127
The code in swss need to be revised probably.
lolyu
reviewed
Jun 4, 2024
| 4. Verify packet is forwarded to expected VLAN port. | ||
|
|
||
| ### Test case 2 - Verify IPinIP packet targeting at VIP is decapsulated (T0 only) | ||
| #### Test setup |
There was a problem hiding this comment.
We need a separate case for dualtor as both ToRs should have decap rules generated based on the VIP.
This was referenced Jun 4, 2024
Open
8 tasks
wangxin
pushed a commit
that referenced
this pull request
Sep 26, 2024
What is the motivation for this PR? In Azure network, Netscan uses IP-decap to check for route blackholes, but servers do not support decapsulation, making it impossible to perform server-to-server checks. To address this, we developed the subnet decap feature to detect if the link between the server and T0 is functioning properly. Additionally, new test cases are required to ensure the functionality of subnet decap is working as expected. How did you do it? Add new test to verify IPinIP packet targeting at VLAN subnet is decapsulated (T0 only) Ref test gap issue: #13120 Ref test plan: #12990 How did you verify/test it? Test on broadcom td3 asic and KVM
arista-hpandya
pushed a commit
to arista-hpandya/sonic-mgmt
that referenced
this pull request
Oct 2, 2024
What is the motivation for this PR? In Azure network, Netscan uses IP-decap to check for route blackholes, but servers do not support decapsulation, making it impossible to perform server-to-server checks. To address this, we developed the subnet decap feature to detect if the link between the server and T0 is functioning properly. Additionally, new test cases are required to ensure the functionality of subnet decap is working as expected. How did you do it? Add new test to verify IPinIP packet targeting at VLAN subnet is decapsulated (T0 only) Ref test gap issue: sonic-net#13120 Ref test plan: sonic-net#12990 How did you verify/test it? Test on broadcom td3 asic and KVM
hdwhdw
pushed a commit
to hdwhdw/sonic-mgmt
that referenced
this pull request
Oct 10, 2024
What is the motivation for this PR? In Azure network, Netscan uses IP-decap to check for route blackholes, but servers do not support decapsulation, making it impossible to perform server-to-server checks. To address this, we developed the subnet decap feature to detect if the link between the server and T0 is functioning properly. Additionally, new test cases are required to ensure the functionality of subnet decap is working as expected. How did you do it? Add new test to verify IPinIP packet targeting at VLAN subnet is decapsulated (T0 only) Ref test gap issue: sonic-net#13120 Ref test plan: sonic-net#12990 How did you verify/test it? Test on broadcom td3 asic and KVM
vikshaw-Nokia
pushed a commit
to vikshaw-Nokia/sonic-mgmt
that referenced
this pull request
Oct 23, 2024
What is the motivation for this PR? In Azure network, Netscan uses IP-decap to check for route blackholes, but servers do not support decapsulation, making it impossible to perform server-to-server checks. To address this, we developed the subnet decap feature to detect if the link between the server and T0 is functioning properly. Additionally, new test cases are required to ensure the functionality of subnet decap is working as expected. How did you do it? Add new test to verify IPinIP packet targeting at VLAN subnet is decapsulated (T0 only) Ref test gap issue: sonic-net#13120 Ref test plan: sonic-net#12990 How did you verify/test it? Test on broadcom td3 asic and KVM
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
This PR is to add a test plan for a new feature Subnet decap.
HLD sonic-net/SONiC#1657
Code
Type of change
Back port request
Approach
What is the motivation for this PR?
This PR is to add a test plan for a new feature Subnet decap.
How did you do it?
N/A
How did you verify/test it?
N/A
Any platform specific information?
N/A
Supported testbed topology if it's a new test case?
N/A
Documentation