Add new test for vlan subnet decap #14720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lolyu
reviewed
Sep 25, 2024
tests/decap/test_subnet_decap.py
Outdated
| "status" "enable" "src_ip" "{}" "src_ip_v6" "{}"' | ||
| .format(SUBNET_DECAP_SRC_IP_V4, SUBNET_DECAP_SRC_IP_V6)) | ||
| rand_selected_dut.shell('sudo config save -y') | ||
| rand_selected_dut.shell('sudo config reload -y') |
tests/decap/test_subnet_decap.py
Outdated
| yield | ||
| rand_selected_dut.shell('sonic-db-cli CONFIG_DB del "SUBNET_DECAP|subnet_type"') | ||
| rand_selected_dut.shell('sudo config save -y') | ||
| rand_selected_dut.shell('sudo config reload -y') |
There was a problem hiding this comment.
Same as above, use
sonic-mgmt/tests/common/config_reload.py
Line 115 in e4d40d2
tests/decap/test_subnet_decap.py
Outdated
| exp_pkt = build_expected_vlan_subnet_packet(encapsulated_packet, ip_version, stage, decrease_ttl=True) | ||
|
|
||
| ptf_target_port = random.choice(downstream_port_ids) | ||
| setup_arp_responder(ptfhost, ip_version, stage, ptf_target_port) |
There was a problem hiding this comment.
better to put the arp responder setup/teardown into a fixture.
tests/decap/test_subnet_decap.py
Outdated
|
|
||
| SUBNET_DECAP_SRC_IP_V4 = "20.20.20.0/24" | ||
| SUBNET_DECAP_SRC_IP_V6 = "fc01::/120" | ||
| OUTER_DST_IP_V4 = "192.168.0.10" |
There was a problem hiding this comment.
This IP is already occupied by the mux server on dualtor testbed, better to use a larger one, like 192.168.0.200
tests/decap/test_subnet_decap.py
Outdated
| logger = logging.getLogger(__name__) | ||
|
|
||
| pytestmark = [ | ||
| pytest.mark.topology('t0', 't1') |
There was a problem hiding this comment.
this testcase is supposed to run on t0 and dualtor
There was a problem hiding this comment.
Maybe we can add dualtor and do not remove t1, because once we add Verify IPinIP packet targeting at vnet route is decapsulated to this script, it should be run on t1, I have used conditional mark to skip vlan subnet decap test in t1
wangxin
approved these changes
Sep 26, 2024
arista-hpandya
pushed a commit
to arista-hpandya/sonic-mgmt
that referenced
this pull request
Oct 2, 2024
What is the motivation for this PR? In Azure network, Netscan uses IP-decap to check for route blackholes, but servers do not support decapsulation, making it impossible to perform server-to-server checks. To address this, we developed the subnet decap feature to detect if the link between the server and T0 is functioning properly. Additionally, new test cases are required to ensure the functionality of subnet decap is working as expected. How did you do it? Add new test to verify IPinIP packet targeting at VLAN subnet is decapsulated (T0 only) Ref test gap issue: sonic-net#13120 Ref test plan: sonic-net#12990 How did you verify/test it? Test on broadcom td3 asic and KVM
hdwhdw
pushed a commit
to hdwhdw/sonic-mgmt
that referenced
this pull request
Oct 10, 2024
What is the motivation for this PR? In Azure network, Netscan uses IP-decap to check for route blackholes, but servers do not support decapsulation, making it impossible to perform server-to-server checks. To address this, we developed the subnet decap feature to detect if the link between the server and T0 is functioning properly. Additionally, new test cases are required to ensure the functionality of subnet decap is working as expected. How did you do it? Add new test to verify IPinIP packet targeting at VLAN subnet is decapsulated (T0 only) Ref test gap issue: sonic-net#13120 Ref test plan: sonic-net#12990 How did you verify/test it? Test on broadcom td3 asic and KVM
vikshaw-Nokia
pushed a commit
to vikshaw-Nokia/sonic-mgmt
that referenced
this pull request
Oct 23, 2024
What is the motivation for this PR? In Azure network, Netscan uses IP-decap to check for route blackholes, but servers do not support decapsulation, making it impossible to perform server-to-server checks. To address this, we developed the subnet decap feature to detect if the link between the server and T0 is functioning properly. Additionally, new test cases are required to ensure the functionality of subnet decap is working as expected. How did you do it? Add new test to verify IPinIP packet targeting at VLAN subnet is decapsulated (T0 only) Ref test gap issue: sonic-net#13120 Ref test plan: sonic-net#12990 How did you verify/test it? Test on broadcom td3 asic and KVM
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
In Azure network, Netscan uses IP-decap to check for route blackholes, but servers do not support decapsulation, making it impossible to perform server-to-server checks. To address this, we developed the subnet decap feature to detect if the link between the server and T0 is functioning properly. Additionally, new test cases are required to ensure the functionality of subnet decap is working as expected.
How did you do it?
Add new test to verify IPinIP packet targeting at VLAN subnet is decapsulated (T0 only)
Ref test gap issue: #13120
Ref test plan: #12990
How did you verify/test it?
Test on broadcom td3 asic and KVM
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation