Skip the "show platform ssdhealth" test for non-SSD platform #4807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neethajohn
previously approved these changes
Dec 3, 2021
lguohan
reviewed
Dec 3, 2021
| @@ -313,6 +313,11 @@ def test_show_platform_ssdhealth(duthosts, enum_supervisor_dut_hostname): | |||
| @summary: Verify output of `show platform ssdhealth` | |||
| """ | |||
| duthost = duthosts[enum_supervisor_dut_hostname] | |||
| cmd = "cat /sys/block/sda/queue/rotational" | |||
There was a problem hiding this comment.
this is very hardware specific, some platform does not have sda, it is difficult to handle this in the test, can we modify the image to check if disk type is ssd or not?
There was a problem hiding this comment.
lsblk -l -n | grep 'disk'
will list all valid disks in the host
wangxin
reviewed
Dec 14, 2021
| @@ -317,6 +317,9 @@ def test_show_platform_ssdhealth(duthosts, enum_supervisor_dut_hostname): | |||
|
|
|||
| logging.info("Verifying output of '{}' on ''{}'...".format(cmd, duthost.hostname)) | |||
| ssdhealth_output_lines = duthost.command(cmd)["stdout_lines"] | |||
| if 'not SSD' in ssdcheck_output_lines: | |||
There was a problem hiding this comment.
Do you mean if not 'SSD' in ssdcheck_output_lines:?
|
@sujinmkang can you address comment |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Skip the "show platform ssdhealth" test for non-SSD platform
Summary:
Fixes # (issue)
sonic-net/sonic-buildimage#9407
Type of change
Back port request
Approach
What is the motivation for this PR?
With recent ssd platform api changes, ssdhealth check fails on some specific platform.
Since the platform doesn't have SSD.
How did you do it?
Skip the show platform ssdhealth for any platform with other type of disk.
How did you verify/test it?
Run pytest tests/platform_tests/cli/test_show_platform.py
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation