[GCU] Add config ipv6 BGP neighbor test #5061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qiluo-msft
reviewed
Feb 7, 2022
qiluo-msft
reviewed
Feb 7, 2022
wen587
reviewed
Feb 8, 2022
qiluo-msft
approved these changes
Feb 10, 2022
wen587
approved these changes
Feb 10, 2022
|
Is it ready to be merged? If not, please add dependency in PR description. |
Added dependency on grouping PR sonic-net/sonic-utilities#2044 to description |
congh-nvidia
added a commit
to congh-nvidia/sonic-mgmt
that referenced
this pull request
May 13, 2022
…r_admin_change This case fails every time on our community setup because it tries to replace the value of config entry " BGP_NEIGHBOR/fc00::12/admin_status", while this entry doesn't exist in the default running configuratuion.(The admin_status is up by default, but it doesn't show in the configuration.) To fix this, need to add this config before replace it. And add a topology mark for the test according to the description in sonic-net#5061 .
5 tasks
liat-grozovik
pushed a commit
that referenced
this pull request
May 19, 2022
…r_admin_change (#5647) This case fails every time on our testbeds because it tries to replace the admin_status value of a bgp neighour, while the admin_status field doesn't exist in the default running configuration generated from minigraph(the admin_status is up without a explicit "admin_status": "up" config in db). To fix this, need to add this config before replace it. And add a topology mark for the test according to the description in [GCU] Add config ipv6 BGP neighbor test #5061 . - What is the motivation for this PR? Ensure that the configuration exists in the running config before it is replaced by the patch . Add a topology mark for the test to ensure it runs with the correct topologies. According to the description in [GCU] Add config ipv6 BGP neighbor test #5061, this test support t0 and t1 testbeds. - How did you do it? Modified the patch to add this config before replace it. If the config already exists before the adding, it won't take any effects because the config is duplicated. Add the topology mark. - How did you verify/test it? Run this test case on testbeds with and without the admin_status field in running configs, all passed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Dependency on grouping PR: sonic-net/sonic-utilities#2044
Type of change
Back port request
Approach
What is the motivation for this PR?
End to End test support for Generic Updater apply-patch
Update ipv6 BGP neighbor configs
How did you do it?
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
t0, t1
Documentation