[bgp] Don't use portchannel members entry #7568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `members` entry in the `PORTCHANNEL` table has been removed. Switch to using `PORTCHANNEL_MEMBERS` instead. Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
yejianquan
reviewed
Feb 27, 2023
| @@ -104,7 +104,7 @@ def _verify_prefix_counters_from_neighbor_after_graceful_restart(duthost, bgp_ne | |||
|
|
|||
| config_facts = duthost.config_facts(host=duthost.hostname, source="running")['ansible_facts'] | |||
| bgp_neighbors = config_facts.get('BGP_NEIGHBOR', {}) | |||
| portchannels = config_facts.get('PORTCHANNEL', {}) | |||
There was a problem hiding this comment.
Likely some change in the image changed the naming convention?
Do you know if other test modules need such naming changes?
There was a problem hiding this comment.
It was caused by sonic-net/sonic-buildimage#13660
|
Hi @saiarcot895 , should we cherry-pick this change to other branches? |
|
Probably yes. The original PR will be going to the 202205 and 202211 branches, but I forgot to set the labels there, so they're not yet marked for cherry-pick. Regardless, this change can and should go into sonic-mgmt's 202205 branch before sonic-net/sonic-buildimage#13660 gets cherry-picked to 202205. |
yejianquan
pushed a commit
that referenced
this pull request
Feb 27, 2023
Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com> Description of PR Summary: Fixes sonic-net/sonic-buildimage#11873 sonic-net/sonic-buildimage#11873 Approach What is the motivation for this PR? The members entry in the PORTCHANNEL table has been removed. Switch to using PORTCHANNEL_MEMBERS instead. Related to sonic-net/sonic-buildimage#13660 sonic-net/sonic-buildimage#13660
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes sonic-net/sonic-buildimage#11873
Type of change
Back port request
Approach
What is the motivation for this PR?
The
membersentry in thePORTCHANNELtable has been removed. Switch to usingPORTCHANNEL_MEMBERSinstead.Related to sonic-net/sonic-buildimage#13660
How did you do it?
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation