[lag] Increase wait time for LAG to change state to 35 seconds #871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lguohan
approved these changes
Apr 17, 2019
lguohan
pushed a commit
that referenced
this pull request
Apr 25, 2019
yxieca
pushed a commit
that referenced
this pull request
May 8, 2019
ghost
reviewed
Jun 7, 2019
| @@ -31,9 +31,9 @@ | |||
| - name: test fanout interface (physical) flap and lacp keep correct po status follow minimum links requirement | |||
| include: lag_minlink.yml | |||
| vars: | |||
| wait_down_time: 20 | |||
| wait_down_time: 35 | |||
There was a problem hiding this comment.
Why is the wait time here much less than in L#48 ? Where do these numbers come from?
There was a problem hiding this comment.
I don't know who decided on these values or how they were chosen. I increased these a bit to make the test succeed more reliably on certain platforms. I believe they could still be increased more, but I believe someone needs to investigate this further and choose the most appropriate values.
stepanblyschak
pushed a commit
to stepanblyschak/sonic-mgmt
that referenced
this pull request
Jun 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some DuT/fanout combinations may require ~30 seconds for LAG to fully change state.