Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lag] Increase wait time for LAG to change state to 35 seconds #871

Merged
merged 1 commit into from
Apr 17, 2019
Merged

[lag] Increase wait time for LAG to change state to 35 seconds #871

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ansible/roles/test/tasks/lag_minlink.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@
connection: switch

- pause:
seconds: 20
seconds: 35

- lag_facts: host={{ inventory_hostname }}

Expand Down
4 changes: 2 additions & 2 deletions ansible/roles/test/tasks/single_lag_test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,9 @@
- name: test fanout interface (physical) flap and lacp keep correct po status follow minimum links requirement
include: lag_minlink.yml
vars:
wait_down_time: 20
wait_down_time: 35
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is the wait time here much less than in L#48 ? Where do these numbers come from?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know who decided on these values or how they were chosen. I increased these a bit to make the test succeed more reliably on certain platforms. I believe they could still be increased more, but I believe someone needs to investigate this further and choose the most appropriate values.


### Now figure out remote VM and interface info for the falpping lag member and run minlink test
### Now figure out remote VM and interface info for the flapping lag member and run minlink test
- set_fact:
peer_device: "{{vm_neighbors[flap_intf]['name']}}"
neighbor_interface: "{{vm_neighbors[flap_intf]['port']}}"
Expand Down