-
Notifications
You must be signed in to change notification settings - Fork 270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install sonic-buildimage libnl3 for AZP #877
Conversation
why you making this changes? please add description |
@kcudnik @smaheshm Description has been updated as requested. Please review as sonic-net/sonic-swss#1871 is merged to master and sonic-sairedis AZP will need this PR once sonic-swss submodule is updated in sonic-buildimage. |
@kcudnik @smaheshm I see that sonic-sairedis AZP is already failing due to merged changes from sonic-net/sonic-swss#1871. Please approve/merge this PR to resolve the AZP failure. |
libnl-3-dev \ | ||
libnl-genl-3-dev \ | ||
libnl-route-3-dev \ | ||
libnl-nf-3-dev \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why this is not working any more?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From PR Description: "fpmsyncd in sonic-swss now relies on modified version of libnl3 in sonic-buildimage with additional support for MPLS. Any AZP build of docker-sonic-vs must now install libnl3 from sonic-buildimage build artifact rather than Debian released version of libnl3."
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
@kcudnik @smaheshm It appears that sonic-sairedis BuildArm stage is exceeding the specified time limit of 180sec and the AZP run is automatically failing due to cancellation of the run. I have modified this PR to increase the BuildArm time limit from 180sec to 240sec. If you do not agree with this increase, let me know. |
works fine |
edeffe1
to
b153017
Compare
thanks @kcudnik . |
@kcudnik @liat-grozovik Is it really the intention to build sonic-sairedis from 202106 with sonic-swss from master? I would think this could lead to issues with incompatibility eventually. Perhaps build-swss-template.yml in 202106 should be updated to use sonic-swss and sonic-buildimage artifacts from the appropriate branch? |
What I did
AZP changes to install libnl3 from sonic-buildimage
Why I did it
Prevent sonic-sairedis AZP build failures in docker-sonic-vs.
fpmsyncd in sonic-swss now relies on modified version of libnl3 in sonic-buildimage with additional support for MPLS.
Any AZP build of docker-sonic-vs must now install libnl3 from sonic-buildimage build artifact rather than Debian released version of libnl3.
How I verified it
Unit-tests in sonic-swss/tests/test_mpls.py
System tests in sonic-mgmt
Details if related
Refer to PR: sonic-net/sonic-swss#1871