Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install sonic-buildimage libnl3 for AZP #518

Merged
merged 1 commit into from
Aug 27, 2021

Conversation

qbdwlr
Copy link
Contributor

@qbdwlr qbdwlr commented Aug 2, 2021

What I did
AZP changes to install libnl3 from sonic-buildimage

Why I did it
Prevent sonic-swss-common AZP build failures in docker-sonic-vs.
fpmsyncd in sonic-swss now relies on modified version of libnl3 in sonic-buildimage with additional support for MPLS.
Any AZP build of docker-sonic-vs must now install libnl3 from sonic-buildimage build artifact rather than Debian released version of libnl3.

How I verified it
Unit-tests in sonic-swss/tests/test_mpls.py
System tests in sonic-mgmt

Details if related
Refer to PR: sonic-net/sonic-swss#1871

@qbdwlr qbdwlr changed the title test azp changes Install sonic-buildimage libnl3 for AZP Aug 26, 2021
@qbdwlr qbdwlr marked this pull request as ready for review August 26, 2021 23:00
@qbdwlr
Copy link
Contributor Author

qbdwlr commented Aug 27, 2021

@prsunny @smaheshm Please review as sonic-net/sonic-swss#1871 is merged to master and sonic-swss-common AZP will need this PR once sonic-swss submodule is updated in sonic-buildimage.

@qbdwlr
Copy link
Contributor Author

qbdwlr commented Aug 27, 2021

@prsunny @smaheshm I see that sonic-swss-common AZP is already failing due to merged changes from sonic-net/sonic-swss#1871. Please approve/merge this PR to resolve the AZP failure.

Comment on lines +77 to +84
sudo dpkg -i target/debs/buster/libnl-3-200_*.deb
sudo dpkg -i target/debs/buster/libnl-3-dev_*.deb
sudo dpkg -i target/debs/buster/libnl-genl-3-200_*.deb
sudo dpkg -i target/debs/buster/libnl-genl-3-dev_*.deb
sudo dpkg -i target/debs/buster/libnl-route-3-200_*.deb
sudo dpkg -i target/debs/buster/libnl-route-3-dev_*.deb
sudo dpkg -i target/debs/buster/libnl-nf-3-200_*.deb
sudo dpkg -i target/debs/buster/libnl-nf-3-dev_*.deb
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sudo dpkg -i target/debs/buster/libnl-*.deb ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Current change avoids unneeded installation of libnl-cli-3-200 and libnl-cli-3-dev.

@smaheshm smaheshm merged commit 11006e6 into sonic-net:master Aug 27, 2021
@kcudnik
Copy link
Contributor

kcudnik commented Aug 28, 2021

I'm s tarring to erring errors with libnl on swss compile:

routesync.cpp: In member function 'void swss::RouteSync::getNextHopList(rtnl_route*, std::__cxx11::string&, std::__cxx11::string&, std::__cxx11::string&)':
routesync.cpp:1040:25: error: 'rtnl_route_nh_get_encap_mpls_dst' was not declared in this scope
             if ((addr = rtnl_route_nh_get_encap_mpls_dst(nexthop)))
                         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
routesync.cpp:1040:25: note: suggested alternative: 'rtnl_route_nh_encap_mpls'
             if ((addr = rtnl_route_nh_get_encap_mpls_dst(nexthop)))
                         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
                         rtnl_route_nh_encap_mpls
make[3]: *** [Makefile:472: fpmsyncd-routesync.o] Error 1

https://dev.azure.com/mssonic/build/_build/results?buildId=31804&view=logs&jobId=05061332-bfdb-5f6d-a09c-bb63eec6669c&j=05061332-bfdb-5f6d-a09c-bb63eec6669c&t=9e60e50c-b4b6-53d2-7fd2-99b13f45e3ec

is this related?

@smaheshm
Copy link

I'm s tarring to erring errors with libnl on swss compile:

routesync.cpp: In member function 'void swss::RouteSync::getNextHopList(rtnl_route*, std::__cxx11::string&, std::__cxx11::string&, std::__cxx11::string&)':
routesync.cpp:1040:25: error: 'rtnl_route_nh_get_encap_mpls_dst' was not declared in this scope
             if ((addr = rtnl_route_nh_get_encap_mpls_dst(nexthop)))
                         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
routesync.cpp:1040:25: note: suggested alternative: 'rtnl_route_nh_encap_mpls'
             if ((addr = rtnl_route_nh_get_encap_mpls_dst(nexthop)))
                         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
                         rtnl_route_nh_encap_mpls
make[3]: *** [Makefile:472: fpmsyncd-routesync.o] Error 1

https://dev.azure.com/mssonic/build/_build/results?buildId=31804&view=logs&jobId=05061332-bfdb-5f6d-a09c-bb63eec6669c&j=05061332-bfdb-5f6d-a09c-bb63eec6669c&t=9e60e50c-b4b6-53d2-7fd2-99b13f45e3ec

is this related?

yes it is. That's why this needs to be merge ASAP

sonic-net/sonic-sairedis#877

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants