Set swsscommon logging level #178
Conversation
src/sonic_ax_impl/__main__.py
Outdated
| @@ -75,6 +76,10 @@ def install_fragments(): | |||
| sonic_ax_impl.logger.setLevel(log_level) | |||
| ax_interface.logger.setLevel(log_level) | |||
| swsssdk.logger.setLevel(log_level_sdk) | |||
| # Note: swsscommon uses a fixed log level for simplicity | |||
| # TODO: improve it when log_level option is used | |||
| log_level_swsscommon = swsscommon.Logger.SWSS_ERROR | |||
There was a problem hiding this comment.
can this be modified as below:
if args.get('log_level') is not None and args.get('log_level') == logging.INFO:
log_level_swsscommon = swsscommon.Logger.SWSS_INFO
if args.get('log_level') is not None and args.get('log_level') == logging.ERROR:
log_level_swsscommon = swsscommon.Logger.SWSS_ERROR
else:
log_level_swsscommon = swsscommon.Logger.SWSS_ERROR #Resolved
There was a problem hiding this comment.
I think if args.get('log_level') is not None is not needed and we can directly check the value of args.get('log_level')
Qi, what are we achieving with this change (in order to fix sonic-net/sonic-buildimage#5992). Will the warnings start appearing as errors? #Resolved
There was a problem hiding this comment.
Can the description of the PR be modified with some context? #Resolved
There was a problem hiding this comment.
Warnings in swsscommon will still be warnings. Here I set the log_level higher to ERROR, so warning will disappear in syslog.
In reply to: 529841456 [](ancestors = 529841456)
There was a problem hiding this comment.
Depends on sonic-net/sonic-swss-common#418
There are many warning messages in swsscommon. Here I set the log_level higher to ERROR, so warnings will disappear in syslog.
Fixed sonic-net/sonic-buildimage#5992