[swig] wrap logger.h #418
Merged
[swig] wrap logger.h #418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jleveque
reviewed
Nov 21, 2020
common/logger.h
Outdated
Comment on lines
134
to
137
| #ifndef SWIG | ||
| [[ noreturn ]] | ||
| #endif | ||
| void settingThread(); |
There was a problem hiding this comment.
This is a bit hard to read. Is there a way we could create a macro, e.g.,
#ifdef SWIG
# define ATTRIBUTE_NORTEURN
#else
# define ATTRIBUTE_NORTEURN [[ noreturn ]]
#endifor
#ifdef SWIG
# define ATTRIBUTE_NORTEURN
#else
# define ATTRIBUTE_NORTEURN __declspec(noreturn)
#endifThen use:
ATTRIBUTE_NORTEURN void settingThread();There was a problem hiding this comment.
Thanks for the feedback! Actually I found similar code in this file and followed. And positively testing GNU make more sense. Do you read better?
In reply to: 528070062 [](ancestors = 528070062)
There was a problem hiding this comment.
Sorry, but it's not much better. I was hoping to separate the #ifdef to a macro that can be reused so that this can become a one-line solution, e.g.,
ATTRIBUTE_NORTEURN void settingThread();What makes it difficult to read is the fact that the attribute and the declaration are on different lines.
kcudnik
approved these changes
Nov 22, 2020
jleveque
approved these changes
Nov 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to sonic-net/sonic-buildimage#5992
It turns out that we need to set log level in snmpagent repo.