[bitmap_vnet] Fix VNET route priority issue #1421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Volodymyr Samotiy <volodymyrs@mellanox.com>
volodymyrsamotiy
force-pushed
the
vnet_subnet_route
branch
from
795a204
to
2ec113e
Compare
2 tasks
prsunny
approved these changes
Sep 3, 2020
| { | ||
| SWSS_LOG_ENTER(); | ||
|
|
||
| for (uint32_t i = 0; i < tunnelOffsets_.size(); i++) | ||
| uint32_t offsetStart = VNET_ROUTE_FULL_MASK_OFFSET_MAX + 1; |
There was a problem hiding this comment.
tunnelOffsets[VNET_ROUTE_FULL_MASK_OFFSET_MAX] will not be included in any range.
It should be uint32_t offsetStart = VNET_ROUTE_FULL_MASK_OFFSET_MAX;
marian-pritsak
approved these changes
Sep 3, 2020
abdosi
pushed a commit
that referenced
this pull request
Sep 3, 2020
Signed-off-by: Volodymyr Samotiy <volodymyrs@mellanox.com>
EdenGri
pushed a commit
to EdenGri/sonic-swss
that referenced
this pull request
Feb 28, 2022
Refactor sfputil to use sonic-platform package in lieu of old, deprecated platform plugins. The sfputil utility is still useful, as sfpshow only reads and displays SFP data from State DB. However, we still need a utility to write to the transceivers (low power mode, reset, etc.), and the ability to read directly from the transceivers is helpful for debugging. - Complete refactor to use sonic-platform package - Refactor display functions to align with sfpshow utility - Bump version to 3.0 - Add unit tests
oleksandrivantsiv
pushed a commit
to oleksandrivantsiv/sonic-swss
that referenced
this pull request
Mar 1, 2023
* SAI submodule update - d0f3333 Tunnel Scoped TC MAP and Remarking (sonic-net#1413) (sonic-net#1451) - 62364a3 Add two more API as RPC for warmboot testing (sonic-net#1421) (sonic-net#1437) - 426fad1 Make saithriftv compatible with thrift 0.14.1 (sonic-net#1433) Signed-off-by: bingwang <bingwang@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Volodymyr Samotiy volodymyrs@mellanox.com
What I did
Provided logic to create "full mask" routes with highest priority.
Why I did it
To fix VNET route priority issue in order to support flow when some IPs from the subnet are defined by another route (nexthop tunnel) .
How I verified it
192.168.1.1/24)192.168.1.2)192.168.1.10/32 via tunnel)192.168.1.2192.168.1.10Details if related
N/A