remove FDB entires of BridgePort before removing the BridgePort #1451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prsunny
reviewed
Sep 29, 2020
prsunny
reviewed
Sep 30, 2020
prsunny
reviewed
Sep 30, 2020
prsunny
reviewed
Sep 30, 2020
prsunny
reviewed
Oct 1, 2020
prsunny
reviewed
Oct 1, 2020
prsunny
approved these changes
Oct 1, 2020
|
@liat-grozovik cherry-pick has conflcit |
|
included as PR #1516 |
EdenGri
pushed a commit
to EdenGri/sonic-swss
that referenced
this pull request
Feb 28, 2022
Increase verbosity of pytest to allow for full, non-truncated error messages to appear in CI unit test results in order to help facilitate troubleshooting of unit test failures.
yxieca
pushed a commit
that referenced
this pull request
Oct 25, 2022
* remove FDB entires of BridgePort before removing the BridgePort Co-authored-by: Madhan Babu <madhan@arc-build-server.mtr.labs.mlnx>
|
This change, though cherry-picked cleanly to 201811, but is not able to build. |
oleksandrivantsiv
pushed a commit
to oleksandrivantsiv/sonic-swss
that referenced
this pull request
Mar 1, 2023
* SAI submodule update - d0f3333 Tunnel Scoped TC MAP and Remarking (sonic-net#1413) (sonic-net#1451) - 62364a3 Add two more API as RPC for warmboot testing (sonic-net#1421) (sonic-net#1437) - 426fad1 Make saithriftv compatible with thrift 0.14.1 (sonic-net#1433) Signed-off-by: bingwang <bingwang@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
To fix an issue when removing bridgeport, I introduced code to remove FDB entries of the bridgeport before calling SAI API remove BridgePort.
Why I did it
I introduced this fix because by directly removing the bridgeport without flushing the bridge port's FDB entries, the bridge port removal was failing, since it had uncleaned ASIC DB FDB entries.
How I verified it
I verified it by sending traffic to the vlan port and creating a FDB entry for the vlan port. By, then when I remove the bridge port member from the VLAN port, the FDB entry was removed as well as bridge port is removed from VLAN membership.
Details if related
The fix is introduced in PortsOrch.cpp