[everflow] Add retry mechanism for mirror sessions and policers #1486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wendani
reviewed
Oct 27, 2020
daall
force-pushed
the
fix_everflow_boot_up_sequence
branch
from
b628f35 to
6170932
Compare
qiluo-msft
reviewed
Nov 6, 2020
|
retest vs please |
Signed-off-by: Danny Allen <daall@microsoft.com>
daall
force-pushed
the
fix_everflow_boot_up_sequence
branch
from
a754849 to
d57e6ca
Compare
qiluo-msft
reviewed
Dec 8, 2020
wendani
reviewed
Dec 9, 2020
qiluo-msft
approved these changes
Dec 10, 2020
arlakshm
pushed a commit
to arlakshm/sonic-swss
that referenced
this pull request
Dec 15, 2020
…c-net#1486) Signed-off-by: Danny Allen <daall@microsoft.com> Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan <arlakshm@microsoft.com>
Closed
3 tasks
This was referenced Oct 15, 2021
EdenGri
pushed a commit
to EdenGri/sonic-swss
that referenced
this pull request
Feb 28, 2022
…et#1486) Signed-off-by: Yong Zhao yozhao@microsoft.com What I did If the rebooting of SONiC device was caused by kernel panic, then the CLI command show reboot-cause should show Kernel Panic. How I did it Currently if kernel was panicked, then the device would be rebooted. The reboot script wrote a message into reboot-cause.txt. I just updated the content of this message. How to verify it I verified this change on the virtual switch in the following steps: Trigger kernel panic: echo c > /proc/sysrq-trigger After device was rebooted, run the CLI show reboot-cause: admin@vlab-01:~$ show reboot-cause Kernel Panic [Time: Tue 09 Mar 2021 03:03:56 AM UTC] Previous command output (if the output of a command-line utility has changed) admin@vlab-01:~$ show reboot-cause User issued 'kdump' command [User: kdump, Time: Mon 08 Mar 2021 01:47:43 AM UTC] New command output (if the output of a command-line utility has changed) admin@vlab-01:~$ show reboot-cause Kernel Panic [Time: Tue 09 Mar 2021 03:03:56 AM UTC]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Danny Allen daall@microsoft.com
What I did
I added retry mechanisms to
AclOrchfor mirror sessions andMirrorOrchfor policers.Why I did it
Fixes sonic-net/sonic-buildimage#5497
How I verified it
Tested on a DUT locally.
THIS STILL NEEDS VS TESTS AS WELL.Details if related
This will not cherry-pick cleanly to 201911 b/c of the port mirroring feature, so I will open a separate PR for 201911 once this one is reviewed + merged.
In draft while I finish the VS tests.