Reduce severity of log to info in case of flush on non-existing member #1669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
prsunny
reviewed
Mar 11, 2021
orchagent/fdborch.cpp
Outdated
| if (type == SAI_FDB_EVENT_FLUSHED) | ||
| { | ||
| /* in case of flush - can be ignored due to a race */ | ||
| /* there are notifications about FDB FLUSH (syncd/sai_redis) on port which was already removed |
There was a problem hiding this comment.
Please combine the comments from previous line and have as a single block of comment.
orchagent/fdborch.cpp
Outdated
| /* in case of flush - can be ignored due to a race */ | ||
| /* there are notifications about FDB FLUSH (syncd/sai_redis) on port which was already removed | ||
| * by orchagent as a result of removeVlanMember action (removeBridgePort) */ | ||
| SWSS_LOG_INFO("Flush ignored. Received event on bridge port ID 0x%" PRIx64 " which is not exist.", |
There was a problem hiding this comment.
Can you please rephrase to "Flush event: Failed to get port by bridge port ID 0x%" PRIx64 "."
There was a problem hiding this comment.
I can :) but, IMO its better to avoid to use word "Failed"in INFO notification.
What do you think?
There was a problem hiding this comment.
Agree, but this has been the model for some exceptions.. For e.g check this. IMO, even though it is INFO, it is still a failure in fetch the data.
|
Also can you please respond to sonic-net/sonic-buildimage#6936, before the PR merge? |
|
@allas-nvidia please align the code based on the above comments. |
allas-nvidia
force-pushed
the
warn_fdb_flush
branch
from
315f16a
to
066675a
Compare
Signed-off-by: allas <allas@nvidia.com>
allas-nvidia
force-pushed
the
warn_fdb_flush
branch
from
066675a
to
7a1a4d3
Compare
liat-grozovik
approved these changes
Mar 17, 2021
liat-grozovik
approved these changes
Mar 21, 2021
liat-grozovik
changed the title
yxieca
pushed a commit
that referenced
this pull request
Mar 26, 2021
#1669) - What I did Reduced severity of log to info in case of flush on non-existing member. - Why I did it There is a race in the infra which can cause the scenario: FDB FLUSH notification is received on port which was already removed. - How I verified it > sudo config vlan add 3 > sudo config vlan member add 3 Ethernet8 > sudo config vlan member del 3 Ethernet8 Signed-off-by: allas <allas@nvidia.com>
raphaelt-nvidia
pushed a commit
to raphaelt-nvidia/sonic-swss
that referenced
this pull request
Oct 5, 2021
sonic-net#1669) - What I did Reduced severity of log to info in case of flush on non-existing member. - Why I did it There is a race in the infra which can cause the scenario: FDB FLUSH notification is received on port which was already removed. - How I verified it > sudo config vlan add 3 > sudo config vlan member add 3 Ethernet8 > sudo config vlan member del 3 Ethernet8 Signed-off-by: allas <allas@nvidia.com>
EdenGri
pushed a commit
to EdenGri/sonic-swss
that referenced
this pull request
Feb 28, 2022
What I did HLD for Dump Utility: HLD. For More info on Tech Support Addition: TechSupport How I did it Module Names are retrieved by parsing the output of dump state --show command.
EdenGri
pushed a commit
to EdenGri/sonic-swss
that referenced
this pull request
Feb 28, 2022
What I did Implemented vlan and vlan_member modules for debug dump utility. How I did it Used infrastructure and followed examples in sonic-net#1666 sonic-net#1667 sonic-net#1668 sonic-net#1669 sonic-net#1670 How to verify it On switch: dump state vlan <vlan_name> dump state vlan_member '<vlan_name|<member_name>' Unit test: pytest-3 dump_tests/module_tests/vlan_test.py (same test file covers both vlan and vlan_member)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: allas allas@nvidia.com
What I did
Reduced severity of log to info in case of flush on non-existing member.
Why I did it
There is a race in the infra which can cause the scenario: FDB FLUSH notification is received on port which was already removed.
How I verified it
> sudo config vlan add 3
> sudo config vlan member add 3 Ethernet8
> sudo config vlan member del 3 Ethernet8
Details if related