[Flex Counters] Delay flex counters even if tables are present in the DB #1877
Conversation
Signed-off-by: Shlomi Bitton <shlomibi@nvidia.com>
Signed-off-by: Shlomi Bitton <shlomibi@nvidia.com>
|
/azpw run |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@shlomibitton is it relevant for 202106? |
|
@shlomibitton pls handle LGTM errors |
|
@liat-grozovik Yes it is. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azpw run |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@kcudnik LGTM is still failing since FLEX_COUNTER_DELAY_STATUS_FIELD is not declared even though PR sonic-net/sonic-swss-common#523 already merged, this field should be declared. |
|
it was merged on master ? in swss-common? |
|
/azpw run |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
This pull request introduces 1 alert when merging 0febef7 into 15a014b - view on LGTM.com new alerts:
|
I just ran LGTM again, and it could complete without such errors. There is a empty condition warning which we know the reason for. |
|
/azpw run |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
… DB (#1877) **What I did** Check if delay indicator flag is exist and 'true', if it does, skip the counter enablement. **Why I did it** Currently if flex counters tables are present in config DB the delay mechanism will not take place. This change is to make sure the delay will take place even if the tables are present in the DB. **How I verified it** Observer counters are created after enable_counters script is called. **Details if related**
shlomibitton
deleted the
shlomi_adapt_flex_counters_delay_with_user_config_master
branch
… DB (sonic-net#1877) **What I did** Check if delay indicator flag is exist and 'true', if it does, skip the counter enablement. **Why I did it** Currently if flex counters tables are present in config DB the delay mechanism will not take place. This change is to make sure the delay will take place even if the tables are present in the DB. **How I verified it** Observer counters are created after enable_counters script is called. **Details if related**
What I did Implemented vlan and vlan_member modules for debug dump utility. How I did it Used infrastructure and followed examples in sonic-net#1666 sonic-net#1667 sonic-net#1668 sonic-net#1669 sonic-net#1670 How to verify it On switch: dump state vlan <vlan_name> dump state vlan_member '<vlan_name|<member_name>' Unit test: pytest-3 dump_tests/module_tests/vlan_test.py (same test file covers both vlan and vlan_member)
What I did
Check if delay indicator flag is exist and 'true', if it does, skip the counter enablement.
Why I did it
Currently if flex counters tables are present in config DB the delay mechanism will not take place.
This change is to make sure the delay will take place even if the tables are present in the DB.
How I verified it
Observer counters are created after enable_counters script is called.
Details if related