ASIC temperature sensors support #694
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stcheng
reviewed
Nov 20, 2018
|
|
||
| /* Add switch to flex_counter for updating sensors */ | ||
| const auto id = sai_serialize_object_id(gSwitchId); | ||
| string key = getSwitchSensorsFlexCounterTableKey(id); |
There was a problem hiding this comment.
string key = SWITCH_SENSORS_FLEX_GROUP + id;
i think it would be clearer
| /* Add switch to flex_counter for updating sensors */ | ||
| const auto id = sai_serialize_object_id(gSwitchId); | ||
| string key = getSwitchSensorsFlexCounterTableKey(id); | ||
| std::string delimiter = ""; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please do not merge yet.
Recently (opencomputeproject/SAI#880), new switch attributes were added to retrieve the temperature readings from the ASIC's internal sensors.
This is a preliminary commit (pending SAI support from vendors) for temperature monitoring. The max, average and the entire list of temperatures are now added to the flex counters DB so that platform sensors scripts may query and use these values in thermal control algorithms.
What I did
Why I did it
To provide a mechanism for platform sensor scripts to have a generic way of querying the ASIC sensors via SAI.
How I verified it
Currently checked using stubs. Awaiting SAI implementation from vendors.
Details if related