Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ASIC temperature sensors support #2267

Closed
wants to merge 1 commit into from
Closed

ASIC temperature sensors support #2267

wants to merge 1 commit into from

Conversation

padmanarayana
Copy link
Contributor

Please do not merge yet.

Recently (opencomputeproject/SAI#880), new switch attributes were added to retrieve the temperature readings from the ASIC's internal sensors.

This is a preliminary commit (pending SAI support from vendors) for temperature monitoring. The max, average and the entire list of temperatures are now added to the flex counters DB so that platform sensors scripts may query and use these values in thermal control algorithms.

- What I did

Added support to retrieve the ASIC internal temperature measurements from flex counters.

- How I did it

  1. Added a new script to retrieve the ASIC temperatures from the flex counter DB
  2. Enabled the sensors group in the flex table of configDB.

- How to verify it

Checked using stubs. Awaiting testing based on vendor implementation.

- Description for the changelog

ASIC temperature sensors support

- A picture of a cute animal (not mandatory but encouraged)

@padmanarayana
Copy link
Contributor Author

Related PRs:
sonic-utilities: sonic-net/sonic-utilities#381
sonic-swss: sonic-net/sonic-swss#694
sonic-sairedis: sonic-net/sonic-sairedis#383
sonic-swss-common: sonic-net/sonic-swss-common#252

stcheng
stcheng reviewed Nov 20, 2018
View reviewed changes
Copy link
Contributor

@stcheng stcheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about the alarms? will alarms be generated when the asic sensor doesn't work or reports an abnormal value?

platform/broadcom/sonic-platform-modules-dell/common/asic_sensors.py
# along wtih the average.

import swsssdk
import json
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

json is not used

platform/broadcom/sonic-platform-modules-dell/common/asic_sensors.py
+ ' (max ' + str(max_temp) + ' C)' \
+ ' (' + ' '.join(str(x) for x in temp_list) + ' C)'
else:
print '\nBCM Internal: ' + 'NA'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you provide a sample output here?

dprital added a commit to dprital/sonic-buildimage that referenced this pull request May 25, 2022
@dprital
[submodule] Update sonic-swss submodule
2d56d10 
[muxorch] Handling optional attributes in muxorch (sonic-net#2288)
Update netlink messages handler (sonic-net#2233)
Broadcast Unknown-multicast and Unknown-unicast Storm-control (sonic-net#1306)
[vstest]: Increase PollingConfig default timeout (sonic-net#2285)
[FDB] Fix fbdorch to properly handle syncd FDB FLUSH Notif (sonic-net#2254)
[macsecorch]: Support for non-default sa per sc (sonic-net#2250)
Migrating the NAT vs tests from Click to direct DB access (sonic-net#2278)
[neighsync] Ignoring IPv4 link local addresses (sonic-net#2260)
[IntfMgrd] Retry adding ipv6 prefix by setting disabled_ipv6 flag  (sonic-net#2267)
Increase Redis Timeout value for Switch Create Opration for Packet (sonic-net#2243)
Update fdborch.cpp (sonic-net#2261)

Signed-off-by: dprital <drorp@nvidia.com>
@dprital dprital mentioned this pull request May 25, 2022
Merged
6 tasks
judyjoseph added a commit that referenced this pull request May 25, 2022
@judyjoseph
Update sonic-swss, sonic-utilities
45b4f49 
swss

081d47b Update netlink messages handler (#2233)
de7c3eb [IntfMgrd] Retry adding ipv6 prefix by setting disabled_ipv6 flag  (#2267)

utilities

2716ff2 [yang] extend ConfigMgmt constructor to pass YANG options (#2118)
9fbe2ef [debug dump] dump interface module added (#2070)
a86da2d Add sonic-delayed.target to Application Extension .timer file generator (#2176)
90611dd [portconfig] Allow to configure interface mtu for physical ports only
liat-grozovik pushed a commit that referenced this pull request May 26, 2022
@dprital
[submodule] Advanced sonic-swss pointer (#10926)
a5932e3 
[muxorch] Handling optional attributes in muxorch (#2288)
Update netlink messages handler (#2233)
Broadcast Unknown-multicast and Unknown-unicast Storm-control (#1306)
[vstest]: Increase PollingConfig default timeout (#2285)
[FDB] Fix fbdorch to properly handle syncd FDB FLUSH Notif (#2254)
[macsecorch]: Support for non-default sa per sc (#2250)
Migrating the NAT vs tests from Click to direct DB access (#2278)
[neighsync] Ignoring IPv4 link local addresses (#2260)
[IntfMgrd] Retry adding ipv6 prefix by setting disabled_ipv6 flag  (#2267)
Increase Redis Timeout value for Switch Create Opration for Packet (#2243)
Update fdborch.cpp (#2261)

Signed-off-by: dprital <drorp@nvidia.com>
liushilongbuaa pushed a commit to liushilongbuaa/sonic-buildimage that referenced this pull request Jun 20, 2022
@yxieca
Merged PR 6148955: Manual merge internal branch with github master br…
a1e7352 
…anch

Related work items: #52, #71, #73, #75, #77, sonic-net#1306, sonic-net#1588, sonic-net#1991, sonic-net#2031, sonic-net#2040, sonic-net#2053, sonic-net#2066, sonic-net#2069, sonic-net#2087, sonic-net#2107, sonic-net#2110, sonic-net#2112, sonic-net#2113, sonic-net#2117, sonic-net#2124, sonic-net#2125, sonic-net#2126, sonic-net#2128, sonic-net#2130, sonic-net#2131, sonic-net#2132, sonic-net#2133, sonic-net#2134, sonic-net#2135, sonic-net#2136, sonic-net#2137, sonic-net#2138, sonic-net#2139, sonic-net#2140, sonic-net#2143, sonic-net#2158, sonic-net#2161, sonic-net#2233, sonic-net#2243, sonic-net#2250, sonic-net#2254, sonic-net#2260, sonic-net#2261, sonic-net#2267, sonic-net#2278, sonic-net#2282, sonic-net#2285, sonic-net#2288, sonic-net#2289, sonic-net#2292, sonic-net#2294, sonic-net#8887, sonic-net#9279, sonic-net#9390, sonic-net#9511, sonic-net#9700, sonic-net#10025, sonic-net#10322, sonic-net#10479, sonic-net#10484, sonic-net#10493, sonic-net#10500, sonic-net#10580, sonic-net#10595, sonic-net#10628, sonic-net#10634, sonic-net#10635, sonic-net#10644, sonic-net#10670, sonic-net#10691, sonic-net#10716, sonic-net#10731, sonic-net#10750, sonic-net#10751, sonic-net#10752, sonic-net#10761, sonic-net#10769, sonic-net#10775, sonic-net#10776, sonic-net#10779, sonic-net#10786, sonic-net#10792, sonic-net#10793, sonic-net#10800, sonic-net#10806, sonic-net#10826, sonic-net#10839, sonic-net#10840, sonic-net#10842, sonic-net#10844, sonic-net#10847, sonic-net#10849, sonic-net#10852, sonic-net#10865, sonic-net#10872, sonic-net#10877, sonic-net#10886, sonic-net#10889, sonic-net#10903, sonic-net#10904, sonic-net#10905, sonic-net#10913, sonic-net#10914, sonic-net#10916, sonic-net#10919, sonic-net#10925, sonic-net#10926, sonic-net#10929, sonic-net#10933, sonic-net#10934, sonic-net#10937, sonic-net#10941, sonic-net#10947, sonic-net#10952, sonic-net#10953, sonic-net#10957, sonic-net#10959, sonic-net#10971, sonic-net#10972, sonic-net#10980
vivekrnv added a commit to vivekrnv/sonic-buildimage that referenced this pull request Aug 26, 2022
@vivekrnv
[IntfMgrd] Retry adding ipv6 prefix by setting disabled_ipv6 flag (so…
54e1847 
…nic-net#2267)

*intfmgrd sets the flag by itself and retries setting the ip address if the ipv6 assignment fails for the first time
*There might be a race condition b/w intfmgrd and Mellanox SDK where the SDK created Linux Netdev iface but still doesn't yet set disable_ipv6 flag to 0. If intfmgrd tries to assign ip to the iface, the attempt fails.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stcheng stcheng stcheng left review comments

@jleveque jleveque Awaiting requested review from jleveque

Assignees
No one assigned
Labels
Enhancement ➕ Platform: DellEMC
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@padmanarayana @stcheng