Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SONiC-CEL]: fix platform fancontrol testcase failure issue #10934

Merged
merged 1 commit into from
May 31, 2022
Merged

[SONiC-CEL]: fix platform fancontrol testcase failure issue #10934

merged 1 commit into from
May 31, 2022

Conversation

qnos
Copy link
Contributor

@qnos qnos commented May 26, 2022

[SONiC-CEL]: fix platform fancontrol testcase failure issue

Why I did it

  1. fix platform fancontrol testcase failure

How I did it

Running fancontrol platform test case would kill fancontrol daemon directly, the exit logic in fancontrol process detection logic would cause fancontrol daemon could not been pull up by supervisord and lead to the fancontrol daemon fail to start after the test case.

How to verify it

Run pmon fancontrol test cases, all cases would successfully pass.

$ ./run_tests.sh -d cel-e1031-01 -n cel_e1031_t0 -t t0,any -u -c platform_tests/daemon/test_fancontrol.py

platform_tests/daemon/test_fancontrol.py::test_pmon_fancontrol_running_status PASSED                            [ 25%]
platform_tests/daemon/test_fancontrol.py::test_pmon_fancontrol_stop_and_start_status PASSED                     [ 50%]
platform_tests/daemon/test_fancontrol.py::test_pmon_fancontrol_term_and_start_status PASSED                                                       [ 75%]
platform_tests/daemon/test_fancontrol.py::test_pmon_fancontrol_kill_and_start_status PASSED                                                       [100%]

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111

@qnos qnos requested a review from lguohan as a code owner May 26, 2022 14:08
@qnos
Copy link
Contributor Author

qnos commented May 27, 2022

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 10934 in repo Azure/sonic-buildimage

@Blueve
Copy link
Contributor

Blueve commented May 30, 2022

/azp ls

@azure-pipelines
Copy link

Command 'ls' is not supported by Azure Pipelines.

Supported commands
  • help:
    • Get descriptions, examples and documentation about supported commands
    • Example: help "command_name"
  • list:
    • List all pipelines for this repository using a comment.
    • Example: "list"
  • run:
    • Run all pipelines or specific pipelines for this repository using a comment. Use this command by itself to trigger all related pipelines, or specify specific pipelines to run.
    • Example: "run" or "run pipeline_name, pipeline_name, pipeline_name"
  • where:
    • Report back the Azure DevOps orgs that are related to this repository and org
    • Example: "where"

See additional documentation.

@Blueve
Copy link
Contributor

Blueve commented May 30, 2022

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Blueve Blueve merged commit 8c1ded6 into sonic-net:master May 31, 2022
liushilongbuaa pushed a commit to liushilongbuaa/sonic-buildimage that referenced this pull request Jun 20, 2022
…anch

Related work items: #52, #71, #73, #75, #77, sonic-net#1306, sonic-net#1588, sonic-net#1991, sonic-net#2031, sonic-net#2040, sonic-net#2053, sonic-net#2066, sonic-net#2069, sonic-net#2087, sonic-net#2107, sonic-net#2110, sonic-net#2112, sonic-net#2113, sonic-net#2117, sonic-net#2124, sonic-net#2125, sonic-net#2126, sonic-net#2128, sonic-net#2130, sonic-net#2131, sonic-net#2132, sonic-net#2133, sonic-net#2134, sonic-net#2135, sonic-net#2136, sonic-net#2137, sonic-net#2138, sonic-net#2139, sonic-net#2140, sonic-net#2143, sonic-net#2158, sonic-net#2161, sonic-net#2233, sonic-net#2243, sonic-net#2250, sonic-net#2254, sonic-net#2260, sonic-net#2261, sonic-net#2267, sonic-net#2278, sonic-net#2282, sonic-net#2285, sonic-net#2288, sonic-net#2289, sonic-net#2292, sonic-net#2294, sonic-net#8887, sonic-net#9279, sonic-net#9390, sonic-net#9511, sonic-net#9700, sonic-net#10025, sonic-net#10322, sonic-net#10479, sonic-net#10484, sonic-net#10493, sonic-net#10500, sonic-net#10580, sonic-net#10595, sonic-net#10628, sonic-net#10634, sonic-net#10635, sonic-net#10644, sonic-net#10670, sonic-net#10691, sonic-net#10716, sonic-net#10731, sonic-net#10750, sonic-net#10751, sonic-net#10752, sonic-net#10761, sonic-net#10769, sonic-net#10775, sonic-net#10776, sonic-net#10779, sonic-net#10786, sonic-net#10792, sonic-net#10793, sonic-net#10800, sonic-net#10806, sonic-net#10826, sonic-net#10839, sonic-net#10840, sonic-net#10842, sonic-net#10844, sonic-net#10847, sonic-net#10849, sonic-net#10852, sonic-net#10865, sonic-net#10872, sonic-net#10877, sonic-net#10886, sonic-net#10889, sonic-net#10903, sonic-net#10904, sonic-net#10905, sonic-net#10913, sonic-net#10914, sonic-net#10916, sonic-net#10919, sonic-net#10925, sonic-net#10926, sonic-net#10929, sonic-net#10933, sonic-net#10934, sonic-net#10937, sonic-net#10941, sonic-net#10947, sonic-net#10952, sonic-net#10953, sonic-net#10957, sonic-net#10959, sonic-net#10971, sonic-net#10972, sonic-net#10980
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants