Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SIMX] [MLNX] Removed Platform specific reboot files for simx #10806

Merged
merged 2 commits into from
May 14, 2022
Merged

[SIMX] [MLNX] Removed Platform specific reboot files for simx #10806

merged 2 commits into from
May 14, 2022

Conversation

vivekrnv
Copy link
Contributor

Signed-off-by: Vivek Reddy Karri vkarri@nvidia.com

Why I did it

Platform_reboot files for simx doesn't do aything different apart from calling /sbin/reboot. which is anyway done in the /usr/local/bin/reboot script i.e. the parent script which calls the platform specific reboot scripts if present.

Moreover, /sbin/reboot invoked in the platform specific reboot script is a non-blocking call and thus it returns back to the original script (although /sbin/reboot does it job in the background) and we see messages like this.

Wed 04 May 2022 08:15:14 AM UTC Rebooting with platform x86_64-mlnx_msn2700_simx-r0 specific tool ...
Wed 04 May 2022 08:15:15 AM UTC Platform specific reboot failed!
Wed 04 May 2022 08:15:15 AM UTC Issuing OS-level reboot ...

admin@r-leopard-simx-69:~$ sudo reboot
.................................
................................
+ '[' -x /usr/share/sonic/device/x86_64-mlnx_msn4700_simx-r0/platform_reboot ']'
+ VERBOSE=yes
+ debug 'Rebooting with platform x86_64-mlnx_msn4700_simx-r0 specific tool ...'
+ [[ xyes == x\y\e\s ]]
++ date
+ echo Wed 04 May 2022 10:59:08 PM UTC Rebooting with platform x86_64-mlnx_msn4700_simx-r0 specific tool ...
Wed 04 May 2022 10:59:08 PM UTC Rebooting with platform x86_64-mlnx_msn4700_simx-r0 specific tool ...
+ logger 'Rebooting with platform x86_64-mlnx_msn4700_simx-r0 specific tool ...'
+ /usr/share/sonic/device/x86_64-mlnx_msn4700_simx-r0/platform_reboot
+ declare -r EXIT_SUCCESS=0
+ declare -r EXIT_ERROR=1
+ FORCE_REBOOT=no
+ ParseArguments
+ '[' 0 -ge 1 ']'
+ exec /sbin/reboot
+ sleep 1
+ VERBOSE=yes
+ debug 'Platform specific reboot failed!'
+ [[ xyes == x\y\e\s ]]
++ date
+ echo Wed 04 May 2022 10:59:09 PM UTC Platform specific reboot 'failed!'
Wed 04 May 2022 10:59:09 PM UTC Platform specific reboot failed!
+ logger 'Platform specific reboot failed!'
+ VERBOSE=yes
+ debug 'Issuing OS-level reboot ...'
+ [[ xyes == x\y\e\s ]]
++ date
+ echo Wed 04 May 2022 10:59:09 PM UTC Issuing OS-level reboot ...
Wed 04 May 2022 10:59:09 PM UTC Issuing OS-level reboot ...
+ logger 'Issuing OS-level reboot ...'
+ exec /sbin/reboot

How I did it

How to verify it

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@dgsudharsan dgsudharsan added Request for 202012 Branch Request for 202111 Branch For PRs being requested for 202111 branch labels May 11, 2022
@liat-grozovik liat-grozovik merged commit 5ea244c into sonic-net:master May 14, 2022
judyjoseph pushed a commit that referenced this pull request May 16, 2022
@vivekrnv @judyjoseph
Removed platform specific reboot files for mellanox simx platforms (#…
d628430 
…10806)

- Why I did it
Platform_reboot files for simx doesn't do aything different apart from calling /sbin/reboot. which is anyway done in the /usr/local/bin/reboot script i.e. the parent script which calls the platform specific reboot scripts if present.

Moreover, /sbin/reboot invoked in the platform specific reboot script is a non-blocking call and thus it returns back to the original script (although /sbin/reboot does it job in the background) and we see messages like this.

Signed-off-by: Vivek Reddy Karri <vkarri@nvidia.com>
qiluo-msft pushed a commit that referenced this pull request May 16, 2022
@vivekrnv @qiluo-msft
Removed platform specific reboot files for mellanox simx platforms (#…
cd0a060 
…10806)

- Why I did it
Platform_reboot files for simx doesn't do aything different apart from calling /sbin/reboot. which is anyway done in the /usr/local/bin/reboot script i.e. the parent script which calls the platform specific reboot scripts if present.

Moreover, /sbin/reboot invoked in the platform specific reboot script is a non-blocking call and thus it returns back to the original script (although /sbin/reboot does it job in the background) and we see messages like this.

Signed-off-by: Vivek Reddy Karri <vkarri@nvidia.com>
liushilongbuaa pushed a commit to liushilongbuaa/sonic-buildimage that referenced this pull request Jun 20, 2022
@yxieca
Merged PR 6148955: Manual merge internal branch with github master br…
a1e7352 
…anch

Related work items: #52, #71, #73, #75, #77, sonic-net#1306, sonic-net#1588, sonic-net#1991, sonic-net#2031, sonic-net#2040, sonic-net#2053, sonic-net#2066, sonic-net#2069, sonic-net#2087, sonic-net#2107, sonic-net#2110, sonic-net#2112, sonic-net#2113, sonic-net#2117, sonic-net#2124, sonic-net#2125, sonic-net#2126, sonic-net#2128, sonic-net#2130, sonic-net#2131, sonic-net#2132, sonic-net#2133, sonic-net#2134, sonic-net#2135, sonic-net#2136, sonic-net#2137, sonic-net#2138, sonic-net#2139, sonic-net#2140, sonic-net#2143, sonic-net#2158, sonic-net#2161, sonic-net#2233, sonic-net#2243, sonic-net#2250, sonic-net#2254, sonic-net#2260, sonic-net#2261, sonic-net#2267, sonic-net#2278, sonic-net#2282, sonic-net#2285, sonic-net#2288, sonic-net#2289, sonic-net#2292, sonic-net#2294, sonic-net#8887, sonic-net#9279, sonic-net#9390, sonic-net#9511, sonic-net#9700, sonic-net#10025, sonic-net#10322, sonic-net#10479, sonic-net#10484, sonic-net#10493, sonic-net#10500, sonic-net#10580, sonic-net#10595, sonic-net#10628, sonic-net#10634, sonic-net#10635, sonic-net#10644, sonic-net#10670, sonic-net#10691, sonic-net#10716, sonic-net#10731, sonic-net#10750, sonic-net#10751, sonic-net#10752, sonic-net#10761, sonic-net#10769, sonic-net#10775, sonic-net#10776, sonic-net#10779, sonic-net#10786, sonic-net#10792, sonic-net#10793, sonic-net#10800, sonic-net#10806, sonic-net#10826, sonic-net#10839, sonic-net#10840, sonic-net#10842, sonic-net#10844, sonic-net#10847, sonic-net#10849, sonic-net#10852, sonic-net#10865, sonic-net#10872, sonic-net#10877, sonic-net#10886, sonic-net#10889, sonic-net#10903, sonic-net#10904, sonic-net#10905, sonic-net#10913, sonic-net#10914, sonic-net#10916, sonic-net#10919, sonic-net#10925, sonic-net#10926, sonic-net#10929, sonic-net#10933, sonic-net#10934, sonic-net#10937, sonic-net#10941, sonic-net#10947, sonic-net#10952, sonic-net#10953, sonic-net#10957, sonic-net#10959, sonic-net#10971, sonic-net#10972, sonic-net#10980
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liat-grozovik liat-grozovik liat-grozovik approved these changes

@dgsudharsan dgsudharsan dgsudharsan approved these changes

@sujinmkang sujinmkang Awaiting requested review from sujinmkang

@prgeor prgeor Awaiting requested review from prgeor

@vdahiya12 vdahiya12 Awaiting requested review from vdahiya12

Assignees
No one assigned
Labels
Included in 202012 Branch Included in 202111 Branch Request for 202012 Branch Request for 202111 Branch For PRs being requested for 202111 branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vivekrnv @dgsudharsan @liat-grozovik @qiluo-msft @judyjoseph