[filter-fdb] Call Filter FDB Main From Within Test Code #1051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code coverage requires that python code be run with the same process. Current test code was invoking filter fdb via shell which launches new process and so coverage is not available. This PR calles the main method from within test code. signed-off-by: Tamer Ahmed <tamer.ahmed@microsoft.com>
|
can you fix the build error? |
|
in this case, it probably better to move this script as a console script. check out here. https://python-packaging.readthedocs.io/en/latest/command-line-scripts.html |
tahmed-dev
force-pushed
the
taahme/filter-fdb-call-script-from-test
branch
from
ea01c88 to
6d507f5
Compare
|
This pull request introduces 4 alerts when merging ede5e98 into a15b6bf - view on LGTM.com new alerts:
|
|
looks like build failure. |
|
This pull request introduces 1 alert when merging 5a77fca93fc2671f01da4a8767caf8e94e9d5937 into 37f131e - view on LGTM.com new alerts:
|
tahmed-dev
force-pushed
the
taahme/filter-fdb-call-script-from-test
branch
from
5a77fca to
3a00245
Compare
lguohan
approved these changes
Aug 15, 2020
tahmed-dev
added a commit
to tahmed-dev/sonic-utilities
that referenced
this pull request
Sep 1, 2020
Code coverage requires that python code be run with the same process. Current test code was invoking filter fdb via shell which launches new process and so coverage is not available. This PR calls the main method from within test code. signed-off-by: Tamer Ahmed <tamer.ahmed@microsoft.com>
yxieca
pushed a commit
that referenced
this pull request
Sep 3, 2020
* [filter-fdb] Call Filter FDB Main From Within Test Code (#1051) Code coverage requires that python code be run with the same process. Current test code was invoking filter fdb via shell which launches new process and so coverage is not available. This PR calls the main method from within test code. signed-off-by: Tamer Ahmed <tamer.ahmed@microsoft.com> * [filter-fdb] Fix Filter FDB With IPv6 Present in Config DB (#1059) Filter fdb was wiping out IPv4 entries when both IPv4 and IPv6 are associated with VLan interface. The reason is IPv6 network was overwriting IPv4 network. This pr add support to filter both IPv4 and IPv6 addresses signed-off-by: Tamer Ahmed <tamer.ahmed@microsoft.com>
abdosi
pushed a commit
that referenced
this pull request
Sep 3, 2020
Code coverage requires that python code be run with the same process. Current test code was invoking filter fdb via shell which launches new process and so coverage is not available. This PR calls the main method from within test code. signed-off-by: Tamer Ahmed <tamer.ahmed@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code coverage requires that python code be run with the same process.
Current test code was invoking filter fdb via shell which launches
new process and so coverage is not available. This PR calls
the main method from within test code.
signed-off-by: Tamer Ahmed tamer.ahmed@microsoft.com
- What I did
Change how main function is invoked
- How I did it
code refactor
- How to verify it
unit test passes
- Previous command output (if the output of a command-line utility has changed)
N/A
- New command output (if the output of a command-line utility has changed)
N/A