[CLI][show][platform] Added ASIC count in the output. #1185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d option for JSON output
jleveque
reviewed
Oct 22, 2020
show/main.py
Outdated
Comment on lines
1021
to
1022
| if verbose: | ||
| click.echo("ASIC Count: {}".format(hw_info_dict['asic_count'])) |
There was a problem hiding this comment.
I think it may be better to always display this line without the need for a --verbose flag. Just need to check the rest of the SONiC codebase to see if this output is parsed anywhere and make sure it is smart enough to handle an additional line.
Does anyone disagree?
There was a problem hiding this comment.
At this point it may seem redundant for most cases, but I prefer that too - show by default.
|
retest this please |
smaheshm
changed the title
jleveque
reviewed
Oct 22, 2020
|
LGTM |
abdosi
approved these changes
Oct 26, 2020
jleveque
approved these changes
Oct 26, 2020
|
@smaheshm Create PR for 201911 |
smaheshm
added a commit
to smaheshm/sonic-utilities
that referenced
this pull request
Nov 10, 2020
abdosi
pushed a commit
that referenced
this pull request
Nov 13, 2020
stepanblyschak
pushed a commit
to stepanblyschak/sonic-utilities
that referenced
this pull request
Apr 28, 2022
c0df635 (HEAD -> 201911, origin/201911) Updates to bgp config and show commands with BGP_INTERNAL_NEIGHBOR table (sonic-net#1224) (sonic-net#1237) d683bb4 [CLI][show][platform] Added ASIC count in the output. (sonic-net#1185) (sonic-net#1227) 4585be1 [show] Fix 'show int neigh expected' (sonic-net#1189) 29e4469 [201911][fwutil]: Use logger from sonic-py-common (sonic-net#1190) Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Added platform ASIC count output to platform summary. Also added option for JSON output.
- How I did it
Added ASIC count in hardware info.
- How to verify it
Manual CLI verification.
- Previous command output (if the output of a command-line utility has changed)
- New command output (if the output of a command-line utility has changed)