Updates to bgp config and show commands with BGP_INTERNAL_NEIGHBOR table #1224
Conversation
bgp sessions to a new table BGP_INTERNAL_TABLE
|
@judyjoseph Should we remove the internal sessions from |
Yes Pavel, we don't display the internal bgp sessions by default, I have added the o/p of "show ip bgp summary" in the PR description. It will be shown only if user gives the option "-d all" explicitly as the command below. |
|
@pavel-shirshov @arlakshm, please take a look. I wanted to update the unit tests as well.. |
|
@judyjoseph - is this one still needed to be cherry-picked to 201911? @arlakshm - please review/approve? Thanks. |
|
@rlhui already in 201911 via direct pr for 201911 |
c0df635 (HEAD -> 201911, origin/201911) Updates to bgp config and show commands with BGP_INTERNAL_NEIGHBOR table (sonic-net#1224) (sonic-net#1237) d683bb4 [CLI][show][platform] Added ASIC count in the output. (sonic-net#1185) (sonic-net#1227) 4585be1 [show] Fix 'show int neigh expected' (sonic-net#1189) 29e4469 [201911][fwutil]: Use logger from sonic-py-common (sonic-net#1190) Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
Reintroduce the msft templates for multi-asic(3164) after the following sonic public PR's ( for internal BGP neighbors) are available in internal-201911 branch. sonic-net#5520 sonic-net#5760 sonic-net/sonic-swss-common#389 sonic-net/sonic-utilities#1224 How did I verify ----------------- 1. Verified the external and internal BGP sessions are up, shown correctly in "show ip bgp summary -d all" and show ip interface commands. 2. Ran related 3164 tests to make sure it is passing. bgp/test_bgp_fact.py::test_bgp_facts[0-0] PASSED [ 16%] bgp/test_bgp_fact.py::test_bgp_facts[0-1] PASSED [ 33%] bgp/test_bgp_fact.py::test_bgp_facts[0-2] PASSED [ 50%] bgp/test_bgp_fact.py::test_bgp_facts[0-3] PASSED [ 66%] bgp/test_bgp_fact.py::test_bgp_facts[0-4] PASSED [ 83%] bgp/test_bgp_fact.py::test_bgp_facts[0-5] PASSED [100%] bgp/test_bgp_multipath_relax.py::test_bgp_multipath_relax[0] PASSED [ 57%] bgp/test_bgp_multipath_relax.py::test_bgp_multipath_relax[1] PASSED [ 63%] bgp/test_bgp_multipath_relax.py::test_bgp_multipath_relax[2] SKIPPED [ 68%] bgp/test_bgp_multipath_relax.py::test_bgp_multipath_relax[3] SKIPPED [ 73%] bgp/test_bgp_multipath_relax.py::test_bgp_multipath_relax[4] SKIPPED [ 78%] bgp/test_bgp_multipath_relax.py::test_bgp_multipath_relax[5] SKIPPED [ 84%]
- What I did
Updates to bgp config and show commands with the movement of internal bgp sessions to a new table BGP_INTERNAL_NEIGHBOR table.
With the introduction of BGP_INERNAL_NEIGHBOR table, the user cannot start/stop/remove internal neighbors which I feel is not needed as these internal bgp sessions which are supposed to be UP allways.
- How I did it
Updated the show/bgp util so that it gets the internal bgp sessions from BGP_INTERNAL_NEIGHBOR table.
Removed the API's to get the local_as in config/bgp which is not required now.
- How to verify it
Made sure that the output remain same with the new internal bgp neighbor table.
- Previous command output (if the output of a command-line utility has changed)
- New command output (if the output of a command-line utility has changed)