[decode-syseeprom] Fix setting use_db based on support_eeprom_db #2270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lizhuhuams
previously approved these changes
Jul 29, 2022
There was a problem hiding this comment.
this works!
Please add Unit Test other wise this cannot be merged.
Please refer to the following link to see how Unit Tests can be added.
https://github.com/Azure/sonic-utilities/pull/2189/files
|
This pull request fixes 1 alert when merging 1ccd774 into ecb9136 - view on LGTM.com fixed alerts:
|
lizhuhuams
approved these changes
Aug 3, 2022
vdahiya12
approved these changes
Aug 3, 2022
|
Can you please remove the LGTM @byu343 |
Do you mean the "LGTM analysis: Python"? It looks passed. |
7 tasks
yxieca
pushed a commit
that referenced
this pull request
Sep 1, 2022
What I did Set use_db after support_eeprom_db is determined. The issue was affecting platform Arista platforms, where db is not used for syseeprom. How to verify it Verified on dut by running "show platform syseeprom" and "decode-syseeprom -d"
dprital
added a commit
to dprital/sonic-buildimage
that referenced
this pull request
Sep 7, 2022
Update sonic-utilities submodule pointer to include the following: * [route_check]: Ignore standalone tunnel routes (sonic-net#2325) ([sonic-net#2346](sonic-net/sonic-utilities#2346)) * [VRF]Adding CLI checks to ensure Vrf is valid in interface bind and static route commands ([sonic-net#2333](sonic-net/sonic-utilities#2333)) * Subinterface vrf bind issue fix ([sonic-net#2211](sonic-net/sonic-utilities#2211)) * [decode-syseeprom] Fix setting use_db based on support_eeprom_db ([sonic-net#2270](sonic-net/sonic-utilities#2270)) * Fix vrf UT failed issue ([sonic-net#2309](sonic-net/sonic-utilities#2309)) Signed-off-by: dprital <drorp@nvidia.com>
7 tasks
yxieca
pushed a commit
to sonic-net/sonic-buildimage
that referenced
this pull request
Sep 8, 2022
Update sonic-utilities submodule pointer to include the following: * [route_check]: Ignore standalone tunnel routes (#2325) ([#2346](sonic-net/sonic-utilities#2346)) * [VRF]Adding CLI checks to ensure Vrf is valid in interface bind and static route commands ([#2333](sonic-net/sonic-utilities#2333)) * Subinterface vrf bind issue fix ([#2211](sonic-net/sonic-utilities#2211)) * [decode-syseeprom] Fix setting use_db based on support_eeprom_db ([#2270](sonic-net/sonic-utilities#2270)) * Fix vrf UT failed issue ([#2309](sonic-net/sonic-utilities#2309)) Signed-off-by: dprital <drorp@nvidia.com> Signed-off-by: dprital <drorp@nvidia.com>
preetham-singh
pushed a commit
to preetham-singh/sonic-utilities
that referenced
this pull request
Nov 21, 2022
…ic-net#2270) What I did Set use_db after support_eeprom_db is determined. The issue was affecting platform Arista platforms, where db is not used for syseeprom. How to verify it Verified on dut by running "show platform syseeprom" and "decode-syseeprom -d"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Set use_db after support_eeprom_db is determined. The issue was affecting platform Arista platforms, where db is not used for syseeprom.
How I did it
How to verify it
Verified on dut by running "show platform syseeprom" and "decode-syseeprom -d"
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)