[vs]: only send lldp over eth0 (management port) #2309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In vs platform, eth[n] where n > 0 is physical port, we should not send lldp over those ports Signed-off-by: Guohan Lu <gulv@microsoft.com>
jleveque
approved these changes
Nov 28, 2018
|
so this infers that in SONiC we could only have one management interface which is |
yxieca
added a commit
to yxieca/sonic-buildimage
that referenced
this pull request
Jun 8, 2022
To included: * ad8f5e4 2022-06-08 | Revert "[Counters] Improve performance by polling only configured ports buffer queue/pg counters (sonic-net#2143)" (sonic-net#2315) (HEAD -> master, origin/master, origin/HEAD) [Ying Xie] * 2ff763f 2022-06-08 | Fix test_warm_reboot issues blocking PR merge (sonic-net#2309) [Vaibhav Hemant Dixit] * 05d19ea 2022-06-02 | Purge package sonic-db-cli which depends on libswsscommon (sonic-net#2308) [Qi Luo] * a0c3238 2022-06-03 | Add port counter sanity check (sonic-net#2300) [Junhua Zhai] * 4944f0f 2022-06-03 | Revert "[portsorch]: Prevent LAG member configuration when port has active ACL binding (sonic-net#2165)" (sonic-net#2306) [bingwang-ms] * eba212d 2022-05-31 | [Counters] Improve performance by polling only configured ports buffer queue/pg counters (sonic-net#2143) [shlomibitton] * 9999dae 2022-05-28 | [counter] Support gearbox counters (sonic-net#2218) [Junhua Zhai] * c73cf10 2022-05-28 | Support mock_test infra for dynamic buffer manager and fix issues found during mock test (sonic-net#2234) [Stephen Sun] Signed-off-by: Ying Xie <ying.xie@microsoft.com>
yxieca
added a commit
that referenced
this pull request
Jun 9, 2022
To included: * ad8f5e4 2022-06-08 | Revert "[Counters] Improve performance by polling only configured ports buffer queue/pg counters (#2143)" (#2315) (HEAD -> master, origin/master, origin/HEAD) [Ying Xie] * 2ff763f 2022-06-08 | Fix test_warm_reboot issues blocking PR merge (#2309) [Vaibhav Hemant Dixit] * 05d19ea 2022-06-02 | Purge package sonic-db-cli which depends on libswsscommon (#2308) [Qi Luo] * a0c3238 2022-06-03 | Add port counter sanity check (#2300) [Junhua Zhai] * 4944f0f 2022-06-03 | Revert "[portsorch]: Prevent LAG member configuration when port has active ACL binding (#2165)" (#2306) [bingwang-ms] * eba212d 2022-05-31 | [Counters] Improve performance by polling only configured ports buffer queue/pg counters (#2143) [shlomibitton] * 9999dae 2022-05-28 | [counter] Support gearbox counters (#2218) [Junhua Zhai] * c73cf10 2022-05-28 | Support mock_test infra for dynamic buffer manager and fix issues found during mock test (#2234) [Stephen Sun] Signed-off-by: Ying Xie <ying.xie@microsoft.com>
yxieca
added a commit
to yxieca/sonic-buildimage
that referenced
this pull request
Jun 9, 2022
linkmgrd: * 2da783b 2022-06-07 | Check self's mux mode before switching peer to standby & add support for `detach` mode (sonic-net#79) (HEAD -> 202205, github/202205) [Jing Zhang] sairedis: * 54642c7 2022-06-09 | [counter] Fix port flex counter (sonic-net#1052) (HEAD -> 202205, github/202205) [Junhua Zhai] * b7f5f92 2022-06-06 | [ci] Paralize azure pipeline (sonic-net#1054) [Shilong Liu] swss: * 77043fb 2022-06-09 | [fpmsyncd] don't manipulate route weight (sonic-net#2321) (HEAD -> 202205, github/202205) [Ying Xie] * ae157f1 2022-06-10 | Fix test_warm_reboot issues blocking PR merge (sonic-net#2309) (sonic-net#2318) [Shilong Liu] Signed-off-by: Ying Xie <ying.xie@microsoft.com>
yxieca
added a commit
that referenced
this pull request
Jun 10, 2022
linkmgrd: * 2da783b 2022-06-07 | Check self's mux mode before switching peer to standby & add support for `detach` mode (#79) (HEAD -> 202205, github/202205) [Jing Zhang] sairedis: * 54642c7 2022-06-09 | [counter] Fix port flex counter (#1052) (HEAD -> 202205, github/202205) [Junhua Zhai] * b7f5f92 2022-06-06 | [ci] Paralize azure pipeline (#1054) [Shilong Liu] swss: * 77043fb 2022-06-09 | [fpmsyncd] don't manipulate route weight (#2321) (HEAD -> 202205, github/202205) [Ying Xie] * ae157f1 2022-06-10 | Fix test_warm_reboot issues blocking PR merge (#2309) (#2318) [Shilong Liu] Signed-off-by: Ying Xie <ying.xie@microsoft.com>
judyjoseph
added a commit
that referenced
this pull request
Jun 14, 2022
b9c509d Fix test_warm_reboot issues blocking PR merge (#2309)
7 tasks
qiluo-msft
pushed a commit
that referenced
this pull request
Jun 21, 2022
Commits: bee3684 - 2022-06-20 : Add BGP profile to Vnet routes (#2339) [Prince Sunny] f9af510 - 2022-06-16 : [intfmgr]: Set proxy_arp kernel param (#2334) [Lawrence Lee] 725071f - 2022-06-08 : Fix test_warm_reboot issues blocking PR merge (#2309) [Vaibhav Hemant Dixit] 0db6f15 - 2021-11-16 : [orchagent] Flush pipeline every 1 second, not only when select will timeout (#2003) [Kamil Cudnik]
robertvolkmann
pushed a commit
to robertvolkmann/sonic-buildimage
that referenced
this pull request
Jul 26, 2022
linkmgrd: * 2da783b 2022-06-07 | Check self's mux mode before switching peer to standby & add support for `detach` mode (sonic-net#79) (HEAD -> 202205, github/202205) [Jing Zhang] sairedis: * 54642c7 2022-06-09 | [counter] Fix port flex counter (sonic-net#1052) (HEAD -> 202205, github/202205) [Junhua Zhai] * b7f5f92 2022-06-06 | [ci] Paralize azure pipeline (sonic-net#1054) [Shilong Liu] swss: * 77043fb 2022-06-09 | [fpmsyncd] don't manipulate route weight (sonic-net#2321) (HEAD -> 202205, github/202205) [Ying Xie] * ae157f1 2022-06-10 | Fix test_warm_reboot issues blocking PR merge (sonic-net#2309) (sonic-net#2318) [Shilong Liu] Signed-off-by: Ying Xie <ying.xie@microsoft.com>
vivekrnv
pushed a commit
to vivekrnv/sonic-buildimage
that referenced
this pull request
Aug 26, 2022
* Two fixes: sleep after stop and check values in routes
yxieca
added a commit
to yxieca/sonic-buildimage
that referenced
this pull request
Sep 1, 2022
utilities: * 5892f6d 2022-08-29 | [VRF]Adding CLI checks to ensure Vrf is valid in interface bind and static route commands (sonic-net#2333) (HEAD -> 202205) [Sudharsan Dhamal Gopalarathnam] * 87ec859 2022-08-30 | Subinterface vrf bind issue fix (sonic-net#2211) [Preetham] * edc0169 2022-08-16 | [decode-syseeprom] Fix setting use_db based on support_eeprom_db (sonic-net#2270) [byu343] * 1542e7a 2022-08-15 | Fix vrf UT failed issue (sonic-net#2309) [Hua Liu] swss: * 39f5cdf 2022-08-31 | [BFD]Clean up state_db BFD entries on swss restart (sonic-net#2434) (HEAD -> 202205) [Sudharsan Dhamal Gopalarathnam] * f4a6945 2022-08-30 | Fix the Fec Mode Setting of gbsyncd (sonic-net#2430) [abdosi] * 36e8092 2022-08-30 | [neighsyncd] Enabling ipv4 link local entries for non-dualtor (sonic-net#2427) [Nikola Dancejic] * a2bac7c 2022-08-26 | tlm_teamd: Filter portchannel subinterface events from STATE_DB LAG_TABLE (sonic-net#2408) [Preetham] * 8bb21be 2022-08-10 | PFCWD recovery changes using DLR_INIT (sonic-net#2316) [vmittal-msft] * 3e888b7 2022-08-29 | Dynamic port configuration - add port buffer cfg to the port ref counter (sonic-net#2194) [Dror Prital] Signed-off-by: Ying Xie <ying.xie@microsoft.com>
theasianpianist
added a commit
to theasianpianist/sonic-buildimage
that referenced
this pull request
Sep 2, 2022
Include following commits: 414e239 update unit tests for swap allocator a91a492 consider swap checking memory in installer f0ce586 [route_check]: Ignore standalone tunnel routes (sonic-net#2325) 3af8ba4 Replace cmp in acl_loader with operator.eq (sonic-net#2328) 899ba12 Subinterface vrf bind issue fix (sonic-net#2211) e45b47a [VRF]Adding CLI checks to ensure Vrf is valid in interface bind and static route commands (sonic-net#2333) f82835e [doc]: Add MACsec CLI doc (sonic-net#2334) 666bdc0 [sonic-package-manager] Drop 'expires_in' (sonic-net#2002) 52ac8ac Handle non-front-panel ports in is_rj45_port (sonic-net#2327) 42ed6d5 [service_mgmt]: Fix fetch MULTI_INST_DEPENDENT bug in service_mgmt.sh.j2 (sonic-net#2319) d1a2d72 correct an error by changing "show bgp summary" to "show bfd summary" (sonic-net#2324) 7d409a0 Update VRF unbind command (sonic-net#2331) e14f679 Fix issue: port_type is referenced before initialized (sonic-net#2323) 7704f63 Fix issue: exception in is_rj45_port in multi ASIC env (sonic-net#2313) 6fc4f15 Delete .DS_Store (sonic-net#2244) ece4049 Fix bug with checking VRF's routes in route_check.py (sonic-net#2301) 20c6d18 [decode-syseeprom] Fix setting use_db based on support_eeprom_db (sonic-net#2270) 9282e6c Fix vrf UT failed issue (sonic-net#2309) 37eb2b3 add lacp_rate to portchannel (sonic-net#2036) Signed-off-by: Lawrence Lee <lawlee@microsoft.com>
liat-grozovik
pushed a commit
that referenced
this pull request
Sep 4, 2022
Update sonic-utilities submodule pointer to include the following: Replace cmp in acl_loader with operator.eq (#2328) Subinterface vrf bind issue fix (#2211) [VRF]Adding CLI checks to ensure Vrf is valid in interface bind and static route commands (#2333) [doc]: Add MACsec CLI doc (#2334) [sonic-package-manager] Drop 'expires_in' (#2002) Handle non-front-panel ports in is_rj45_port (#2327) [service_mgmt]: Fix fetch MULTI_INST_DEPENDENT bug in service_mgmt.sh.j2 (#2319) correct an error by changing "show bgp summary" to "show bfd summary" (#2324) Update VRF unbind command (#2331) Fix issue: port_type is referenced before initialized (#2323) Fix issue: exception in is_rj45_port in multi ASIC env (#2313) Delete .DS_Store (#2244) Fix bug with checking VRF's routes in route_check.py (#2301) [decode-syseeprom] Fix setting use_db based on support_eeprom_db (#2270) Fix vrf UT failed issue (#2309) add lacp_rate to portchannel (#2036)
dprital
added a commit
to dprital/sonic-buildimage
that referenced
this pull request
Sep 7, 2022
Update sonic-utilities submodule pointer to include the following: * [route_check]: Ignore standalone tunnel routes (sonic-net#2325) ([sonic-net#2346](sonic-net/sonic-utilities#2346)) * [VRF]Adding CLI checks to ensure Vrf is valid in interface bind and static route commands ([sonic-net#2333](sonic-net/sonic-utilities#2333)) * Subinterface vrf bind issue fix ([sonic-net#2211](sonic-net/sonic-utilities#2211)) * [decode-syseeprom] Fix setting use_db based on support_eeprom_db ([sonic-net#2270](sonic-net/sonic-utilities#2270)) * Fix vrf UT failed issue ([sonic-net#2309](sonic-net/sonic-utilities#2309)) Signed-off-by: dprital <drorp@nvidia.com>
yxieca
pushed a commit
that referenced
this pull request
Sep 8, 2022
Update sonic-utilities submodule pointer to include the following: * [route_check]: Ignore standalone tunnel routes (#2325) ([#2346](sonic-net/sonic-utilities#2346)) * [VRF]Adding CLI checks to ensure Vrf is valid in interface bind and static route commands ([#2333](sonic-net/sonic-utilities#2333)) * Subinterface vrf bind issue fix ([#2211](sonic-net/sonic-utilities#2211)) * [decode-syseeprom] Fix setting use_db based on support_eeprom_db ([#2270](sonic-net/sonic-utilities#2270)) * Fix vrf UT failed issue ([#2309](sonic-net/sonic-utilities#2309)) Signed-off-by: dprital <drorp@nvidia.com> Signed-off-by: dprital <drorp@nvidia.com>
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In vs platform, eth[n] where n > 0 is physical port,
we should not send lldp over those ports
Signed-off-by: Guohan Lu gulv@microsoft.com
- What I did
- How I did it
- How to verify it
tested on vs kvm image on T0 topology.
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)