[teamd] avoid using actor port number 0 in teamd config #2327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lguohan
reviewed
Dec 1, 2018
lguohan
approved these changes
Dec 1, 2018
stcheng
approved these changes
Dec 1, 2018
|
nice fix! thanks! |
When using actor port number 0 in lag configuration, IO cannot be sent to peer. Increase actor port number by 1 to keep uniqueness and at the same time, avoid using actor port number 0. Ref. 802.1AX 6.3.4 Port identification Signed-off-by: Ying Xie <ying.xie@microsoft.com>
|
s/801/802/g |
judyjoseph
added a commit
that referenced
this pull request
Jun 20, 2022
sonic-swss 25fe915 [crmorch] Prevent exceededLogCounter from resetting when low and high values are equal (#2327) 1c3c5e0 [BFD]Retry create BFD with different source UDP port on failure (#2225) d5775b1 Skip consistent fail tests (#2269) sonicutilities 5800b73 Fix header for the output table following 'show ipv6 interface' command (#2219)
yxieca
added a commit
to yxieca/sonic-buildimage
that referenced
this pull request
Jun 20, 2022
utilities: * 789bfea 2022-06-16 | Fix header for the output table following 'show ipv6 interface' command (sonic-net#2219) (HEAD -> 202205, github/202205) [Dror Prital] * 5443b3c 2022-05-25 | [GCU] Handling type1 lists (sonic-net#2171) [Mohamed Ghoneim] swss: * 3fb23a1 2022-06-16 | [aclorch] Fix and simplify DTel watchlist tables and entries (sonic-net#2155) [Mickey Spiegel] * 9ace643 2022-06-16 | [intfmgr]: Set proxy_arp kernel param (sonic-net#2334) [Lawrence Lee] * 013609a 2022-06-14 | [crmorch] Prevent exceededLogCounter from resetting when low and high values are equal (sonic-net#2327) [Alexander Allen] * 83a1306 2022-06-13 | Fix key generation in removeDecapTunnel (sonic-net#2322) [Myron Sosyak] * 3d018ad 2022-06-15 | Apply `DSCP_TO_TC_MAP` from `PORT_QOS_MAP|global` to switch level (sonic-net#2314) [bingwang-ms] Signed-off-by: Ying Xie <ying.xie@microsoft.com>
yxieca
added a commit
to yxieca/sonic-buildimage
that referenced
this pull request
Jun 21, 2022
swss: * a3bfd96 2022-06-18 | Enhance mock test for dynamic buffer manager for port removing and qos reload flows (sonic-net#2262) (HEAD -> 202205, github/202205) [Stephen Sun] * b17d6c0 2022-05-28 | Support mock_test infra for dynamic buffer manager and fix issues found during mock test (sonic-net#2234) [Stephen Sun] * 3fb23a1 2022-06-16 | [aclorch] Fix and simplify DTel watchlist tables and entries (sonic-net#2155) [Mickey Spiegel] * 9ace643 2022-06-16 | [intfmgr]: Set proxy_arp kernel param (sonic-net#2334) [Lawrence Lee] * 013609a 2022-06-14 | [crmorch] Prevent exceededLogCounter from resetting when low and high values are equal (sonic-net#2327) [Alexander Allen] * 83a1306 2022-06-13 | Fix key generation in removeDecapTunnel (sonic-net#2322) [Myron Sosyak] * 3d018ad 2022-06-15 | Apply `DSCP_TO_TC_MAP` from `PORT_QOS_MAP|global` to switch level (sonic-net#2314) [bingwang-ms] Signed-off-by: Ying Xie <ying.xie@microsoft.com>
yxieca
added a commit
that referenced
this pull request
Jun 21, 2022
swss: * a3bfd96 2022-06-18 | Enhance mock test for dynamic buffer manager for port removing and qos reload flows (#2262) (HEAD -> 202205, github/202205) [Stephen Sun] * b17d6c0 2022-05-28 | Support mock_test infra for dynamic buffer manager and fix issues found during mock test (#2234) [Stephen Sun] * 3fb23a1 2022-06-16 | [aclorch] Fix and simplify DTel watchlist tables and entries (#2155) [Mickey Spiegel] * 9ace643 2022-06-16 | [intfmgr]: Set proxy_arp kernel param (#2334) [Lawrence Lee] * 013609a 2022-06-14 | [crmorch] Prevent exceededLogCounter from resetting when low and high values are equal (#2327) [Alexander Allen] * 83a1306 2022-06-13 | Fix key generation in removeDecapTunnel (#2322) [Myron Sosyak] * 3d018ad 2022-06-15 | Apply `DSCP_TO_TC_MAP` from `PORT_QOS_MAP|global` to switch level (#2314) [bingwang-ms] Signed-off-by: Ying Xie <ying.xie@microsoft.com>
vivekrnv
pushed a commit
to vivekrnv/sonic-buildimage
that referenced
this pull request
Aug 26, 2022
… values are equal (sonic-net#2327) * [crmorch] Prevent exceededLogCounter from resetting when low and high values are equal
yxieca
added a commit
to yxieca/sonic-buildimage
that referenced
this pull request
Aug 27, 2022
… advance submodule head linkmgrd: * 9a993b2 2022-08-23 | [active-active] Remove unnecessary mux wait timeout logs (sonic-net#122) (HEAD -> 202205) [Jing Zhang] utilities: * ec4b09f 2022-08-26 | Handle non-front-panel ports in is_rj45_port (sonic-net#2327) (HEAD -> 202205, github/202205) [Stephen Sun] * 4adf897 2022-08-20 | Fix issue: port_type is referenced before initialized (sonic-net#2323) [Stephen Sun] * 314bafd 2022-08-25 | [service_mgmt]: Fix fetch MULTI_INST_DEPENDENT bug in service_mgmt.sh.j2 (sonic-net#2319) [Ze Gan] * e0166a0 2022-08-25 | portconfig option to configure Tx power and laser frequency of ZR transceiver module (sonic-net#2197) (sonic-net#2330) [Prince George] swss-common: * af80c12 2022-06-30 | [select] break the select loop if interrupt_on_signal flag is set (sonic-net#624) (HEAD -> 202205, github/202205) [Stepan Blyshchak] sairedis: * a1796a5 2022-07-28 | Add support of mdio IPC server class using sai switch api and unix socket (sonic-net#1080) (HEAD -> 202205) [Jiahua Wang] platform-common: * c1ee4b1 2022-08-20 | [CMIS] Catch Exception to avoid CMIS code crash (sonic-net#299) (HEAD -> 202205) [Kebo Liu] * 638d225 2022-07-13 | Fix Cmis memmap field offset (sonic-net#290) [Prince George] Signed-off-by: Ying Xie <ying.xie@microsoft.com>
yxieca
added a commit
that referenced
this pull request
Aug 29, 2022
… advance submodule head (#11859) linkmgrd: * 9a993b2 2022-08-23 | [active-active] Remove unnecessary mux wait timeout logs (#122) (HEAD -> 202205) [Jing Zhang] utilities: * ec4b09f 2022-08-26 | Handle non-front-panel ports in is_rj45_port (#2327) (HEAD -> 202205, github/202205) [Stephen Sun] * 4adf897 2022-08-20 | Fix issue: port_type is referenced before initialized (#2323) [Stephen Sun] * 314bafd 2022-08-25 | [service_mgmt]: Fix fetch MULTI_INST_DEPENDENT bug in service_mgmt.sh.j2 (#2319) [Ze Gan] * e0166a0 2022-08-25 | portconfig option to configure Tx power and laser frequency of ZR transceiver module (#2197) (#2330) [Prince George] swss-common: * af80c12 2022-06-30 | [select] break the select loop if interrupt_on_signal flag is set (#624) (HEAD -> 202205, github/202205) [Stepan Blyshchak] sairedis: * a1796a5 2022-07-28 | Add support of mdio IPC server class using sai switch api and unix socket (#1080) (HEAD -> 202205) [Jiahua Wang] platform-common: * c1ee4b1 2022-08-20 | [CMIS] Catch Exception to avoid CMIS code crash (#299) (HEAD -> 202205) [Kebo Liu] * 638d225 2022-07-13 | Fix Cmis memmap field offset (#290) [Prince George] Signed-off-by: Ying Xie <ying.xie@microsoft.com> Signed-off-by: Ying Xie <ying.xie@microsoft.com>
theasianpianist
added a commit
to theasianpianist/sonic-buildimage
that referenced
this pull request
Sep 2, 2022
Include following commits: 414e239 update unit tests for swap allocator a91a492 consider swap checking memory in installer f0ce586 [route_check]: Ignore standalone tunnel routes (sonic-net#2325) 3af8ba4 Replace cmp in acl_loader with operator.eq (sonic-net#2328) 899ba12 Subinterface vrf bind issue fix (sonic-net#2211) e45b47a [VRF]Adding CLI checks to ensure Vrf is valid in interface bind and static route commands (sonic-net#2333) f82835e [doc]: Add MACsec CLI doc (sonic-net#2334) 666bdc0 [sonic-package-manager] Drop 'expires_in' (sonic-net#2002) 52ac8ac Handle non-front-panel ports in is_rj45_port (sonic-net#2327) 42ed6d5 [service_mgmt]: Fix fetch MULTI_INST_DEPENDENT bug in service_mgmt.sh.j2 (sonic-net#2319) d1a2d72 correct an error by changing "show bgp summary" to "show bfd summary" (sonic-net#2324) 7d409a0 Update VRF unbind command (sonic-net#2331) e14f679 Fix issue: port_type is referenced before initialized (sonic-net#2323) 7704f63 Fix issue: exception in is_rj45_port in multi ASIC env (sonic-net#2313) 6fc4f15 Delete .DS_Store (sonic-net#2244) ece4049 Fix bug with checking VRF's routes in route_check.py (sonic-net#2301) 20c6d18 [decode-syseeprom] Fix setting use_db based on support_eeprom_db (sonic-net#2270) 9282e6c Fix vrf UT failed issue (sonic-net#2309) 37eb2b3 add lacp_rate to portchannel (sonic-net#2036) Signed-off-by: Lawrence Lee <lawlee@microsoft.com>
liat-grozovik
pushed a commit
that referenced
this pull request
Sep 4, 2022
Update sonic-utilities submodule pointer to include the following: Replace cmp in acl_loader with operator.eq (#2328) Subinterface vrf bind issue fix (#2211) [VRF]Adding CLI checks to ensure Vrf is valid in interface bind and static route commands (#2333) [doc]: Add MACsec CLI doc (#2334) [sonic-package-manager] Drop 'expires_in' (#2002) Handle non-front-panel ports in is_rj45_port (#2327) [service_mgmt]: Fix fetch MULTI_INST_DEPENDENT bug in service_mgmt.sh.j2 (#2319) correct an error by changing "show bgp summary" to "show bfd summary" (#2324) Update VRF unbind command (#2331) Fix issue: port_type is referenced before initialized (#2323) Fix issue: exception in is_rj45_port in multi ASIC env (#2313) Delete .DS_Store (#2244) Fix bug with checking VRF's routes in route_check.py (#2301) [decode-syseeprom] Fix setting use_db based on support_eeprom_db (#2270) Fix vrf UT failed issue (#2309) add lacp_rate to portchannel (#2036)
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
When using actor port number 0 in lag configuration, IO cannot be sent to
peer. Increase actor port number by 1 to keep uniqueness and at the same
time, avoid using actor port number 0.
Ref. 802.1AX 6.3.4 Port identification
Signed-off-by: Ying Xie ying.xie@microsoft.com
- How to verify it
Boot up on a dut where Ethernet0 is part of a lag. Making sure that the LAG is up and the BGP session on top of this LAG is also up.