Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vortex & MO2 Not Handling NXM Links #637

Closed
SentaiBrad opened this issue Oct 24, 2022 · 70 comments · Fixed by #756
Closed

Vortex & MO2 Not Handling NXM Links #637

SentaiBrad opened this issue Oct 24, 2022 · 70 comments · Fixed by #756
Labels
bug Something isn't working ModOrganizer 2 Issues related to installing or using ModOrganizer 2 with SteamTinkerLaunch Vortex Mod Manager Issues related to installing or using Vortex Mod Manager with SteamTinkerLaunch

Comments

@SentaiBrad
Copy link

SentaiBrad commented Oct 24, 2022

System Information

  • SteamTinkerLaunch version: Latest GIT
  • Distribution: SteamOS
  • Installation Method: ProtonUp-Qt

Issue Description

This is a combination of one issue, that the wiki says STL solves, but for me, it does not. But to be clear, the bug inherently lies in the fact that Vortex is running through a Wine layer.

I had to re-read the Wiki a few times to make sure I wasn't crazy, so this MIGHT be a bug with STL also.

"create and update the nxm-protocol mime type for directly opening NXM with Vortex (renaming that from Mod-Organizer 2 when found)"

When Vortex launched for me the first time, there was an error and it closed. I opened it again, and Vortex asked me if I wanted to "repair" the installation, and I did. It asked me if I wanted to set Vortex to open NXM links, and I did. However, when clicking on "Download with Manager" on Nexus, Firefox prompted me to pick an application and nothing more. Nothing Vortex or STL related was selectable.

I have been helping a friend, trying to get Vortex up and running so they can use the Collections feature, but even for them clicking the "Download with Manager" button did nothing. They are also using a Steam Deck with ProtonUp-Qt, and never reported errors for their install, but I will focus on mine for this report. I just wanted to make sure to note this, as this is why I started testing for it.

As for solving the issue: I presume that STL is running a script (like the other vortex and mo2 installers) to enable the NXM link manually. Assuming that the above bug report is valid, but the issue is not in relation to this script and the script works, it's more of a Feature Request to get this added to the GUI so that a user can have the script re-apply the NXM link. However, I am unaware if this is an issue with the script, or that it just needs to be run again, so I will Bug Report it just in case.

Also worth noting: In one MO2 testing instance for me (before STL), providing my API key manually worked flawlessly. For Vortex, we're not given an API key option as it's a tool by Nexus, for Nexus. They prompt users to log in to check things like Premium, endorse files, etc. Unsure if they store the API key locally, but they provide no way for the user to input this via the GUI. If they do store the API locally, it might be feasible to add an option to the STL GUI for a user to copy and paste their Nexus API key for it to be inserted manually by STL into Vortex. That is a passing thought though, I have not dug in far enough to see if they store it at all, or purely just use the login method dynamically.

Side note: on triple checking my information and Launching Vortex again, it looks like it KEEPS asking me to repair the installation. Unsure if this is because of the Wine Layer and if I can Ignore it, or if I need to repair it. "Repairing" the installation might be why the NXM link no longer works.

image

Logs

The only .log I have in the "dev/shm/steamtinkerlaunch/steamtinkerlaunch" path is winres.log. Says this twice:

Sun Oct 23 05:00:50 PM PDT 2022 INFO - pollWinRes - Using GEOM '--geometry=1280x800+0+0' from '/home/deck/.config/steamtinkerlaunch/guicfgs/1280x800/22320/SteamTinkerLaunch-PrepareVortexGameStatus.conf'

@SentaiBrad SentaiBrad added the bug Something isn't working label Oct 24, 2022
@sonic2kk
Copy link
Owner

I'm not sure why Vortex isn't working but as far as I know it has been barely tested on Steam Deck. There is currently an open, pinned issue discussing Vortex-related problems. You should have a look through that issue and see if there's anything that answers the problems you are having.

I don't use Vortex personally, sorry, but the NXM link handling should be working, but it might not be working on Steam Deck. I'm not totally sure, you might want to ask in the dedicated Vortex issue to bring more attention to it.

@sonic2kk
Copy link
Owner

One thing I will mention is, NXM link handling might not be working if you're launching Vortex from the Main Menu extra button, or from the command line with steamtinkerlaunch vortex start.

If Vortex has a "GUI" wait requester mode like MO2 does, you might have to use that to get link handling to work.

But again, reading through and asking on the Vortex issue might give you some more hints. The Vortex side of things is one of the areas of STL I've touched the least.

@sonic2kk
Copy link
Owner

From skimming the more recent comments in the Vortex issue it seems like there might be some improvements needed.

Not sure when I'll get time or motivation to look into this as I am very inexperienced in this area, but contributions would be welcome to improve Vortex support

@sonic2kk sonic2kk added Vortex Mod Manager Issues related to installing or using Vortex Mod Manager with SteamTinkerLaunch help wanted Features/Bug Fixes that welcome contributions labels Oct 24, 2022
@SentaiBrad SentaiBrad changed the title Vortex NXM Not Functioning (?) Vortex NXM Not Functioning (?) Edit: And now MO2 Oct 24, 2022
@SentaiBrad
Copy link
Author

While doing some testing for issues #638 #635 #639 the "Download with Manager" option on Nexus, in Firefox, does nothing for either manager.

@sonic2kk
Copy link
Owner

sonic2kk commented Oct 24, 2022

For MO2, are you running in MO2 Game Mode (pressing the STL "Play" button) or Standalone Mode (Main Menu button)? If you're running MO2 in Standalone Mode, this is known behaviour and is fixed I believe in the MO2 rewrite branch which was created by Frostworx. I haven't looked much into that branch, but I know it has some improvements for MO2.

However if MO2 isn't working for you in Game Mode, there might be a problem here...

@SentaiBrad
Copy link
Author

For MO2, are you running in MO2 Game Mode (pressing the STL "Play" button) or Standalone Mode (Main Menu button)? If you're running MO2 in Standalone Mode, this is known behaviour and is fixed I believe in the MO2 rewrite branch which was created by Frostworx. I haven't looked much into that branch, but I know it has some improvements for MO2.

However if MO2 isn't working for you in Game Mode, there might be a problem here...

MO2 and Vortex overall work except for loading mods from Nexus. MO2 WAS working when I originally made this thread and was testing Vortex. I put my API in manually as it wouldn't launch to log me in. Sometime later, I{ was downloading a patch and it didn't work anymore. Launching Nexus to log me in work, but downloads still didn't. Cleared this, and re-entered API no go.

I just wrote all that to also again realize, this is still most likely nothing STL can solve lmao. I only lean that way cause it did at one point. I saw that re-write mentioned. I am excited.

@sonic2kk
Copy link
Owner

sonic2kk commented Oct 24, 2022

How are you launching MO2 though? Are you doing it through MO2 Game Mode or Standalone Mode? If you aren't sure what this means, refer to the MO2 wiki page for more detail.

If you're launching from Standalone Mode, then it is expected that MO2 won't work when downloading from Nexus. For Vortex, I honestly don't know unfortunately.

@SentaiBrad
Copy link
Author

GameMode. I click play on New Vegas, go through the first GUI, wait for the "Start MO2" or "No MO2", click Start MO2 and it launches from there.

@sonic2kk
Copy link
Owner

Hmm, I'm not sure why it has stopped working then to be honest. It's worked for me in the past and as mentioned it worked for you as well. Maybe restart your Steam Deck?

@SentaiBrad
Copy link
Author

Hmm, I'm not sure why it has stopped working then to be honest. It's worked for me in the past and as mentioned it worked for you as well. Maybe restart your Steam Deck?

I have. But, its not the end of the world for me. A very easy workaround is to just download the file manually and download it to (or copy it to) the MO2 downloads folder. MO2 see's it right away.

@sonic2kk
Copy link
Owner

A very easy workaround is to just download the file manually

Yes, this is also my preferred method of installing mods, generally, especially larger modpacks.

But aside from that, the button should still be working and I am not totally sure why it would be broken. I'm not sure how to debug further if it just randomly stopped working.

You could check the steps outlined in this section of the MO2 page, but I am not sure how much luck you'll have - I think in one reported case this worked, but I also equally think I remember a case where this did not resolve it (though I think for the latter case, the user wasn't using MO2 Game Mode).

@SentaiBrad
Copy link
Author

A very easy workaround is to just download the file manually

Yes, this is also my preferred method of installing mods, generally, especially larger modpacks.

But aside from that, the button should still be working and I am not totally sure why it would be broken. I'm not sure how to debug further if it just randomly stopped working.

You could check the steps outlined in this section of the MO2 page, but I am not sure how much luck you'll have - I think in one reported case this worked, but I also equally think I remember a case where this did not resolve it (though I think for the latter case, the user wasn't using MO2 Game Mode).

Frankly, if Linux Gaming is going to get a big push, we need native tools. But hey, I can dream :D

Super excited for the re-write.

@sonic2kk
Copy link
Owner

Frankly, if Linux Gaming is going to get a big push, we need native tools. But hey, I can dream :D

I'm right there with you, and Vortex Mod Manager may have a non-zero chance of getting a native port in the future (totally external to STL). But there are questions around how it will integrate with Wine/Proton and other related questions, if it happens at all.

But STL does its best to bridge the gap. The NXM link handler has been a bit of a pain-point recently with a couple of issues, but I believe they were resolved in the rewrite(?). There was some talk about a similar solution being implemented for Vortex.

The MO2 branch changes are pending further testing (I wouldn't recommend testing stuff like this on Deck, I would do it on a PC if possible). ProtonUp-Qt's STL-Git download lets you choose a branch (untested on Deck, recommended to do this on PC) so you could install and test the rewrite branch and give feedback at #598.

cc @frostworx since he is the one that made those changes, and iirc they are just pending further testing and possibly some conflict cleanup :-)

@SentaiBrad
Copy link
Author

SentaiBrad commented Oct 24, 2022

so you could install and test the rewrite branch and give feedback at #598.

cc @frostworx since he is the one that made those changes, and iirc they are just pending further testing and possibly some conflict cleanup :-)

Did someone say testing... my ears were burning.

@SentaiBrad
Copy link
Author

SentaiBrad commented Oct 24, 2022

The MO2 branch changes are pending further testing (I wouldn't recommend testing stuff like this on Deck, I would do it on a PC if possible). ProtonUp-Qt's STL-Git download lets you choose a branch (untested on Deck, recommended to do this on PC) so you could install and test the rewrite branch and give feedback at #598.

Excuse the noobiness, but I don't see any Git info for STL in ProtonUp.

image

image

The bottom picture just scrolls to progressively older versions.

@sonic2kk
Copy link
Owner

sonic2kk commented Oct 24, 2022

Excuse the noobiness, but I don't see any Git info for STL in ProtonUp.

Ah, you need to enable I think it's called "Advanced Mode" it in the "About" section - It enables Git versions of some tools including SteamTinkerLaunch

Also, if you do end up testing:

  1. Unless you're very brave you might want to avoid doing it on Steam Deck
  2. Backwards compatibility with existing mod installations is not guaranteed, but I think it should maybe work okay (it'll be merged soon-ish hopefully so we need to find out eventually if it does break existing installs)
  3. Feedback should be given in ⚠ MO2 - Mod Organizer 2 overhaul discussion  #598 :-)

@SentaiBrad
Copy link
Author

Excuse the noobiness, but I don't see any Git info for STL in ProtonUp.

Ah, you need to enable I think it's called "Advanced Mode" it in the "About" section - It enables Git versions of some tools including SteamTinkerLaunch

Also, if you do end up testing:

1. Unless you're very brave you might want to avoid doing it on Steam Deck

2. Backwards compatibility with existing mod installations is not guaranteed, _but_ I think it should maybe work okay (it'll be merged soon-ish hopefully so we need to find out eventually if it does break existing installs)

3. Feedback should be given in [⚠ MO2 - Mod Organizer 2 overhaul discussion  #598](https://github.com/sonic2kk/steamtinkerlaunch/issues/598) :-)

I don't want to get the Laptop out right now. ProtonUp-Qt is still getting stuck at 99% though.

@sonic2kk
Copy link
Owner

sonic2kk commented Oct 24, 2022

I'm not sure why ProtonUp-Qt is hanging, but it'll be investigated as part of the work being done to improve the STL install experience with ProtonUp-Qt (and some improvements around how it handles dialogs). Might be fixed in the current git of ProtonUp-Qt and those changes just haven't made their way into an AppImage/Flatpak.

I don't want to get the Laptop out right now.

Very fair, I do STL dev work on my Deck so I can hardly talk, but that is my "disclaimer" out of the way 😅

@sonic2kk sonic2kk changed the title Vortex NXM Not Functioning (?) Edit: And now MO2 Vortex & MO2 Not Handling NXM Links Oct 24, 2022
@SentaiBrad
Copy link
Author

What....?

image

Also, when I look at the script for installing STL, I clearly see:
PROGVERS="v11.12.20221024-5"

But once it's installed
image

@sonic2kk
Copy link
Owner

I'm not sure what the problem is here.

The correct command to clone a new repository is to pass it the URL, e.g. git clone https://github.com/sonic2kk/steamtinkerlaunch.git

I'm not sure what's going on with the last command but that version is very old. I'm not sure what is going on here exactly.

@SentaiBrad
Copy link
Author

I'm not sure what the problem is here.

The correct command to clone a new repository is to pass it the URL, e.g. git clone https://github.com/sonic2kk/steamtinkerlaunch.git

I'm not sure what's going on with the last command but that version is very old. I'm not sure what is going on here exactly.

I was super out of it, getting no sleep over last night, so Ignore me there. I'll test when I am able here in a bit.

@sonic2kk
Copy link
Owner

Heh, I know the realm of sleep deprivation all too well so no worries :-) No rush!

@frostworx
Copy link
Collaborator

no need to cc me, as I'm still auto-subscribed to most issues.
I simply don't have much time to even read all the incoming mails :)
iirc the nxm handler rewrite worked fine for me both for vortex and mo2, and I was expecting some people to actually test it, because I do not use any of them.
Feedback was low, so I did all later mod unrelated changes in that branch as well to avoid having to waste even more time into that by merging everything later.
Maybe some people contribute something to the still open issues, else merging the corresponding changes from the branch (manually) and let new logs come in might be the easiest approach for the current situation.
I won't find any time to work on this (one of the reasons I gave the project away) and to be honest, I would not even find the motivation anymore until I'm not interested in the feature personally (another reason I gave the project away)

@sonic2kk
Copy link
Owner

No problem, sorry for the ping. I just didn't want to potentially be talking nonsense about the mo2-overhaul branch :-)

Maybe some people contribute something to the still open issues, else merging the corresponding changes from the branch (manually) and let new logs come in might be the easiest approach for the current situation.

I would agree. I'm hoping we can get more people to test it and I'm planning to test the branch with my existing mod installs soon-ish, just once I have a bit more free time from work to spend a long weekend testing and troubleshooting.

Just wondering, aside from potential conflicts and assuming it is mostly bug-free, is there anything outstanding you wanted to/want to add before a merge? It'll probably be a couple of weeks at least but I'm just trying to get an idea of how "merge ready" it is. So basically outside of testing, is there anything holding it back from being merged?

Thanks for responding either way, and like I saw in a few other issues you are always welcome to chip in whenever you have time 🙂

@sonic2kk
Copy link
Owner

Boy, this issue really seems to be intermittent. I honestly don't know why it's so temperamental. It just wants to make a liar out of all of us 😅

I wonder if it's anything to do with the NoDisplay and/or Hidden sections of the .desktop file. I had a theory before that this made a difference on some systems but I don't remember the details of what i was thinking back then.

One day we'll get to the bottom of this! Unfortunately that day is not today...

@har-nick
Copy link

har-nick commented Feb 12, 2023

Hidden has an effect, as the spec lists it as the equivalent of "deleting" the desktop file. I tested it set to True and nothing happened when starting a download. Setting it to False made it work as expected.

If the created desktop file is identical to the one in the MO2 wiki, which doesn't have a Hidden value set, I could see a distro assuming a value for it, but I doubt that's the issue, since it's affected myself regardless of having that value set.

@sonic2kk
Copy link
Owner

sonic2kk commented Feb 13, 2023

It would be interesting to see some tests between having various different combinations of true and false for the HiddenandNoDisplaykeys. Iwonder if some combination of these, or if simply specifyingHidden=false` can fix the issue. I would be especially curious about this on Steam Deck, however I generally don't mod on my Steam Deck (I've already filled about 80% of my 512GB drive and my two 512gb microSD cards 😅) so I can't test this personally.

You may be onto something for sure with the Hidden field in the .desktop file. I will test on my desktop when I have a chance with Hidden=false in the .desktop file as well. If testing goes well, we could experimentally write out Hidden=false to the .desktop file on its creation as my file doesn't have it at least and I don't think it's specified in the code. Updating this could be an issue though, perhaps there is a command to re-create the .desktop files.

Following this, the MO2 wiki could have its .desktop file examples updated as well :-) It should probably also be updated for local installs / Steam Deck installs, since the /usr/bin/steamtinkerlaunch path is not valid for every install.

@har-nick
Copy link

If I remember rightly, NoDisplay simply stops it appearing in the "Choose a desktop file to handle this link" menu that's given to you. You'd use it in conjunction with Firefox's Application menu to set a default desktop file handler and never see it again.

@BrandonKingM
Copy link

Personally I've been using the built in mod browser extension for the past year on Steam Deck. You can't download mods outside Nexus Mods, and you'll need to download mods you have to install manually outside this browser because it automatically downloads all regardless of what it is through Vortex but it's worked for me. I hope this issue does get solved though because I'd love to once again be able to open tabs when redownloading my mod history instead of the page refreshing to page 1 after each and every mod since this extension doesn't have tabs.

https://www.nexusmods.com/site/mods/88

@BrandonKingM
Copy link

BrandonKingM commented Feb 18, 2023

``
NoDisplay=false
Hidden=true

I just had it work for the first time I've ever tried it, having Chrome start a mod download to Vortex on my Steam Deck. I set these to

NoDisplay=false
Hidden=false

The only issue I'm having is more just a small annoyance rather than a real issue, it claims that Vortex is the default program to open them, but every so often I click on open in Vortex i have to reselect it in the menu

@sonic2kk
Copy link
Owner

Wow! Okay, that is excellent news! In the near-ish future I will experimentally implement writing this out to the .desktop file on a branch and specifically request testing. I would like to see testing from other users across browsers, distros and on Steam Deck. I will also test myself with these fields before opening a branch to make sure it still works for me, which I would expect it to :-)

Great progress here @har-nick and @BrandonKingM, thank you very much!!

but every so often I click on open in Vortex i have to reselect it in the menu

Does your mod download work after this though? Having to re-select is a slight annoyance but it could just be a browser quirk. I think we could live with this, probably :-)

sonic2kk added a commit that referenced this issue Feb 19, 2023
Set 'NoDisplay' to 'false'
Add 'Hidden' attribute and set it to 'false'

This may improve/fix link handling, mainly for MO2 and Vortex, following discussion in #637.

Untested for now.
@sonic2kk
Copy link
Owner

sonic2kk commented Feb 19, 2023

I created a new branch, a-link-to-the-past, in which I updated the .desktop file generation for MO2 and Vortex (and HMM) to have the following lines:

NoDisplay=false
Hidden=false

On master we have NoDisplay=true, and Hidden is entirely unspecified. If you install this branch of STL (ProtonUp-Qt with Advanced Mode enabled allows you to do this by installing STL-git and changing the branch) and then rename your existing MO2/Vortex .desktop file, it should re-create the next time you open the program.

Please feel free to test, anyone reading this issue, and report the behaviour. I have not tested yet but if this works as expected for a good portion of users who test, and if it does not break existing behaviour, I will be very happy and will look into merging.

One concern that I have is that this will cause Vortex/MO2 .desktop files (which are only for link handling) to show up in the Application Menu, which it absolutely not correct.

@har-nick
Copy link

har-nick commented Feb 19, 2023

Now I can't test this branch since I have Flatpak, but I've replicated the .desktop file to the same spec.

Fingers crossed this is the fix!

One concern that I have is that this will cause Vortex/MO2 .desktop files (which are only for link handling) to show up in the Application Menu, which it absolutely not correct.

With NoDisplay=false, that's unfortunately what happens. As mentioned, I doubt that NoDisplay is the cause of this bug, but if it is, having an extra desktop entry in your XDG prompt is a tiny price to pay.

@cplr
Copy link

cplr commented Mar 3, 2023

I tried the a-link-to-the-past branch, and can confirm I was able to open NXM links using Firefox (flatpak) on SteamOS 3.4 👍

I had some weird hiccups where it would start the download, it would finish but then it would be "cancelled", and I would have to attempt a download again. And I also had to manually select the icon-less SteamTinkerLaunch from the list of "apps" to open the link, but after a few times that stopped popping up and it "just worked". Thanks!

edit: on Steam Deck is it recommended that you install MO2 as a Portable Instance or a Global Instance? Does it matter?

@sonic2kk
Copy link
Owner

sonic2kk commented Mar 4, 2023

Thank you for testing @cplr !! That is great news!

Is there an entry for MO2 in the application list? By default this is the Deck icon in the bottom left that lets you browse installed applications.

I had some weird hiccups where it would start the download, it would finish but then it would be "cancelled", and I would have to attempt a download again. And I also had to manually select the icon-less SteamTinkerLaunch from the list of "apps" to open the link, but after a few times that stopped popping up and it "just worked". Thanks!

This is very strange, especially selecting the icon. This should not happen but it seems to happen on some perhaps weirdly configured distributions. I have never once been asked which application to use to handle links by my browser, but even in general this happens on SteamOS and I've heard reports that it happens on Pop!_OS. So it could be a configuration thing 🤷‍♀️ I know the dialog you're referring to, but I have never seen it on any of my systems in the last ~5 years of using Linux for gaming.

The downloading issue is probably some network/wine weirdness, if it gets to downloading in MO2 then it isn't a SteamTinkerLaunch issue as far as I'm concerned and is likely related to Wine. Annoying, for sure, but not something that can be resolved from my side :-)

on Steam Deck is it recommended that you install MO2 as a Portable Instance or a Global Instance? Does it matter?

There was some discussion previously that portable instances require more work. I don't think I've ever (at least intentionally) used a portable instance, I just use whatever the default is on PC (I don't mod games on Steam Deck where I can help it). For discussion on portable instances see #751 and this comment (#692 (comment)) discussing portable instances, though both of those may only apply to using the microSD card.

To me, and based on my understanding, global instances sound like they make the most sense to use, so I would stick with those no matter if you're using MO2 on Windows, Linux Desktop or Steam Deck. That's just my take though, I'm not a MO2 power user and input (and if necessary, feature implementations) will need to come from more experienced MO2 users to give a better answer I'm afraid.


I will do some testing on my own Linux Desktop, and hopefully this issue can get some feedback from other Linux Desktop users, basically to give some confidence that this will be a go-forward solution. If updating these .desktop files works this should fix link handling for MO2, Vortex and HMM, which would be great. Given that you also had to select MO2 to handle links from your browser, I think that this strange dialog is what's causing the issues for users here: The browser, for some reason, expects to prompt users for which application to use, when really this shouldn't be the case and isn't the case outside of a handful of distros that unfortunately happens to include SteamOS.

As for the initial opening issue, where links did work but then stopped, I have no ideas on why that would've happened. But if the solution is as straightforward as what we've come up with here, hopefully this can be merged in the near-ish future. I'm hoping to roll a 12.12 release sometime in the near future and I'd like this to be one of the fixes in place.

@sonic2kk
Copy link
Owner

sonic2kk commented Mar 4, 2023

I put the branch up in a draft PR. I'll do some quick testing on my machines, and wait for further user testing. Hopefully it won't take too long to get more feedback. Once I'm confident it works for me and the users that tested I'll merge.

This issue has been open for a long time so I don't expect OP to respond, so I'll close this issue once merged. Usually I'd wait for OP's response if an isn't overly stale but this turned into more of a discussion around a solution than anything else so I think it's ok to close.

@SentaiBrad you're still welcome to test and give feedback of course but no worries either way, this issue is over 4 months old at this point 😅

@sonic2kk sonic2kk removed the help wanted Features/Bug Fixes that welcome contributions label Mar 4, 2023
@sonic2kk sonic2kk linked a pull request Mar 4, 2023 that will close this issue
4 tasks
@har-nick
Copy link

har-nick commented Mar 5, 2023

@cplr

I had some weird hiccups where it would start the download, it would finish but then it would be "cancelled"

Thankfully (or not), that's an MO2 issue. Have had it for years on Windows and Linux. Just delete your downloaded mod and redownload. Sometimes it'll also get stuck in the downloading phase, requiring you to cancel, delete, and redownload.

And I also had to manually select the icon-less SteamTinkerLaunch from the list of "apps" to open the link, but after a few times that stopped popping up and it "just worked".

Sounds like your browser didn't have a default handler set. Can't say why it didn't set it to the default or why it's only done it now.

@sonic2kk While I'm not on MO2 very often, I can also confirm I've had zero issues since creating a new Desktop file.

@cplr
Copy link

cplr commented Mar 5, 2023

Yeah, I mentioned that downloading issue more out of curiosity if others were seeing it. Definitely felt like a MO2 bug, and sounds like it is :).

Looking forward to this being on a main release! Is there a good way to upgrade to the regular train in Proton-Up-Qt or do you just remove the old and install the new?

@sonic2kk
Copy link
Owner

sonic2kk commented Mar 5, 2023

Thanks for all the feedback everyone!

Is there a good way to upgrade to the regular train in Proton-Up-Qt or do you just remove the old and install the new?

Could you explain what you mean @cplr ? If you mean how to update when this is merged into master, you can just install SteamTinkerLaunch-git. If you mean once it's in a release (e.g. 12.12 or something when it eventually comes out) just updating will suffice there as well, you can install from ProtonUp-Qt using the regular package.

@BrandonKingM I think something happened and the message didn't come through

@sonic2kk
Copy link
Owner

sonic2kk commented Mar 5, 2023

I should also point out that the branch has had some updates, if anyone is free to re-test that downloading links works I'd appreciate it! You can just rename your existing .desktop files likely located under ~/.local/share/applications, and then run MO2/Vortex using the same branch a-link-to-the-past (branch naming is fun sometimes 😉).

I made the following major changes yesterday:

  • There is now an icon for the .desktop files, just the STL icon. This should make it identifiable if prompted for which application to use
  • A warning dialog appears if you try to launch the .desktop file from the application menu, but this should not happen if you try to download a mod normally (it should only appear when the argument to the URL downloading function is blank, i.e. when -z "$1" is true). The dialog is to tell people that this is not the intended way to launch MO2, etc
  • The category for the entry should have changed to hopefully keep it out of sight a little bit

If all still works as expected then I'll probably merge this in when I have a chance in the next few days. It works on my machine but of course I didn't have this issue to begin with 😅 So testing from the community is always appreciated.

Thanks to everyone who helped Investigate and test, this issue would not have made any progress had it not been for your assistance here and I'll be sure to note this in the changelog.

@cplr
Copy link

cplr commented Mar 5, 2023

I tried a fresh install of STL with the latest updates to the branch and everything is still working in top condition.

@sonic2kk
Copy link
Owner

sonic2kk commented Mar 5, 2023

Woo! Seems like my Sunday just got a lot better 😅 I will wait for more feedback but I am fairly confident in it now. I may make a couple of very minor adjustments over the next day or so but it should be merged in soon.

Once this is merged to master I'll add a note here. Providing there are no bug reports after merging that require reverting the merge this will also go into the next release, no ETA on when that is, I really just release when I feel like there are enough good fixes to go. Probably early next month I would say but no guarantees 😉

Thank you again for testing, it seems the fix was fairly straightforward all along!

@sonic2kk sonic2kk reopened this Mar 6, 2023
@sonic2kk
Copy link
Owner

sonic2kk commented Mar 6, 2023

Decided to live life on the edge and merge it anyway, and then get feedback and resolve it afterwards. The changes from the branch are now in master!

Based on the positive feedback here from the branch, things should still be working fine now. Please feel free to re-test if you'd like 😄

I will leave this issue open for a little bit, but if no other problems crop up I will close it sometime in the future.

Thanks everyone!

@BrandonKingM
Copy link

@BrandonKingM I think something happened and the message didn't come through

I deleted it, must have been a misclick. I never use my email browser for things except to open it up in Chrome

@sonic2kk
Copy link
Owner

Seems resolved, closing :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ModOrganizer 2 Issues related to installing or using ModOrganizer 2 with SteamTinkerLaunch Vortex Mod Manager Issues related to installing or using Vortex Mod Manager with SteamTinkerLaunch
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants