-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modding: Update .desktop file generation #756
Conversation
Set 'NoDisplay' to 'false' Add 'Hidden' attribute and set it to 'false' This may improve/fix link handling, mainly for MO2 and Vortex, following discussion in #637. Untested for now.
As suspected this creates a XDG menu entry. Probably for MO2 and Vortex we could just
|
Pushed a change that shows an error dialog if More testing is needed here to ensure that this PR is ready, I want to ensure there are no regressions. But this seems like it will at least massively help with the MO2/Vortex link downloading support, so I am hoping this will require minimal extra work.
|
Set categories to Utilities Set icon to STL icon, hopefully discouraging use but making them easy to identify in browser application handlers.
Icon has been set to the STL icon as a compromise, as Vortex at least doesn't seem to come with an icon. Using the STL icon will also hopefully make it identifiable in the browser application menu thing, while also discouraging use from the application menu. As well as this, the category has been changed from "Games" to "Utilities". Hopefully this also makes it clearer that these files are not to be used. |
Might also be an idea to add/update the comments for these .desktop files to further emphasise that they should not be used. |
Merge conflicts... |
This may improve/fix link handling, mainly for MO2 and Vortex, following discussion in #637. May also help HMM support. It makes the following changes to the
.desktop
files for each:NoDisplay=false
Hidden=false
.desktop
files may need to be re-created. We could probably add a command to re-generate them, somethingsteamtinkerlaunch mo2 <something>
(not sure what the command name should be just yet).Looking at the code it seems there may be some logic to check if the files are up-to-date already, but adding the option would do no harm imo :-)
If all goes to plan this will go into the next release.
TODO:
.desktop
entry appears in application list