fs: fix missing file name with withFileTypes option of readdir

The issue was caused by a modification in PR nodejs#51021, which included changes
to the documentation for parentPath and modifications to display the filepath.
I have retained the content related to the documentation and removed the
filepath part.

Fixes: nodejs#52441
Co-authored-by: injae-kim <injae-kim@users.noreply.github.com>

lib/internal/fs/dir.js

@@ -155,7 +155,6 @@ class Dir {
  path,
  result[i],
  result[i + 1],
- true, // Quirk to not introduce a breaking change.
  ),
  );
  }

lib/internal/fs/utils.js

@@ -161,10 +161,10 @@ function assertEncoding(encoding) {
 }
 
 class Dirent {
- constructor(name, type, path, filepath = path && join(path, name)) {
+ constructor(name, type, path) {
  this.name = name;
  this.parentPath = path;
- this.path = filepath;
+ this.path = path;
  this[kType] = type;
  }
 
@@ -198,8 +198,8 @@ class Dirent {
 }
 
 class DirentFromStats extends Dirent {
- constructor(name, stats, path, filepath) {
- super(name, null, path, filepath);
+ constructor(name, stats, path) {
+ super(name, null, path);
  this[kStats] = stats;
  }
 }
@@ -269,7 +269,7 @@ function getDirents(path, { 0: names, 1: types }, callback) {
  callback(err);
  return;
  }
- names[idx] = new DirentFromStats(name, stats, path, filepath);
+ names[idx] = new DirentFromStats(name, stats, path);
  if (--toFinish === 0) {
  callback(null, names);
  }
@@ -305,21 +305,17 @@ function getDirent(path, name, type, callback) {
  callback(err);
  return;
  }
- callback(null, new DirentFromStats(name, stats, path, filepath));
+ callback(null, new DirentFromStats(name, stats, path));
  });
  } else {
  callback(null, new Dirent(name, type, path));
  }
  } else if (type === UV_DIRENT_UNKNOWN) {
  const filepath = join(path, name);
  const stats = lazyLoadFs().lstatSync(filepath);
- // callback === true: Quirk to not introduce a breaking change.
- return new DirentFromStats(name, stats, path, callback === true ? filepath : path);
- } else if (callback === true) {
- // callback === true: Quirk to not introduce a breaking change.
- return new Dirent(name, type, path);
+ return new DirentFromStats(name, stats, path);
  } else {
- return new Dirent(name, type, path, path);
+ return new Dirent(name, type, path);
  }
 }
 

test/parallel/test-fs-opendir.js

@@ -51,7 +51,7 @@ const invalidCallbackObj = {
  return { name: dirent.name, path: dirent.path, parentPath: dirent.parentPath, toString() { return dirent.name; } };
  }).sort();
  assert.deepStrictEqual(entries.map((d) => d.name), files);
- assert.deepStrictEqual(entries.map((d) => d.path), files.map((name) => path.join(testDir, name)));
+ assert.deepStrictEqual(entries.map((d) => d.path), Array(entries.length).fill(testDir));
  assert.deepStrictEqual(entries.map((d) => d.parentPath), Array(entries.length).fill(testDir));
 
  // dir.read should return null when no more entries exist