Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v18.x backport] fs: introduce dirent.parentPath #51021

Closed

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Dec 2, 2023

The goal is to replace dirent.path using a name that's less likely to create confusion.
dirent.path value has not been stable, moving it to a different property name should avoid breaking some upgrading user expectations.

PR-URL: #50976
Reviewed-By: Ethan Arrowood ethan@arrowood.dev
Reviewed-By: LiviaMedeiros livia@cirno.name

The goal is to replace `dirent.path` using a name that's less likely to
create confusion.
`dirent.path` value has not been stable, moving it to a different
property name should avoid breaking some upgrading user expectations.

PR-URL: nodejs#50976
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
@nodejs-github-bot nodejs-github-bot added fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. v18.x Issues that can be reproduced on v18.x or PRs targeting the v18.x-staging branch. labels Dec 2, 2023
PR-URL: nodejs#51020
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Refs: nodejs#51020
PR-URL: nodejs#51059
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
@richardlau richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 15, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 15, 2024
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

richardlau pushed a commit that referenced this pull request Mar 18, 2024
The goal is to replace `dirent.path` using a name that's less likely to
create confusion.
`dirent.path` value has not been stable, moving it to a different
property name should avoid breaking some upgrading user expectations.

PR-URL: #50976
Backport-PR-URL: #51021
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
richardlau pushed a commit that referenced this pull request Mar 18, 2024
PR-URL: #51020
Backport-PR-URL: #51021
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
PR-URL: #50976
richardlau pushed a commit that referenced this pull request Mar 18, 2024
Refs: #51020
PR-URL: #51059
Backport-PR-URL: #51021
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
PR-URL: #50976
@richardlau
Copy link
Member

Landed in 96514a8...194ff6a.

@richardlau richardlau closed this Mar 18, 2024
@aduh95 aduh95 deleted the backport-dirent-parentPath branch March 18, 2024 18:16
sonsurim pushed a commit to sonsurim/node that referenced this pull request Jul 21, 2024
…addir'

The issue was caused by a modification in PR nodejs#51021 , which was working on including the parentPath in the documentation and modifying the path to display the filepath.
I have retained the content related to the documentation and removed the filepath part.

Fixes: nodejs#52441

Co-authored-by: daeyoen <6630703+daeyeon@users.noreply.github.com>
Co-authored-by: injae-kim <injae-kim@users.noreply.github.com>"
sonsurim pushed a commit to sonsurim/node that referenced this pull request Jul 21, 2024
The issue was caused by a modification in PR nodejs#51021, which included changes
to the documentation for parentPath and modifications to display the filepath.
I have retained the content related to the documentation and removed the
filepath part.

Fixes: nodejs#52441
Co-authored-by: injae-kim <injae-kim@users.noreply.github.com>
sonsurim pushed a commit to sonsurim/node that referenced this pull request Jul 21, 2024
The issue was caused by a modification in PR nodejs#51021, which included changes
to the documentation for parentPath and modifications to display the filepath.
I have retained the content related to the documentation and removed the
filepath part.

Fixes: nodejs#52441
Co-authored-by: injae-kim <injae-kim@users.noreply.github.com>
sonsurim pushed a commit to sonsurim/node that referenced this pull request Jul 21, 2024
The issue was caused by a modification in PR nodejs#51021,
which included changes to the documentation for parentPath
and modifications to display the file path.
I have retained the content related to the documentation
and removed the filepath part.

Fixes: nodejs#52441
Co-authored-by: injae-kim <injae-kim@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. v18.x Issues that can be reproduced on v18.x or PRs targeting the v18.x-staging branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants