Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format time using channel or bot's format #50

Merged
merged 1 commit into from
Jan 16, 2022

Conversation

Exirel
Copy link
Contributor

@Exirel Exirel commented Jan 15, 2022

Following discussion about formatting time, this change the time format from:

user > channel -> config

to:

channel -> config

directly.

For good measure, it also uses the channel or config's timezone.

Oh, and also there was this weird type(date) == 'datetime' thing, I don't understand why, I just fixed it.

Following discussion about formatting time, this change the time format
from user > channel -> config to channel -> config directly.

For good measure, it also uses the channel or config's timezone.
@dgw dgw added this to the 0.5.0 milestone Jan 16, 2022
@dgw dgw added the tweak label Jan 16, 2022
Copy link
Member

@dgw dgw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that type(date) thing was silly.

I'm sure there was some reason not to pass the zone to format_time() but I don't know what it was. I don't see how it would be super useful to always have video timestamps presented in UTC. 🤷‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants