-
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use BooleanAttribute
setting type (requires Sopel 7.1+)
#41
Conversation
The person responsible for implementing this new setting type (also me) probably should have set it up to accept the old `ValidatedAttribute` style silently in 7.x, and start warning in 8.0, but oh well. Even if that's changed for an upcoming patch release of Sopel, this patch still needs to be written at some point.
Since we're py3.6+ now, you can also remove the coding comment and update the future imports. |
No, I can't. Sopel 7.1 still needs to run on py2.7 & 3.3+. |
Will combine with compatibility tweaks, testing, & version bump for Sopel 8. sopel-irc/sopel#2164 silenced this warning for the remainder of 7.1's life-cycle. |
If you merge that one, I can switch this plugin from sopel_modules to entry point! Also I'm interested in upgrading requirements, and that would be nice to have this one already. |
I don't see any reason to change the packaging method "just because". If the package type changes, it should be done at a clean breakpoint such as the transition to Sopel 8—at which time we could simply mark the
This can be done at any time assuming the upgraded requirements still work with Sopel 7.x. (I saw the comment on IRC about |
That is a very good idea.
Absolutely yes! There is no reason for this plugin to stop working with the full range of supported Python version for 7.x. |
After #50 I'm planning to have 0.5.0 support Sopel 7.1.x+ only, so this will be included in the next release. Still planning to migrate things onto the entry-point plugin model sometime during the Sopel 8.0 cycle, because it offers us a clean breakpoint as mentioned before. (This plugin, and most of its cousins within @sopel-irc, explicitly specifies |
The person responsible for implementing this new setting type (also me) probably should have set it up to accept the old
ValidatedAttribute
style silently in 7.x, and start warning in 8.0, but oh well. Even if that's changed for an upcoming patch release of Sopel, this patch still needs to be written at some point.Oh—fixes #40.