Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use BooleanAttribute setting type (requires Sopel 7.1+) #41

Merged
merged 1 commit into from
Jan 20, 2022

Conversation

dgw
Copy link
Member

@dgw dgw commented Jul 20, 2021

The person responsible for implementing this new setting type (also me) probably should have set it up to accept the old ValidatedAttribute style silently in 7.x, and start warning in 8.0, but oh well. Even if that's changed for an upcoming patch release of Sopel, this patch still needs to be written at some point.

Oh—fixes #40.

The person responsible for implementing this new setting type (also me)
probably should have set it up to accept the old `ValidatedAttribute`
style silently in 7.x, and start warning in 8.0, but oh well. Even if
that's changed for an upcoming patch release of Sopel, this patch still
needs to be written at some point.
@dgw dgw added the tweak label Jul 20, 2021
@dgw dgw added this to the 0.4.2 milestone Jul 20, 2021
@half-duplex
Copy link
Member

Since we're py3.6+ now, you can also remove the coding comment and update the future imports.

@dgw
Copy link
Member Author

dgw commented Jul 30, 2021

No, I can't. Sopel 7.1 still needs to run on py2.7 & 3.3+.

@dgw
Copy link
Member Author

dgw commented Sep 22, 2021

Will combine with compatibility tweaks, testing, & version bump for Sopel 8. sopel-irc/sopel#2164 silenced this warning for the remainder of 7.1's life-cycle.

@Exirel
Copy link
Contributor

Exirel commented Oct 22, 2021

If you merge that one, I can switch this plugin from sopel_modules to entry point!

Also I'm interested in upgrading requirements, and that would be nice to have this one already.

@dgw
Copy link
Member Author

dgw commented Oct 22, 2021

If you merge that one, I can switch this plugin from sopel_modules to entry point!

I don't see any reason to change the packaging method "just because". If the package type changes, it should be done at a clean breakpoint such as the transition to Sopel 8—at which time we could simply mark the sopel_modules.youtube package as deprecated in favor of a new one that follows our current naming conventions (sopel-youtube in this case).

Also I'm interested in upgrading requirements

This can be done at any time assuming the upgraded requirements still work with Sopel 7.x. (I saw the comment on IRC about google-api-python-client 1.x vs. 2.x, yes.)

@Exirel
Copy link
Contributor

Exirel commented Oct 22, 2021

at a clean breakpoint such as the transition to Sopel 8

That is a very good idea.

This can be done at any time assuming the upgraded requirements still work with Sopel 7.x.

Absolutely yes! There is no reason for this plugin to stop working with the full range of supported Python version for 7.x.

@dgw dgw modified the milestones: 0.4.2, 0.5.0 Nov 22, 2021
@dgw
Copy link
Member Author

dgw commented Jan 16, 2022

After #50 I'm planning to have 0.5.0 support Sopel 7.1.x+ only, so this will be included in the next release.

Still planning to migrate things onto the entry-point plugin model sometime during the Sopel 8.0 cycle, because it offers us a clean breakpoint as mentioned before. (This plugin, and most of its cousins within @sopel-irc, explicitly specifies <8 in the sopel version requirement, so that's the natural time to deprecate the sopel-modules.youtube package name.)

@dgw dgw merged commit 8c674ab into master Jan 20, 2022
@dgw dgw deleted the use-BooleanAttribute branch January 20, 2022 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch to BooleanAttribute
3 participants