config.types: silence parse==bool warning until 8.0
#2164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turns out *a lot* of plugins use `ValidatedAttribute(..., parse=bool)`, and this is hardly a breaking change. It makes the most sense to tie this warning to a major version, rather than forcing plugin authors to require a minimum minor release of Sopel.
Exirel
approved these changes
Jul 24, 2021
dgw
added a commit
that referenced
this pull request
Aug 9, 2021
…ning config.types: silence `parse==bool` warning until 8.0 Cherry-picked from master: c301d97
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Turns out a lot of plugins use
ValidatedAttribute(..., parse=bool), and this is hardly a breaking change. It makes the most sense to tie this warning to a major version, rather than forcing plugin authors to require a minimum minor release of Sopel.There's no technical reason to change this. It's a philosophical choice that came up for me when reviewing other plugins that make use of bools in their config sections. This warning just isn't useful immediately after deprecation; plugin authors can adopt the new type voluntarily, but Sopel doesn't need to force it in 7.x. Migrating to this new type can be part of the 8.0 migration guide, as a new major release of Sopel would be a natural point to bump plugin requirements. (That goes double for anyone using our cookiecutter template, since it pins
sopel>=current_major,<next_majorby default.)Checklist
make qa(runsmake qualityandmake test)Notes
No, I don't know why I left this line out of #2044. It absolutely makes sense given the planned removal isn't until 9.0, but there's no defense for me. I just forgot. 😅