Configuration of Flood Protection #1617
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thorough configuration is already pending in #1518 (feel free to test; more testers means fewer bugs slip into the next release). Giving the flood protection tweakable knobs like that PR does allows essentially disabling it, too. I'm mostly giving you immediate feedback on where your work overlaps with stuff already in the pipeline. I won't give a knee-jerk reaction to making the repetition detection toggleable—I want to think about it properly, and I'm a bit distracted at the moment. 😅 |
|
Ah, thanks - I must have only searched for issues, not existing PRs. I'll create a new issue specifically about repetition detection, since that doesn't seem to fall under that PR. Closing in favour of #1518. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to make both the message throttle and loop detection features optional, as per #1342.
The features were both given a simple on/off toggle, as I anticipate more thorough configuration will be planned in #1559 and don't want to pre-empt it.