-
-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rules: add find and search rules #1881
Conversation
This comment has been minimized.
This comment has been minimized.
92f166f
to
460c6f2
Compare
This comment has been minimized.
This comment has been minimized.
460c6f2
to
da186d6
Compare
This comment has been minimized.
This comment has been minimized.
da186d6
to
5d0f935
Compare
This comment has been minimized.
This comment has been minimized.
5d0f935
to
161a90a
Compare
Rebased on your behalf, @Exirel. Look over it and mark ready for review if you're satisfied! |
Hmmmm not a huge fan of the rebase yourself, because it tends to mess with my local working copy when I pull. :( |
161a90a
to
65fb76a
Compare
Re-signed & ready for review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's just little things. The tests prove that this (should) work as intended, so I focused on making sure the documentation was clear for plugin authors.
Co-authored-by: dgw <dgw@technobabbl.es>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, do we get to squash the docstring fixes in with the original changes, or is that a pain? x)
Pain. It is. |
In that case: Merge. It is. |
Fixes #1757
Draft PR for now, until #1873 is at least approved.
Description
Based on #1873 this PR adds two new rules:
Checklist
make qa
(runsmake quality
andmake test
)