Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bot: deprecate (un)register_url_callback() functions #2049

Merged
merged 1 commit into from
Apr 11, 2021

Conversation

dgw
Copy link
Member

@dgw dgw commented Mar 30, 2021

Description

Tin. They were a stopgap, and they have served their purpose.

Checklist

  • I have read CONTRIBUTING.md
  • I can and do license this contribution under the EFLv2
  • No issues are reported by make quality (did not touch anything testable)
  • I have tested the functionality of the things this change touches

They were a stopgap, and they have served their purpose.
@dgw dgw added this to the 7.1.0 milestone Mar 30, 2021
@dgw dgw requested a review from a team March 30, 2021 07:24
@dgw
Copy link
Member Author

dgw commented Mar 31, 2021

Bit concerning that a random test (fittingly, in rand.py) failed on py2, but the same CI job passed when restarted the next day… Would love to know how sopel/modules/rand.py::test_example_rand_4 ended up with 9 outputs instead of 10 on an unrelated PR check, but it's not a problem with this patch.

@dgw dgw merged commit 0e49986 into master Apr 11, 2021
@dgw dgw deleted the deprecate-manual-url-callback-reg branch April 11, 2021 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants