sopel: use python3 style class and abc.ABC #2138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgw
requested changes
Jul 5, 2021
Exirel
force-pushed
the
class-py3-style
branch
2 times, most recently
from
53caa7d
to
dc836bc
Compare
In Python 2, there was 2 styles: * `class ClassName:` * `class ClassName(object)` And they behaved differently, and using `super()` is different too. However, in Python3, both are equivalent to doing the second style, and we can use `super()` directly. So, yeah. Yet another weird thing about py2/py3.
And also add some type hint when easy to do so.
Exirel
force-pushed
the
class-py3-style
branch
from
dc836bc
to
9f83a59
Compare
|
Fixed merge conflict. |
dgw
approved these changes
Sep 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In Python 2, there was 2 styles:
class ClassName:class ClassName(object)And they behaved differently, and using
super()is different too. However, in Python3, both are equivalent to doing the second style, and we can usesuper()directly. I remember having to work with Py2.4 compatible code in my career, and this "new style class" stuff was... a pure nightmare. I'm just glad we can get rid of this.Also, there is now
abc.ABCthat allows to describe an abstract class as being abstract. This is interesting because it doesn't require to addraise NotImplementedErroranymore: a few decorators and it's all good!One last thing: I added few type hint here and there, and I had fun with
TypeVar. It's looking good!Note: I think I want a "housekeeping" or "cleaning code" label or something. 😁
Checklist
make qa(runsmake qualityandmake test)